From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bruce Ou <oubruce1234@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: fix CamelCase warnings for bResult and Address in rtw_efuse.c
Date: Tue, 7 Jul 2026 13:27:00 +0200 [thread overview]
Message-ID: <2026070748-army-tweezers-dbff@gregkh> (raw)
In-Reply-To: <20260623085650.17951-1-oubruce1234@gmail.com>
On Tue, Jun 23, 2026 at 04:56:49PM +0800, Bruce Ou wrote:
> Signed-off-by: Bruce Ou <oubruce1234@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_efuse.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index b5dc5892f..355ac2004 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -44,7 +44,7 @@ Efuse_CalculateWordCnts(u8 word_en)
> u8
> EFUSE_Read1Byte(
> struct adapter *Adapter,
> -u16 Address)
> +u16 address)
> {
> u8 byte_temp = {0x00};
> u8 temp = {0x00};
> @@ -53,13 +53,13 @@ u16 Address)
>
> Hal_GetEfuseDefinition(Adapter, EFUSE_WIFI, TYPE_EFUSE_REAL_CONTENT_LEN, &content_len);
>
> - if (Address < content_len) {/* E-fuse 512Byte */
> + if (address < content_len) {/* E-fuse 512Byte */
> /* Write E-fuse Register address bit0~7 */
> - temp = Address & 0xFF;
> + temp = address & 0xFF;
> rtw_write8(Adapter, EFUSE_CTRL + 1, temp);
> byte_temp = rtw_read8(Adapter, EFUSE_CTRL + 2);
> /* Write E-fuse Register address bit8~9 */
> - temp = ((Address >> 8) & 0x03) | (byte_temp & 0xFC);
> + temp = ((address >> 8) & 0x03) | (byte_temp & 0xFC);
> rtw_write8(Adapter, EFUSE_CTRL + 2, temp);
>
> /* Write 0x30[31]= 0 */
> @@ -89,7 +89,7 @@ u16 addr,
> u8 *data)
> {
> u32 tmpidx = 0;
> - u8 bResult;
> + u8 result;
This should now be a boolean, right?
thanks,
greg k-h
prev parent reply other threads:[~2026-07-07 11:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 8:56 [PATCH] staging: rtl8723bs: fix CamelCase warnings for bResult and Address in rtw_efuse.c Bruce Ou
2026-07-07 11:27 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026070748-army-tweezers-dbff@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=oubruce1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox