The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Joshua Crofts <joshua.crofts1@gmail.com>
To: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Ariana Lazar" <ariana.lazar@microchip.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Jonathan Cameron <jic23@kernel.org>,
	stable@vger.kernel.org,  Joshua Crofts <joshua.crofts1@gmail.com>
Subject: [PATCH] iio: dac: mcp47feb02: add missing 'select REGMAP_I2C' to Kconfig
Date: Wed, 08 Jul 2026 21:50:28 +0200	[thread overview]
Message-ID: <20260708-add-missing-regmap-dac-v1-1-e5925fb1fe23@gmail.com> (raw)

The Kconfig entry for the MCP47FEB02 is missing a 'select REGMAP_I2C',
causing build failures.

Fixes: bf394cc80369 ("iio: dac: adding support for Microchip MCP47FEB02")
Cc: stable@vger.kernel.org
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
This patch adds a missing 'select REGMAP_I2C' to the MCP47FEB02 Kconfig
entry. Without this, some builds may result in a failure.

Steps to reproduce build failure:
1. Run `make allnoconfig`.
2. Run `make menuconfig` and select I2C, IIO and the MCP47FEB02 driver.
3. Run `make .` and make will end with regmap-related errors.

An excerpt of the errors produced during the above build:
drivers/iio/dac/mcp47feb02.c: In function ‘mcp47feb02_probe’:
drivers/iio/dac/mcp47feb02.c:1114:32: error: implicit declaration of function ‘devm_regmap_init_i2c’ [-Wimplicit-function-declaration]
 1114 |                 data->regmap = devm_regmap_init_i2c(client, &mcp47feb02_regmap_config);
      |                                ^~~~~~~~~~~~~~~~~~~~
drivers/iio/dac/mcp47feb02.c:1114:30: error: assignment to ‘struct regmap *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
 1114 |                 data->regmap = devm_regmap_init_i2c(client, &mcp47feb02_regmap_config);
      |                              ^
---
 drivers/iio/dac/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
index 657c68e75542..14a246729d2b 100644
--- a/drivers/iio/dac/Kconfig
+++ b/drivers/iio/dac/Kconfig
@@ -552,6 +552,7 @@ config MCP4728
 config MCP47FEB02
 	tristate "MCP47F(E/V)B01/02/04/08/11/12/14/18/21/22/24/28 DAC driver"
 	depends on I2C
+	select REGMAP_I2C
 	help
 	  Say yes here if you want to build the driver for the Microchip:
 	  - 8-bit DAC:

---
base-commit: fef4337eb2888c758c7058e1723903204f012a26
change-id: 20260708-add-missing-regmap-dac-abcf866aac1f

Best regards,
-- 
Kind regards

CJD


                 reply	other threads:[~2026-07-08 19:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260708-add-missing-regmap-dac-v1-1-e5925fb1fe23@gmail.com \
    --to=joshua.crofts1@gmail.com \
    --cc=andy@kernel.org \
    --cc=ariana.lazar@microchip.com \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox