From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24C9A23B638 for ; Wed, 8 Jul 2026 03:05:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783479933; cv=none; b=MwiX1fmC2wtJFcNmqxBI6rWEouqNjB7ACFaxEcBAlc+7ImmjLsWmlZdNnjRIKT/wnKlrYvHdOqElOAPVmn7pvHQOebJQCrXIoUbm0A5GZkvSDeApmdVMe9Szffat8EhAxEENwUSN3sk0ZNBq8fkqPrikNQhcHsRKbEYnSjjBwN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783479933; c=relaxed/simple; bh=RDjNVBHsJeP5xhO7Wyb7fa29u/GNUNTqbCtElT40KWc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jSRIk4jy7zMLW4Xd/67orKigLITsc45vlJbkFys2pEnhBLab18ufHBncO3OrpL1EnohxJzl5imfSn2qxuz+lI2LmMW1aJmI0P3a7fjgMEZOSnnHhFLdsyUjgP0tVbPEKrr4t4c5SZhhxYTSq6U+K2oVxjMaxxkUsFRgYjrgmBe0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jckxlL8s; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jckxlL8s" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2cab973140bso2990245ad.3 for ; Tue, 07 Jul 2026 20:05:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783479931; x=1784084731; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=fxkLrYr5aWISG484jr5FD5Wa9ToyrlfnhtwYV/kULB8=; b=jckxlL8sluSO9pZ0nEwj3yGnwpn0Qk8DbDBmAazAyOxRfbMtdQ+n+OxbIRbYB+ISm4 XH500hWIBq3/xu9zdSwms6FSb7Sv5U0XI/Bzs4Yb+zEMQ1Oa25ZBCY9nuMxZL668jeA2 9MXvqFDHi4OEZwOlYHmG3CAIc1ziFWckmlmuYwhUGDTQQNrNXYHOkup6RxR2gG5kYrcK y+gudrp75q7B4pBx5/Lrwab2MTgLCvZND5n1Q9ziAQ9CWKoMpIUu8U2pvl3YCW81nUVp voZk4ZEdFhjP0bv7VYc7lWAKVVZWQAjn1YcLvgAhQlGjZ6eM9DnPts8QaEbdgTmvh4ak KgbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783479931; x=1784084731; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fxkLrYr5aWISG484jr5FD5Wa9ToyrlfnhtwYV/kULB8=; b=qp+weiDNo4qay+o2PhU9B7NLg7acZzx1hgsZIt3oPRyWI3Qc3iQ01y2Seq++4p6H4l 2SN9Nzov0QFDmC7Qjn+xPp4w2JLU0dBrkuZY6o9V/5SrkcsPQEx3M5ZxeEVWtkZwT0uz Tq2OgzrRuoxvknBMDzQRb20qNWSe8U6dgAljtAcc4PoFDzKaUs4ql8zanScWIc+SoYLI FfeKi4JtJ513pIIeGGzw8wa4CtMMwxd7qPCQxfs2sWnMBinH2X4cIfoWOz5Yt2Zg76ro W0ucGPQaKD5jgk9uXHByoRMsF6CzxuwcVtbRnMxF0w237UMKXUj5RC3ZaTFYqIKqB31/ Q1Rw== X-Forwarded-Encrypted: i=1; AHgh+RrdtqKVJRsCKnxaWpRKGTopuD0suSTa8FcEYa3RPhNoCqAJBAUt3yvCOG7kg+nw8qc4FTpCut8Ypujfyxo=@vger.kernel.org X-Gm-Message-State: AOJu0YzdPNsp82KAvKcrf5R6AZiwTtuyj0oe2zWQirJShpOtMZ9KqA60 i/vqeQrJIruYuHOajYaBpZb+xtjA0WnqxYB6DK67eQhOs1pKhl+JKMI1 X-Gm-Gg: AfdE7ckUAcDJWJk2PaPmbyTpvF1PuZ/hHwzXTxqaCEE0XOlepbuq5NoW27+KJV92ihm ZXt2H9JOcyqFowBxriK5A8AP//GLoeewerTwabAq00VkwCIRt42A0t9DqlbHMzG9IRPrrWJ2kzM ydtbGLp4DTmSu+a5Af8esM9al7tW3ivTfcSiifFZKzPHopUMUzz4F5YRmA1VCJdQzjehxekPF9k 0YMa7mBy7/Rxp7A0xiCAvsvHrM39ev6J5YVL4cOnVYofL4bkXSU87GuTttmbFUSQd+NErQTaeBQ 94hIxnHhjMEBRo0nSneccjLaSvPf7iUfkMbDlPE8cpbYqvEOlhk5wIoF3fw23d6X86e8EKqvJJU 1SjfQjDr0BmCeMgZ/BoEjEQ20lGGaKi2ZMwttKvmI+db5mhQ6XBSloghacPTkmDJzuxTctDmwVP iHDpR5FPqBXLQRY+2ovXp9OeP+zzXW7exTcieL0IPJ9C1yzC3kUbzcX9Oxpg== X-Received: by 2002:a17:903:1a87:b0:2cc:e620:e307 with SMTP id d9443c01a7336-2ccea3b0e71mr6494625ad.20.1783479931549; Tue, 07 Jul 2026 20:05:31 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d3d45csm20099865ad.62.2026.07.07.20.05.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 20:05:31 -0700 (PDT) From: phucduc.bui@gmail.com To: Markus Schneider-Pargmann , Marc Kleine-Budde , Vincent Mailhol Cc: Kendall Willis , linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v3] can: m_can: Use of_property_present() for wakeup-source Date: Wed, 8 Jul 2026 10:05:12 +0700 Message-ID: <20260708030512.8570-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc The 'wakeup-source' property is declared as a phandle-array in both YAML bindings and Device Tree source files. However, the driver currently uses of_property_read_bool() to check for its existence. According to the function's documentation, usage on non-boolean property types is deprecated. Switch to of_property_present() to comply with the recommended API for checking the presence of a property. Fixes: 04d5826b074e ("can: m_can: Map WoL to device_set_wakeup_enable") Reviewed-by: Kendall Willis Acked-by: Markus Schneider-Pargmann Signed-off-by: bui duc phuc --- Note: It was originally posted in May and has already received both Reviewed-by and Acked-by tags. I'm resending it to bring it back to attention in case it was overlooked. Changes in v3: - Add Reviewed-by tag - Resend. Changes in v2: - Add Acked-by tag - Add Fixes tag drivers/net/can/m_can/m_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index eb856547ae7d..16f80607e150 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -2464,7 +2464,7 @@ struct m_can_classdev *m_can_class_allocate_dev(struct device *dev, return ERR_PTR(ret); } - if (dev->of_node && of_property_read_bool(dev->of_node, "wakeup-source")) + if (dev->of_node && of_property_present(dev->of_node, "wakeup-source")) device_set_wakeup_capable(dev, true); /* Get TX FIFO size -- 2.43.0