From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 611D3227EB9 for ; Wed, 8 Jul 2026 04:07:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783483665; cv=none; b=S48ovBirJBRK9ngY+Pn45eSqChSwpL18F/Ev4QrON8uNRyALj+iAjlrzH0pt+1WHEP4eBHDI+dSud5BzgZdk0+dT2OjS6g1q3bwWZsIBPZv5wF64SDU+Njv2tquRdNOr66CU38ahNAIUeG+dyLVONuxpoLHVjnpdogVdCCQg4J8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783483665; c=relaxed/simple; bh=m10CAdrsp6p54FwpwugijpPVB9yBAv2eSCq9P2w9kWQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NYdqEyyn3rpvtjZwbiOuqmtUCs2SheFMiXpwnfw/bhPg40lTuu4FToGiqjoX6Zzqi/p9vG6zRKIXehUuEoWUpOsUMZIlDqaO1ZL8CQQAJpTRQ9rhJOVttw/UxJF8Sfn6zweemap2tQ6p4yMmylJDTCSWTfo1pou1Y4I2LYS3VRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fU9hLO64; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fU9hLO64" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-384c94c9414so213986a91.3 for ; Tue, 07 Jul 2026 21:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783483664; x=1784088464; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=9Rv2Gw3WLZDDDoso1NlG7NBYclNw3yTv5b2yJb+ChmY=; b=fU9hLO64Cxge+9BKJQYPbNUioRhYMmq956sdV/Tp4tbznX3A3nUJ9tOmUZPlwkcAug OHx6mGspAJeJRIIWLrN+QURHOS2lk2MMf/v5upSw38uRQYWcRifeTiCZtf3oQrgs5iNj 3AupUkGd3cOFdUdZlhrhcW5OMUNBnDcSNIxsWL0yIlq9a9MYPd2R7PVi0JIAhm/LjqXK VJuB4LWB1WCrjnEhUa7hk6gNe5mf4vt2JDUYugo21nj5PySRyyGoIHkKTssGlFi35gUG I7q6AaYhvjBiuWLonFYhX5BHDRy5KXgQw0mjsXt9x088yQNgyVyoeW4l25uYii8eLpcb UBaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783483664; x=1784088464; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9Rv2Gw3WLZDDDoso1NlG7NBYclNw3yTv5b2yJb+ChmY=; b=SP0TYCM1SU2KjR0La4TOp39EgQSNxHzNTVaODJe7BOXlXPxxaxOQiy8xGaOGkquXeu E0dUj4w5fdQLBAZtPMA8jhCSYO+eiXlvt+17GOPuB7TslKguyTxNbUBguLQyB7Y1jW75 K1tpWpGbqw1RByAA9NkIVRwa0A8iK8zWFMEBxmcNaKIyUe29yxE9LY22QbbBI1FOy3gE z0j4dtiwgDDjYXSRW6faN3Gc3flI/ziXkF/8eukJHO9caw5iZVWhyx/rd54krcpTWwUh AoTqMKS4eeSGUCOMREJOtGrvliTE0SEPpn2KRQyTujx8/qHMGBZgvIou0eFCPM/9NY73 mJOw== X-Forwarded-Encrypted: i=1; AHgh+Rqs+tmAIRklYBItUayucyVsAHeIULNVuKnpUlX9SmU4b2s73HmPnRxPdZRiEd+TyRMeNW3/s6Wxnvms2Hw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5DwTLFbhbC4De2iyt0U+MfpsqYVhRWeTLiv+rinhcJjpj8QnW NWVLkZM+IKtFBPnwm2tNJTZmwJFWyO8EjFf5/jMJuLgiG+waL0dzNvW9 X-Gm-Gg: AfdE7cm1sUQGwgjjWRCIjLNqFtF0ZKVmNTKaHpFEOdyWrCtHgMQGWAUGadYT5YcGzFJ 0Zcx65KSW3UkTsqMYe1Lp4c1aUBQyOHLlx8c4wkAMlJSdzHX8zTXX3cG1+mCdvBV7drgnahAVUz gd0gl5yqDVEa5zg3pJ7ldJ79ysknw1o9AoBQq6B0IuOeUoZvFkglX1WVIhGbeSiPUV0lVEoS50G 72gZHasgYQuGCLvSr65io/UiUKGIRyHYSTW3fWXl7wcOJ8MjgR12uuQPByVJc1vWWTIZJRVJwoT InHbk+w9Ujcervu9YAuY8v2gugykW9JVpmTGY6CMY67T+B5X9OD0K90naQ9AldrvjQZOxh3BoWB 0SzGlZqsMaZ/IJlKpgBb/WStdX9y780RB0iWdYnDQECZiyCtHw3T7TuGn8vMgJyCVreXOJT2QC0 GwrKMZ7Undazwswd7pk05QQVPsTtp159XNrQ4dK+bHchWZtAUHRmgDKt/00vmEmvQlqvtUsHb6Z rOZyBSubW2tHnYTrmFOSJ89zKflyKIRWQ== X-Received: by 2002:a05:6a21:6e86:b0:3b5:a008:683c with SMTP id adf61e73a8af0-3c0bcb803c7mr844879637.45.1783483663634; Tue, 07 Jul 2026 21:07:43 -0700 (PDT) Received: from u2404-VMware-Virtual-Platform.tailf6b5e0.ts.net ([24.4.24.156]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31189cd8234sm4198982eec.9.2026.07.07.21.07.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 21:07:43 -0700 (PDT) From: Sun Jian To: bpf@vger.kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, eddyz87@gmail.com, memxor@gmail.com, martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, jolsa@kernel.org, emil@etsalapatis.com, shuah@kernel.org, mmullins@fb.com, shung-hsi.yu@suse.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Sun Jian Subject: [PATCH bpf v3 0/2] bpf: Reject negative const offsets for buffer pointers Date: Tue, 7 Jul 2026 21:07:13 -0700 Message-ID: <20260708040715.116680-1-sun.jian.kdev@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Reject negative effective offsets for PTR_TO_TP_BUFFER and PTR_TO_BUF buffer accesses, and add raw tracepoint writable coverage for both load-time rejection and the attach-time max_tp_access path. --- Changes in v3: - Check constant var_off against +/-BPF_MAX_VAR_OFF before computing the effective access range, matching the existing verifier pointer offset convention. - Keep explicit rejection of negative instruction offsets and keep bounded negative constant var_off valid when the effective offset is non-negative. Changes in v2: - Split the kernel fix and selftests into separate patches. - Add an attach-time raw tracepoint writable test that exercises max_tp_access against nbd_send_request's writable size. - Adjust selftest formatting to use the 100 character line width. Tested: - ./test_progs -t verifier_raw_tp_writable - ./test_progs -t raw_tp_writable_reject_nbd_invalid -v - ./test_progs -t raw_tp_writable_test_run v2: https://lore.kernel.org/bpf/20260707060804.93561-1-sun.jian.kdev@gmail.com/ v1: https://lore.kernel.org/bpf/20260703035137.109608-1-sun.jian.kdev@gmail.com/ Sun Jian (2): bpf: Reject negative const offsets for buffer pointers selftests/bpf: Cover negative raw_tp writable buffer offsets kernel/bpf/verifier.c | 48 +++++++++++++-- .../raw_tp_writable_reject_nbd_invalid.c | 58 +++++++++++-------- .../bpf/progs/verifier_raw_tp_writable.c | 16 +++++ 3 files changed, 93 insertions(+), 29 deletions(-) base-commit: 12091470c6b4c1c14b2de12dcbae2ada6cb6d20b -- 2.43.0