From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52E8F4028E8 for ; Wed, 8 Jul 2026 08:43:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783500199; cv=none; b=hV4UdWwceOTzhM97V/O3E17867lOiys0aP8fmScQ6XmdLg9m/TQD0jqSS+2/5xPX5Ij+eXP3Ce750VjxZpkOTNp2DHuAPQxcpa9TCYLgQ8HpZlovVl5KIUBRYIaV/DlXaSl66EiC7lKU6kX4R6nio49GiXKK/Onjqy80vqG3U2c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783500199; c=relaxed/simple; bh=JFYJwNlUeDpI30EK0lLd4/qcoBnLBogsGxkiN8Nw4iI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ic95nbYVVnG8phkabGbfIW7ZypIKOWkJfupulHfy+AuiH5OdtHxutLzj8MrsCVOAVsBYUssmH+J+XiIcET4XCeD5Rk7XX4+GgjdV56ylFIbow5EbImXibOrgQpYXq3jaBzZEtNYvs4TY9PTWEQox3v8vDqmH+kjA4CN4QHIlDSA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MuRlzJ4n; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MuRlzJ4n" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-3811074a8c5so366873a91.1 for ; Wed, 08 Jul 2026 01:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783500198; x=1784104998; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aHSKy3h5lLOjkvRp4gtYQf76cY5cLHkTNVDBkUf0G/I=; b=MuRlzJ4nS/wiOfzVWAS8dZxdW6hCFFw/uJaqCcmdsN1h2TupC2RUzjl6UCd0mCxuce j4nIuAEOc74F2L5OSR211sVPIBed6q9Xpuj8I6e1rB4dH4Ac5xTbm5mHWhBEzbp16ysc dt6iQXWiyujfAmoqobP5D7yBRW/PrSWFocozhK18Nu+Yu3Ry2Quh55HifeGeo8BaxB5N y92Uxzxy9fs6XWRt1z9AZMNyxc5LpeftUZQzTm8RR+t00SyvyQCOfK4zfun0KkTru9ur gv1u56RXrmkZSANuneTSq1/bJj+fQTRrr7lWkYAuCAj0ZcNMxqEbnERNdm60NIgs++w7 uexA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783500198; x=1784104998; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aHSKy3h5lLOjkvRp4gtYQf76cY5cLHkTNVDBkUf0G/I=; b=XlTigESSldgYm+lv8VEmgJ0KqgNuVE+NK4vssFavxmIMKRkXxu8FKFPCK1BUbAijJF ydMapXzqvqYOzgR40EfIzCf+rxgvmnEWZF6fEBHMrwfW7Lt+Ezoz08RAIPWWSBpuqpti x70FSciH82+iVNrIwkua9nuCw+UWJjNgiXqVtFx4x/m88NOEaJ/gPLSSRUR4+ZdOMHhw bfR+nrnWqIWrxVpPkbG/M2xd/Kp9AcSmCrONcz3IAI+ay1bPNmW0csm7iFP1wkszyiY/ YHtJU21oHtwXbL5D9Q785lDQuY7xe612Qc1x61EPD8XLnkMNl26IScz1Bj6OfNuEp487 cWsA== X-Forwarded-Encrypted: i=1; AHgh+RrOroVd9X/FAsvYAGWocS3d5DwXnO+trOhrtKEgj320z/YWaZhMeCDB/K0TZRSvY604PCw9kQRDxXNMGLg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxc9NUhAISIHPt1PYLtJvEIwHDYU4R7syrOE8+JXgKQdEYLTIWv j/v626dC7yZGE7dEp4xl+a2GEvyUPKBfivloLpGDIIY7k0GKU0UcAKWM X-Gm-Gg: AfdE7clGRbQmGdiu6TasQBZ0o90hMCx4GBRjg8yghct++z7y8B196pRnOFRpsMFjwkj d2movYYgaJrEaYKj3yAqqcQbBn1JFgJxDF/RsbzfLs6D5Vy6zadHQyR291ebOiyk6hbLFluIwdf fkkO95aY0+vehT9YE8J/jC6dN5o8xpz1OXvPIXKTpi1qMc9fMuhjulTySolfX9rOIeL9Hhf9Jsc 5J6JAT3AEeo/Gngrghmk0avCq4ncWwuyRehAifZlHxrZ9yf0HbRwE5PuO+le61zVq9U7AfWEexu /m53zCUiuE53SOturlJ/oBXCDPJti8f4tDeWDLjnEaptS0A8hxSJ33bEjs9TMSuli5dZD7Rh/30 5iZ++k1Pa3TPZlKYBvYw6i7mBT8zPJEFMO/n71j7EI8/joF4zYs4yoCMPsXGDupYIVI85tq/Ja5 71qgxBVYcj3AJEV5PySw== X-Received: by 2002:a17:90a:e183:b0:381:25ce:bcc2 with SMTP id 98e67ed59e1d1-3893fb6b6ebmr1536848a91.6.1783500197556; Wed, 08 Jul 2026 01:43:17 -0700 (PDT) Received: from ubuntu.. ([61.144.108.37]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-387d13fd7bfsm2478447a91.6.2026.07.08.01.43.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 01:43:17 -0700 (PDT) From: Jing Wu To: wangzhaolong@fnnas.com Cc: jirislaby@kernel.org, gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, yuanql9@chinatelecom.cn Subject: Re: [PATCH v6] serial: 8250: fix use-after-free in IRQ chain handling Date: Wed, 8 Jul 2026 16:43:11 +0800 Message-ID: <20260708084311.385934-1-realwujing@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <5cf37150673ea4d5c28f94db91cdf68504b50522.f7d28dac.3ec0.4c7f.8bb2.ce59501a4b8d@feishu.cn> References: <20260707-bug-221579-8250-shared-irq-race-v6-1-f8c499a90bdd@gmail.com> <0ede8499-abe2-41d3-bb0c-095c02c5b699@kernel.org> <5cf37150673ea4d5c28f94db91cdf68504b50522.0e091ec2.1d26.4eb2.8da3.53f8a6520707@feishu.cn> <20260708075732.4139996-1-realwujing@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > This accusation is not acceptable. It's not an accusation. It's a timeline. Your v1 predates ours by one day — not in dispute. But your v1 didn't work. You confirmed this yourself on May 29 when you wrote "v3 fixes the Bugzilla reproducer on my setup" — on *our* v3 thread, not yours. If your v1 already fixed the problem, you wouldn't have needed to test our v3 and report back. > That same locking change also closes the irq_info UAF window Your v1 commit message never mentions use-after-free. It discusses only "Unbalanced enable for IRQ." Our v1 was the first to identify and document both races. Claiming retroactively that your v1 "also" fixed UAF is revisionist. > For v3, the irq_chain_mutex rename was made in response to Jiri's review > comment Jiri made that comment on *our* v6, not yours. He reviewed our code. You took a review comment from our thread and applied it to your patch as if it were your own insight. > The __must_hold() and lockdep_assert_held() additions ... are not the > functional fix. They were added in our v5, reviewed by Greg on our v4. You copied them into your v3 and listed them as "Changes in v3" with zero attribution. Now look at the timeline: Jul 7 22:06 Our v6 — posted to the list Jul 8 11:11 Your v2 — next morning, same lock-move skeleton Jul 8 15:23 Your v3 — hours later, copies irq_chain_mutex rename, __must_hold(), lockdep_assert_held() from our v5/v7 If we hadn't replied to Jiri and sent v6, would your v2 exist the next morning? If we hadn't renamed hash_mutex in v7, would your v3 appear hours later with the same rename? The answer is obvious. > I do not agree to a Co-developed-by tag for my patch We added Co-developed-by for you on our v7. The only reason we did so is that you confirmed the fix worked on your setup — nothing more. You reported the bug, you tested the fix, we credited you. That's what open source contributors do. You, on the other hand, copied our lockdep annotations, our static analysis annotations, our mutex rename — all reviewed by Jiri and Greg on *our* patches — and passed them off as your own changelog entries. And now you're saying you won't extend the same basic courtesy in return. Copying is fine under GPLv2. Presenting it as your own work is not. You reported the bug. We fixed it. You copied our improvements. Add the tags. Jing