From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84772407CC3 for ; Wed, 8 Jul 2026 09:12:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783501925; cv=none; b=jr14FxgchwfYuP8Qd2M+RYXKLUHrOnEUIygF44K7va7S2olMQRafIi+WGcoeOzl+/aewnzQuKFjJZ/efRMEbrVdN2BlaX3qfKNbm/jeJkKL8hfofyQd03nX3C//eFqAlDzVuxkBoRaFY5hTA+/8j6uqJcM7BUE8hS726qje+kmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783501925; c=relaxed/simple; bh=/cVYweEI2jaSD5YPAIoWp7HmaE274mGopeccG6xhxAM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=epfBOICcdU5cdyRAVre/SGgjjlW1PUcpY4Xr+YSEobIslsyLwddofJKpbeReUrSFwm5cu+lVkRDwc62N6Hz84ejq2eqM1iAZAHLcs44rV46BeteU+juvCm4FG4PsVscdDr4rdKe36Tk4FXtFuGwKDnCPXMgeSdl8XLvcJEVwmP4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NLSGD2wN; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NLSGD2wN" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493ae59eca6so2286855e9.1 for ; Wed, 08 Jul 2026 02:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783501921; x=1784106721; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qk/gHIJvcYYiDjQzQyUo5tbWBK+ddodOy55VkH8+5ck=; b=NLSGD2wNpcDfCeG4CV0rC6kL0SPCCCwDK2GJmgJAS/mcXDYSlZu8Q0HaEk4bIFR7an ft4nWPDzzUrGka8kzP/zGO6JpxDUekWKcfm+dGKvS/uvvRUqgWoGXnabYfjTOlVi7l6Y FblxVo+RYLOMVEWzUw/DhAeX4oo4wr0NJRiCo8dIEAZ8lo6KAXGmBmhl6KOjA3doeMm+ SMy3gd8hKz5IvDLFXh4ekThKOS3VTSbKG8s26a2PzPzX0RS51/oC+HhlpjNVlxUpPOyw oscLf+yfykElVNvmWanp2mtUaU/3a/xhZeVDlDOuUlot//oT7zAKcM03xyw2/6f76rWZ Wotg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783501921; x=1784106721; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qk/gHIJvcYYiDjQzQyUo5tbWBK+ddodOy55VkH8+5ck=; b=WA63rRv2485RsaomAod+usQ8T5hb77inO7NC+3vDZXsumVh1EBA/1B11DYor9MscNp jPd5wmbceeUtdho/pJUgeWySeJJo6w9V0sVT2Du3GcY9Lv1gBNXNrB0QrVcGNSaoaPKD LxjT6eUUnQIOsyruYT8ut2hS9FeppxIM1yY+bW5brsu6QgMlemMyAHmLThEzDjl2d5ft P07le2Z2wj43MUZlbbsmCHNPjqzlUcanNbjKr8/0exWaHe3+Kzkv1lAiSM+iwxFGfdNB fxLAJRoI3qhz7SfhniGuPSkuqgBpOmrH1Qa1EXmyujCZ4T4mzoGEpTogxeWW/3oqgPt4 BnKw== X-Forwarded-Encrypted: i=1; AHgh+RpSZq0sDNrZ/5We+ky/myqXsNO4ZLypU4NxEzK/Qd8K7qkZ9G3fVfambFY5r9bu4YaAvaM0juzBC7XyTf4=@vger.kernel.org X-Gm-Message-State: AOJu0YxshhApLVZZLrP3GV2HfCTlSOKzb6xYFNCvWKFioWP015gKHzR8 2WSmF9efNpc65TXMQ8W+VoPRkIGN71N2qyxy/SICUCXoC3+Sj1eNYRZs X-Gm-Gg: AfdE7ckWIe4ZgH805HixPKfSTMFJ4fkjuY3zQpiLm/n/UcYc/OzaJl2YVLZ415JTdBZ TKOTkgNFKoNwmdu+BmzxuKTT2ICAX7h661f6glw954YRMjmEjtYADuDefHF8Bm8RH7ell9+1sPs ZCjBJF0NsGfUnGHz+IUEXSwOly0E5wdRTFF9CVIhppXFlB5nmK7MK+k1ofGlzHDCD+1Zm3Qb/4F yResr9NAnOroSVeArEUQi2d7mVUpXT920yWZO8VGiTtgyEddMGt9SQYpGYWr6LXdzKqj6OX73UP jW0G2Ekt9CBHlrGXXsY9q4HZIoaAfWAItgYPFV6GdeCi9IPIB/qKWt0wzhJO6MxxUZpVdcEvz9M OBz1qky3JLpqNxYosbLdal8DdtzdRkvBfgTXNKr0sagE/XzAioRc4zp8xQEYB7LkhAW9G5V2LRL npyb127l/cYJxxRvz1e2cLT8NDSj33R9pBjlblkeRNSTH1k1Qk5QRkNQ== X-Received: by 2002:a05:600c:3515:b0:493:bc92:2a2f with SMTP id 5b1f17b1804b1-493e6894936mr17222565e9.1.1783501920468; Wed, 08 Jul 2026 02:12:00 -0700 (PDT) Received: from localhost.localdomain ([2001:1670:1b:3626:64e6:9d2c:1204:3e04]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493e0f32660sm127772895e9.2.2026.07.08.02.11.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 08 Jul 2026 02:11:59 -0700 (PDT) From: Rounak Das To: dinguyen@kernel.org Cc: bp@alien8.de, rounakdas2025@gmail.com, tony.luck@intel.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 2/2] EDAC/altera: remove remaining CONFIG_64BIT ifdefs in the DB-error path Date: Wed, 8 Jul 2026 13:11:35 +0400 Message-ID: <20260708091135.94114-3-rounakdas2025@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260708091135.94114-1-rounakdas2025@gmail.com> References: <5060a303-0389-4c62-9c0c-fc4307c24897@kernel.org> <20260708091135.94114-1-rounakdas2025@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert the last two CONFIG_64BIT ifdefs to the is_s10 flag, so the whole driver selects behaviour from the ECC manager compatible. s10_edac_dberr_handler() is now built on 32-bit too; the symbols it uses are all available there. It only runs when is_s10 is true, so Arria10 behaviour is unchanged. Signed-off-by: Rounak Das --- drivers/edac/altera_edac.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index 24bdf7f5bac63..1d1e2b5ca14c8 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -2058,7 +2058,6 @@ static const struct irq_domain_ops a10_eccmgr_ic_ops = { /************** Stratix 10 EDAC Double Bit Error Handler ************/ #define to_a10edac(p, m) container_of(p, struct altr_arria10_edac, m) -#ifdef CONFIG_64BIT /* panic routine issues reboot on non-zero panic_timeout */ extern int panic_timeout; @@ -2105,7 +2104,6 @@ static int s10_edac_dberr_handler(struct notifier_block *this, return NOTIFY_DONE; } -#endif /****************** Arria 10 EDAC Probe Function *********************/ static int altr_edac_a10_probe(struct platform_device *pdev) @@ -2154,8 +2152,7 @@ static int altr_edac_a10_probe(struct platform_device *pdev) irq_set_chained_handler_and_data(edac->sb_irq, altr_edac_a10_irq_handler, edac); - -#ifdef CONFIG_64BIT + if (edac->is_s10) { int dberror, err_addr; @@ -2178,15 +2175,14 @@ static int altr_edac_a10_probe(struct platform_device *pdev) regmap_write(edac->ecc_mgr_map, S10_SYSMGR_UE_ADDR_OFST, 0); } - } -#else - edac->db_irq = platform_get_irq(pdev, 1); - if (edac->db_irq < 0) - return edac->db_irq; + } else { + edac->db_irq = platform_get_irq(pdev, 1); + if (edac->db_irq < 0) + return edac->db_irq; - irq_set_chained_handler_and_data(edac->db_irq, - altr_edac_a10_irq_handler, edac); -#endif + irq_set_chained_handler_and_data(edac->db_irq, + altr_edac_a10_irq_handler, edac); + } for_each_child_of_node(pdev->dev.of_node, child) { if (!of_device_is_available(child)) -- 2.50.1 (Apple Git-155)