From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Stefan Popa" <stefan.popa@analog.com>,
"Julien Stephan" <jstephan@baylibre.com>,
"Ivan Mikhaylov" <fr0st61te@gmail.com>,
"Marcelo Schmitt" <marcelo.schmitt1@gmail.com>,
"Marilene Andrade Garcia" <marilene.agarcia@gmail.com>,
"Kim Seer Paller" <kimseer.paller@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 0/3] iio: adc: add missing 'select REGMAP' to Kconfig
Date: Wed, 8 Jul 2026 10:01:50 +0200 [thread overview]
Message-ID: <20260708100150.00002436@gmail.com> (raw)
In-Reply-To: <ak4ApBBYdyVNd1Al@ashevche-desk.local>
On Wed, 8 Jul 2026 10:47:48 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Wed, Jul 08, 2026 at 07:34:11AM +0200, Joshua Crofts wrote:
> > This series adds missing `select REGMAP` and `select REGMAP_I2C` to the
> > AD7380/MAX34408/MAX14001 Kconfig entries. Without these, some builds
> > may result in a failure.
>
> > Steps to reproduce build failure:
> > 1. Run `make allnoconfig`.
> > 2. Run `make menuconfig` and select I2C/SPI, IIO and any of said drivers.
> > 3. Run `make .` and make will end with regmap-related errors.
>
> Repeating same mistake from the previous similar contribution. Where is the
> actual excerpt of the failure? Please, provide one.
>
Here is one of the several errors when compiling.
drivers/iio/adc/max14001.c: In function ‘max14001_probe’:
drivers/iio/adc/max14001.c:315:22: error: implicit declaration of function ‘devm_regmap_init’ [-Wimplicit-function-declaration]
315 | st->regmap = devm_regmap_init(dev, NULL, st, &max14001_regmap_config);
| ^~~~~~~~~~~~~~~~
drivers/iio/adc/max14001.c:315:20: error: assignment to ‘struct regmap *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
315 | st->regmap = devm_regmap_init(dev, NULL, st, &max14001_regmap_config);
| ^
Funny how I essentially copied the cover letter from the series where I added
missing IIO_TRIGGER_BUFFER entries to Kconfig - to which you didn't require
an example build error :-)
Shall I do a v2 or is this reply enough?
Thanks
--
Kind regards
CJD
next prev parent reply other threads:[~2026-07-08 8:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 5:34 [PATCH 0/3] iio: adc: add missing 'select REGMAP' to Kconfig Joshua Crofts
2026-07-08 5:34 ` [PATCH 1/3] iio: adc: ad7380: " Joshua Crofts
2026-07-08 14:32 ` David Lechner
2026-07-08 14:45 ` Joshua Crofts
2026-07-08 5:34 ` [PATCH 2/3] iio: adc: max34408: add missing 'select REGMAP_I2C' " Joshua Crofts
2026-07-08 5:34 ` [PATCH 3/3] iio: adc: max14001: add missing 'select REGMAP' " Joshua Crofts
2026-07-08 7:47 ` [PATCH 0/3] iio: adc: " Andy Shevchenko
2026-07-08 8:01 ` Joshua Crofts [this message]
2026-07-08 10:54 ` Andy Shevchenko
2026-07-08 10:55 ` Andy Shevchenko
2026-07-10 0:04 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708100150.00002436@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=fr0st61te@gmail.com \
--cc=jic23@kernel.org \
--cc=jstephan@baylibre.com \
--cc=kimseer.paller@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=marilene.agarcia@gmail.com \
--cc=nuno.sa@analog.com \
--cc=stable@vger.kernel.org \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox