From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF17936C592 for ; Wed, 8 Jul 2026 12:50:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783515042; cv=none; b=YFTMlegjgqWYNH4nS6TVjS58DS6DSl78dnIL65lNB8HuKimul9CaBB/g7kQGNPRXYZqFMZSPJoF6in7h95O+3qAVev8dDcrevsSp6yupW8nGISM2/AgzX31vTW+EmsobbOzD/estpSTrwr9hVUFFMpTkpKMTnpSdfOib2viiCOw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783515042; c=relaxed/simple; bh=MN7hjUlOeJc0FO8mu3UrzRrAKjy8hB3fiHLBiWptOh4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s7BIW5BVSbRrIocWwluIHYQCCFibghSSoQl6hbZdPoVHtyym7StfoueDvXL4HoeKIAGILVxz/jfhmIwcj+fbky4zLj9kZk91o7gF0RAY9lLOZdnF0I0r23wA9Ah6hWOxeRYw7rso19i3AhLQwaOPbT7yjmLBZ7m2JvGeXtJNsYc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hK+prp6g; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hK+prp6g" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-36b9d265355so638371a91.2 for ; Wed, 08 Jul 2026 05:50:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783515039; x=1784119839; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=//ABcZnuHlA1g5iBkAP8i3Vry09H6XD9kKuii/9o6as=; b=hK+prp6gwgk8a08HrJ1QLBh90CpOnMpbBSFobfuW3f3xUFk0hOjeSIH4khfwRt7yKI ENESeQbZHCr6gA5wdz+ZqqAcXXdDikAM01PjYdbkmjJaPQ5PxHQqpM1J70C45boLhPI7 wXGYkunBZAMZERcUpVhOJgMHwN5QTIZgFiPAtps5gnhwFMYOzK1A0af7+nsghTe2XZa5 QCMFINNnURovI1w4FNovDOB9KEPzlZMcFzSeRoZxxZVwqoEbhTcSqR8iYxsjSuSYWGw5 IRtRf4Zqv86fpM1DKy2Y+B0soI4LEx9K/+wsPmdcNmCwotKM0vJuqPIDH91lG0HjHFCT +7OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783515039; x=1784119839; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=//ABcZnuHlA1g5iBkAP8i3Vry09H6XD9kKuii/9o6as=; b=PNd4LkZTXJH/xZPFJoPB0MMTKGnvqbtytPLZeTo4vufPg2FXJPNqPPtIvclU0Ho/+6 JyaeBqK8MDsxRrM7uUKHvl31zOvRVbX9r1jcIBaosY4yMKigZ0M0qY6nIYMOgJ3WXWT4 jeemuTaadr0gDqhKaavS4tzvDAo2KaXuz2+lD5UQfCa4qlfw4TuvCVIwhj8wH2oiP6Sc 7LcF+FwUaSuoq1bCSeLhItfwWsljHRKGoZxUaAAL7v/E/k66XDTd/LWVakXz4M7Dsb+5 LOT8DwXEe/tkRSQWuum3mRoJH3kn9MsS2z7XGskpR6iZMKa7jledLIdIuVW4VKaMoJr1 M+Og== X-Forwarded-Encrypted: i=1; AHgh+RoRglX6geSAsYry5jNB0GULsgMTN+On5fg4DHu9D+HYWK0VMa1SwfZm4hmgvGrpQ0CEu11I3tfPDDQ3crc=@vger.kernel.org X-Gm-Message-State: AOJu0YzPFs1DY7YIyzOLZeCkQ/OIhRyK9HbfbU2pcLNSdjyhfmGWSJkL +QmzNRHJTeRw2a4bWgtKrak5hj14dbZyr0JQb5W2O4r2Tibz3pYV6P5U X-Gm-Gg: AfdE7cmH3o+h7G6UN/NWtYpamy+ikd5vvoIOD8juFWSkU2rOHCmYier3d/MPb8rnzf1 y/1dCeV3gcS1DRK9dQA4dBx/QqZG2ccANOpa8Wpn+e31AR5E4SFt9yfq2/bM8/P6FkD5jxczj7H 1yZEY82HSzkmhYvj25F24vpsp1+8r2qrMbge0/nF0TRwXbrlz1zUkDe1dcbMZb0jd7jFO1E/ZoA yDm/ZTu/pxlkfy+wgAC/pF1ln9E2yOnp7SD0v78IrIhzoWw1gLhgPLFpL3yFls/YptRLdJGwQJQ X0SV3z9Ve0RFz21NFZn2nZbT1uuMXgz6EvKMb0FvsxSk0CB7Zcwzqd+g2/v2ttSWrCsb7AoiMDP i8soLE/IHBKfsXR/lXaJqnnIpHKu6ojvXW/iUR3raGdWQXsO8JYLKAj/C8f9Fpt4cBOCLHwzwc8 cBbkqm2Erax8FiguuDSJRvxKNSVX2V3WyZYTKR1eZHIpqkJ0s= X-Received: by 2002:a17:90b:562d:b0:37d:7bb4:bffb with SMTP id 98e67ed59e1d1-3893fb6ffbbmr2457209a91.2.1783515039213; Wed, 08 Jul 2026 05:50:39 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-387d20a2f2fsm2784349a91.13.2026.07.08.05.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 05:50:38 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Takashi Iwai , Tzung-Bi Shih , David Rhodes , Charles Keepax Cc: Liam Girdwood , Jaroslav Kysela , Cheng-Yi Chiang , Guenter Roeck , Benson Leung , Richard Fitzgerald , povik+lin@cutebit.org, u.kleine-koenig@baylibre.com, kuninori.morimoto.gx@renesas.com, christian.ehrhardt@codasip.com, Linus Walleij , Arnd Bergmann , Sakari Ailus , Thorsten Blum , Chris Morgan , Dan Carpenter , Marco Crivellari , Rosen Penev , Weidong Wang , Teguh Sobirin , Val Packett , Luca Weiss , wangdicheng , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, chrome-platform@lists.linux.dev, asahi@lists.linux.dev, Cezary Rojewski , bui duc phuc Subject: [PATCH v4 01/24] ASoC: codecs: ab8500: Use guard() for mutex locks Date: Wed, 8 Jul 2026 19:49:38 +0700 Message-ID: <20260708125002.202515-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260708125002.202515-1-phucduc.bui@gmail.com> References: <20260708125002.202515-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Clean up the code using guard() for mutex locks. Merely code refactoring, and no behavior change. Reviewed-by: Cezary Rojewski Signed-off-by: bui duc phuc --- sound/soc/codecs/ab8500-codec.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c index 6e8ef9cd1b31..2cf96cbdd294 100644 --- a/sound/soc/codecs/ab8500-codec.c +++ b/sound/soc/codecs/ab8500-codec.c @@ -14,6 +14,7 @@ * for ST-Ericsson. */ +#include #include #include #include @@ -989,9 +990,8 @@ static int sid_status_control_get(struct snd_kcontrol *kcontrol, struct snd_soc_component *component = snd_kcontrol_chip(kcontrol); struct ab8500_codec_drvdata *drvdata = dev_get_drvdata(component->dev); - mutex_lock(&drvdata->ctrl_lock); + guard(mutex)(&drvdata->ctrl_lock); ucontrol->value.enumerated.item[0] = drvdata->sid_status; - mutex_unlock(&drvdata->ctrl_lock); return 0; } @@ -1014,7 +1014,7 @@ static int sid_status_control_put(struct snd_kcontrol *kcontrol, return -EIO; } - mutex_lock(&drvdata->ctrl_lock); + guard(mutex)(&drvdata->ctrl_lock); sidconf = snd_soc_component_read(component, AB8500_SIDFIRCONF); if (((sidconf & BIT(AB8500_SIDFIRCONF_FIRSIDBUSY)) != 0)) { @@ -1025,7 +1025,8 @@ static int sid_status_control_put(struct snd_kcontrol *kcontrol, } else { status = -EBUSY; } - goto out; + dev_dbg(component->dev, "%s: Exit\n", __func__); + return status; } snd_soc_component_write(component, AB8500_SIDFIRADR, 0); @@ -1043,9 +1044,6 @@ static int sid_status_control_put(struct snd_kcontrol *kcontrol, drvdata->sid_status = SID_FIR_CONFIGURED; -out: - mutex_unlock(&drvdata->ctrl_lock); - dev_dbg(component->dev, "%s: Exit\n", __func__); return status; -- 2.43.0