From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65735349CFC for ; Wed, 8 Jul 2026 15:21:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783524073; cv=none; b=uLtWUqR+BR6Uct/51uPl3EgRW1/Y6fcLa89vfT4e6JCNha6vobe4EylDASKZATkKzszbgGGYG1bciNYNTojdaBxVjmf5837x/G3chQgEn0Br0fg9YZ8DFpdKlnKqWm8YILEICoXTWsrH0ErQGQulAzhQSKaOj1kD8dLJtZXbpyc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783524073; c=relaxed/simple; bh=WKBcHTgaZtpNkKKi2sgsqXtCohviIlzQuMwKPXfIX68=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ITUdVb+O21bwS/Cjd5YI5sTU1dWv76PxUCvevU5Viw/hPS3fOAIay60wV+44e1cQGQU9OMDGAGtHl6N/sblJuaYGedMPE7DN8u3cDnONjHPG4WkkBHtJYkiPx3qq2qfw8/2xnPuHzSXyRt59Fa+HJJEeqzFSa/HABP+PMIMuZm4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Rs6Jod4N; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rs6Jod4N" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c9d1fc053e0so592905a12.1 for ; Wed, 08 Jul 2026 08:21:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783524072; x=1784128872; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=o36UxtuiqCAJdwEuwaBvvEJ+v2c/EEKhjYP437s9xVk=; b=Rs6Jod4Nzyh0EzlLOlKQs5kTJRy8RbX1dbYtradlIQFb3sOtyCSyjN2sFkn1IHY/Ao s3QnJLd/AaZHCL5tP+hVTpANuirRM+/lUl7BEkHr8POFqPL9EZqFcascOmcSmmC+Ozs5 CAU7dNym0BIwFO/JvQ9F1m+sOOq+uvY9/GiJWHfVANxxKy0Cjj3I9JL35Ps/eh8dV+dl ffW3ySGLUW9RYgcqy/WmJzPcqe8CCNF5g+LwwU72CNhwBZTaHnGAp2StfzcZZ7D+LSJi ub2N89lRrz0hMfEVyHVjDrC9et8pzjrPhnSDdZIZNjuMnFXM/CaUyhal/osJjMCQ89os 3ZnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783524072; x=1784128872; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=o36UxtuiqCAJdwEuwaBvvEJ+v2c/EEKhjYP437s9xVk=; b=d+I1hb3CSiX/5Hs8lotTirNpATIcqP0IwQNWft8qXQ3DFZGath2An86YLcn+uGTWia 9JdEkQIQIdtoBx8bCmQDjGw3gIwcI2YLenuJ12QDQXefDRKY0jlytXVJIcHonnAWqqFR F1Y/gs5APNzMzAfEeKaxYI7+jYneOMKdEVCAyGLDzTrabsXxkNqNTjM47mzsZqNHIO0O wnWJBpwTJiu1TmljyYDgWprpzk6X9DHprYKP8T/qBOwe4Qn7dElRKdGpIRMe9nAsV1ub iSldKJ4dsqxQIeuo2AnFgRIEiEN2KbFfSTuRrV7Kzc3T9YxB3uvFVhoyFE+leREPJJun FVwA== X-Forwarded-Encrypted: i=1; AHgh+Rr0XHHUllZKO8m/yDJACkJ+FYSwh3hNn22lP38EFjgp40PClQ7y43NerzbkUHlZ+tq6M1SPiK7v6Gpg+1o=@vger.kernel.org X-Gm-Message-State: AOJu0YzZB+QP/b7crVWbNv7y9nwMoFWOYcKMMVxmqEdvQCKDS4MiSND7 9DsjfUhGItDngU10BH3alECC7IkN1aFzJhr8msJTPzFI5jqu24WN/BRA X-Gm-Gg: AfdE7ckTxzjvtkX3YDbBRMZ+2PlLfO23trW0/B9fA03P+G7Svpjhrcax3ra6Fbo8wlO mPlxcdx7XttiGKX6Ve7MyRwYeQVFeALH89diwy/m/pvITcbdH48GZjHJL5vmBgwvmnjHfgopHDa 7V8UU4dWXQ34xGMlUIGtrIoLk7JXNP6FoqkphozvdD8FTIne59Nd2qRV6fs71259gAp4Tyo8Edr hZCREWWktGj04ijnedT8xfY0ezmMX/5r4an0NTGVVCmIqQ6bvQ65hxZJkCVAlekhTzSTzFOi0aG XqQQs6mDTCM1k5aMXmEbmvJyIc+AsP3PQ6MSvwxOf+yJXjOcmcT1Ljg7eo2n1TqlY8nBnnxJCHG V8cDPsZ94hbdbg0w0okdg1i/Ds2mj/j2x9745z+zYPKN24mrHy2+gn4D1rp1/M/OY3aZB81HMje 0qie994qJpnH2U886KLLpWWbiIKxIQU4Vtg2nzVcdnNQA= X-Received: by 2002:a05:6a21:62c6:b0:3bf:6237:b1b3 with SMTP id adf61e73a8af0-3c0bd1a827fmr3540218637.42.1783524071668; Wed, 08 Jul 2026 08:21:11 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b6596681fsm24544817c88.8.2026.07.08.08.21.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 08 Jul 2026 08:21:10 -0700 (PDT) From: Biren Pandya To: sakari.ailus@linux.intel.com, mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Biren Pandya , stable@vger.kernel.org Subject: [PATCH] media: v4l2-core: Fix memory leak in v4l2_fwnode_parse_link Date: Wed, 8 Jul 2026 20:50:54 +0530 Message-ID: <20260708152103.49371-2-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In v4l2_fwnode_parse_link(), the remote endpoint fwnode reference is acquired using fwnode_graph_get_remote_endpoint(). This reference is properly released in the error paths, but it is leaked on the success path. Add the missing fwnode_handle_put() before returning 0 to prevent the reference leak. Fixes: ca50c197bd96 ("[media] v4l: fwnode: Support generic fwnode for parsing standardised properties") Cc: stable@vger.kernel.org Signed-off-by: Biren Pandya --- drivers/media/v4l2-core/v4l2-fwnode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c index 77f3298821b5c..93ef83c591ef2 100644 --- a/drivers/media/v4l2-core/v4l2-fwnode.c +++ b/drivers/media/v4l2-core/v4l2-fwnode.c @@ -633,6 +633,7 @@ int v4l2_fwnode_parse_link(struct fwnode_handle *fwnode, if (!link->remote_node) goto err_put_remote_endpoint; + fwnode_handle_put(fwnode); return 0; err_put_remote_endpoint: -- 2.50.1 (Apple Git-155)