From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F7FF282F29 for ; Wed, 8 Jul 2026 17:09:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783530550; cv=none; b=edyHtGAlgB1pubPGC7vFX1sNXg4QJb1c4paoc0y/O7AVESKnRBgfYTba7G5SM0gqU0ZbXo3/85k4jrMyFpaoND6u2CFREVQbwH1u8zrmY/So6xt/oWCnvBx5yW+WXIUPlYeUk9vmO7IXGZeQtEaActms9GdQK5HfvmFFNYs25pk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783530550; c=relaxed/simple; bh=XvaR4zQkJbPVsPM6S3CFh1bYu/lHd9yVEwd/EDiiGlw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a3ztrwjvb1uNX/y1dzNe4uX+jXakufDrudw9C5+mbgXLjxgVZ1CsSD78QDBf1JqkXEz3XdErKsxfW6JZgu2lJZr8QED/YuLpYP9yf9Jy91Z/NE2aGDmFR9f+RcwDVgv5WWmDv+SMDKKNy3/LG4ZjuBKJOksucs71b5B5YzSgWlg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C+yVW0+r; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C+yVW0+r" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c9e30214d8fso685843a12.3 for ; Wed, 08 Jul 2026 10:09:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783530546; x=1784135346; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MvsR049SJ/U5yXRq6BtVkf3/azE0HgRjOrdKEiw2JL4=; b=C+yVW0+rEIyUW4VtKRCplFI2W8SoIRwnp187OEuh/sCtUZEvxaq2kcYTvDpMSyp4q/ 5KUHgen5OLiCg8/JrTMJTbijUTVVU9Fr9Wu4/85zoOx0KpFzFt5uvMmWevlzhH7aKX6L 8FPdhxXo8/zj8NjD3C7bCUqc1C9ZrexBaq49GfuughFsB5QKU4+G3SKhe1T6M8tCJ1Vx 1FaSjeM0yIiiAxgJBEuU/trhl+jCFFN8O/mAbEpqRNW4T5/Csj+h4KdtFdj87lt8JGRI P8I9KEnxyhNAyLShqJvpBNHEPzYh2OuZI/o4PBvymuYSpxbnA8/SQOXuh9hs/oPgZS22 bgPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783530546; x=1784135346; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=MvsR049SJ/U5yXRq6BtVkf3/azE0HgRjOrdKEiw2JL4=; b=mfnIfk+/6/kxpEkURP15njXW9EU9l3Q6ACoxPHZHaXPTlHxEYy2DW62p2fT1vRpS4p SDx5iJictZTcjkK+96S/F6INUZ7NBf2DItKwG6wetjSaKc/pcGheWl7H60kg/dPkXqjO o0ShOhdB/PD9y/b15lLpPaFPdy+9qcE5Iq00PGrSesf/i/bAA5BtfnuTo3ghReA2a7ah J292CAdxo5wwo7qSoV/x4929+mCuZXr5dhhnlx0TpZM2ZvSD55V/SVv9RKdvbaFMJfE7 2O/NsvAJdhib3YtBwOKgu23/AeNOUwIOoB6qUH6jMfKrLiuQDj/falqzT5NErV4lLkCP yLwg== X-Forwarded-Encrypted: i=1; AHgh+Ro4orOtbb4J5k2RsVY/xF31herS1+K4oiMAncFDCxNcHLnVTnTBmpdyNqQ5zQQZ9c/hhyMi4yFrj0mEE+w=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4dHh0mJW2RJNTpi+zPl5/0FwOrjsJk+MqNgUNH5KXI1cu1mWs aCJ7g+vCifhulnYf+a0M/D0351pv4fPakcK0JIi3ez6xciIXZ5eZlHGo X-Gm-Gg: AfdE7clNkwMJpc1G2qxztQEGIk7mIfhDezPHm8URAaYnRTsYIrZ50PsxmfwKKoEn6hj fcoka/DNwPQ5nuvJDlpMs+VI3hd4Kn+EcIOE4pdRXdo2n3GH99HjCarQIZtxmKoWYNz0vakcdD8 wZqTO68VB1CoWRMjV70pG85XfHUC50YlTJ8b+UMEHHSpuIbG5rBxsS2ufEnGO1cpT4E2QRcb/t0 nApq0/7cZ8Bjdixj53wJC7tTIORCwA88/m24MZwqpbyVAQrWuKVRkP/Ag/Sk1KTqgBM4+pDRbtQ l4RRZyHD5gtjZ5BRNtauTMgwlFaGSeLZIs7fMzaxg/1JzChwnq3OUMX897cbEFlcuVvAti0oDVx ZoHnkhm12R5yVFvTTWh8b1MlGoRLGsZJ0jHgiUvq/I7AnNzI4OI5YihXCVHO21y9x3P152sGW5C 6eGkm7p0tI4dZ0l1PbP3L90ZGG7QIz+9kDgwCkEJ1nQQadxCm7SGiugw== X-Received: by 2002:a05:6a20:7490:b0:3a0:b781:4c78 with SMTP id adf61e73a8af0-3c0bc903417mr3943651637.15.1783530546451; Wed, 08 Jul 2026 10:09:06 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b659666e7sm26602154c88.7.2026.07.08.10.09.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 08 Jul 2026 10:09:06 -0700 (PDT) From: Biren Pandya To: niklas.soderlund@ragnatech.se, mchehab@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, Laurent Pinchart , Jacopo Mondi , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Biren Pandya Subject: [PATCH v5 3/4] media: renesas: rcar-core: Add missing media_entity_cleanup() Date: Wed, 8 Jul 2026 22:38:47 +0530 Message-ID: <20260708170843.55076-9-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260708170843.55076-6-birenpandya@gmail.com> References: <20260708170843.55076-6-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The probe error path and remove function fail to call media_entity_cleanup() upon teardown. While currently a no-op, calling media_entity_cleanup() is an API requirement for entities initialized with media_entity_pads_init() to prevent memory leaks. Add a dedicated error_entity label so the cleanup is only invoked when media_entity_pads_init() has actually succeeded. This ensures that the teardown logic properly mirrors initialization. Signed-off-by: Biren Pandya Reviewed-by: Jacopo Mondi --- drivers/media/platform/renesas/rcar-vin/rcar-core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-core.c b/drivers/media/platform/renesas/rcar-vin/rcar-core.c index c8d564aa1eba8..5bae8eb0ee19b 100644 --- a/drivers/media/platform/renesas/rcar-vin/rcar-core.c +++ b/drivers/media/platform/renesas/rcar-vin/rcar-core.c @@ -1211,7 +1211,7 @@ static int rcar_vin_probe(struct platform_device *pdev) ret = rvin_create_controls(vin); if (ret < 0) - goto err_id; + goto err_entity; switch (vin->info->model) { case RCAR_GEN3: @@ -1246,6 +1246,8 @@ static int rcar_vin_probe(struct platform_device *pdev) err_ctrl: rvin_free_controls(vin); +err_entity: + media_entity_cleanup(&vin->vdev.entity); err_id: rvin_id_put(vin); err_dma: @@ -1270,6 +1272,7 @@ static void rcar_vin_remove(struct platform_device *pdev) rvin_group_put(vin); rvin_free_controls(vin); + media_entity_cleanup(&vin->vdev.entity); rvin_id_put(vin); -- 2.50.1 (Apple Git-155)