From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B5CC43935B; Wed, 8 Jul 2026 18:32:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783535578; cv=none; b=uuSflDUce8eiT1mabmuXl/tdofxNF0R+UVyYiSwyc7nZR2dZPIUiIVYyd0r7s7Uq4lifFdUm8DyxMGmBxZBOJ+qT47OOzTVukRFVwFJkd+Q6bfXlk4mXQsl1cxlsnzCR3jFWnd3ByyzhtOzPQeJm9tRS8o3St53NDvi4JmF2iHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783535578; c=relaxed/simple; bh=LmnkgN0Dr7SXL7hPbnCRKllB6yQthnuSgaAb5F5+Yy0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TQqN2jwstm5NzGZwT5U6dSgXDPeqOgdUSxPz081c2iCbi4DFAtvvU1RRUR29nzKimm7xR1CtEJTniKTzCLLMaX9a/iMJ9tx3i5EIqQ8qlSKs5YWBZHpU/TGXNKvPkvM4c4aCadAWZjASPOoywZ/qMAK3R8oEexSXyhI1fsxdaD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Zn5xtzr9; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Zn5xtzr9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95E081F000E9; Wed, 8 Jul 2026 18:32:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783535576; bh=BnKkkX5i65uC9TQ2lLiE6T23RDtoLgQdsb5OvNEJ8AM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Zn5xtzr9xdqPsF1Vc8U2Mx/xPcS3d9tZ6nV3gT89/IHRhn3g7L0Sn2Ht1v5a1/pv1 V8TqphOb8/IDVY+GUpORUz+1Iuw4AcizcKNuCr22K3+Ot9uioHMnFo7xQUPk0wInDd 5aWJW3FdMtn97fDi5cTFNdf33Ql6DQn4iLZx2Ggoi4NgapGikHjx8VqMhaXNmGgDOS j/nVBwhc13EmslZKB4Kox8/wor0eZPt27JJ4LjURQlXT+g28AziRZastJHxDd9BLNv +D30mcvOpKYu2py49XzAoWMVnr+8l/aeLZspy6lJ9XphT/E4cas7wYnKjpsoKqzOqK hDY62S5WIFYsw== Date: Wed, 8 Jul 2026 19:32:52 +0100 From: Simon Horman To: Paolo Abeni Cc: Pablo Neira Ayuso , Runyu Xiao , laforge@gnumonks.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, osmocom-net-gprs@lists.osmocom.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jianhao.xu@seu.edu.cn Subject: Re: [PATCH net-next] gtp: annotate PDP lookups under RTNL Message-ID: <20260708183252.GL1364329@horms.kernel.org> References: <20260701123925.3193089-1-runyu.xiao@seu.edu.cn> <20260707142820.GG1364329@horms.kernel.org> <20260708103525.GJ1364329@horms.kernel.org> <8d5fe948-6979-46be-866a-69a98ee391d8@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8d5fe948-6979-46be-866a-69a98ee391d8@redhat.com> On Wed, Jul 08, 2026 at 01:10:58PM +0200, Paolo Abeni wrote: > On 7/8/26 12:35 PM, Simon Horman wrote: > > On Tue, Jul 07, 2026 at 04:51:12PM +0200, Pablo Neira Ayuso wrote: > >> On Tue, Jul 07, 2026 at 03:28:20PM +0100, Simon Horman wrote: > >>> On Wed, Jul 01, 2026 at 08:39:25PM +0800, Runyu Xiao wrote: > >>>> The GTP PDP lookup helpers are shared by RCU-protected data and report > >>>> paths and RTNL-protected control paths such as gtp_genl_new_pdp(). The > >>>> helpers walk RCU hlists, but they do not currently pass the RTNL > >>>> condition for the control-path lookups. > >>>> > >>>> Pass lockdep_rtnl_is_held() to the PDP hlist iterators. Existing > >>>> RCU-reader callers remain valid because the RCU-list macros also accept > >>>> an active RCU read-side section; the added condition only documents the > >>>> non-RCU protection already used by RTNL control paths. > >>>> > >>>> This was found by our static analysis tool and then manually reviewed > >>>> against the current tree. The dynamic triage evidence is a > >>>> target-matched CONFIG_PROVE_RCU_LIST warning; the change is limited > >>>> to documenting the existing protection contract. > >>>> > >>>> This is a lockdep annotation cleanup. It does not change PDP lifetime or > >>>> hash updates. > >>>> > >>>> Signed-off-by: Runyu Xiao > >>> > >>> Reviewed-by: Simon Horman > >>> > >>> There is an AI-generated review of this patch available on sashko.dev. > >>> While I don't believe that the issues raised there should impede progress > >>> of this patch you may want to look into them as possible follow-up. > >> > >> This patch refers to the rtnl_lock, but it is the genetlink mutex that > >> protects updates on the PDP context list. > >> > >> Then, from packet path, rcu lookups are performed. > >> > >> I think this patch is not correct. > > > > Hi Pablo, > > > > Of course you are correct. > > Sorry for not realising this earlier. > > Human slop here made me wrongly apply this patch. Could either of you > please share a formal revert? Sure, will do.