From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7882935A395 for ; Wed, 8 Jul 2026 22:49:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783550957; cv=none; b=mK7DpSeTg++zacOFpGeXZAcKvJ+qGBiemW48WyU22NqQVnbXp3PFaGP54z6wZT4xpzxyoO8Fzg3E+A+vBa2JBxiB2Wd67nf+k0r5F+dlLJ9Cu9mFBQL/grt20bY1MslSPYS0GrviNpNDdvCvPMJp2FiIYvvBxQGzflcpQOut4kc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783550957; c=relaxed/simple; bh=X1NUVpDQ8vl/uisADeeaUpoml5NJsI2D9HCalPdWhdo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=P4W25pi4gBCkCHg5CXi3zRRjIMHZB5FV5gq5SAhYKxexnMzmTqOGvbXakC87BQFOEvD9BEOTvqiTpMhZQTLGUOSKqCjQfU3hD7Bg/av+AiO+gJi6eXRrXR+dZVaErQCKsVEeGPxdn7WZoXb2wsqERmO1bLQZDq08pmilvwtzSTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qF3CfsF0; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qF3CfsF0" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-517dc520840so8074581cf.3 for ; Wed, 08 Jul 2026 15:49:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783550955; x=1784155755; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=A7N7lDaO72foXY0RGgwf1zTvt3mB3Hr39FiuOGnXHck=; b=qF3CfsF0PIq4DRU+O/4F3zmTUtNlomgj2PmyzUY2HXzVNb98sFcsbOmJeQJ2boz6hx igbvxdnftzXjzDii+InvpckZo216g4jB0Yhp+s5HZbWBicFOykoY1Nl3OmVhdMNrL790 3Yr/Q4qFb/60EWBjp9tQ4vXw+mq9CnNbSUIO3hRkLTWkQrThEINw2w7gIXs1348OXdrW U5z75JS+K3z8Pnq0ichPOKY8KuB7IRIJ272DEIl7mRtFpbYBWW2K4PfChXnbA3FfzakR tBidiegedSsmRF2wvuzqftGgKfUveeaZ9gbHvJTHFxDUrafc0ARHKjAcCdeUyz2GaNWN 8+ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783550955; x=1784155755; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=A7N7lDaO72foXY0RGgwf1zTvt3mB3Hr39FiuOGnXHck=; b=WrLcY5oB0ovj6wSK++EdfhGcfMwS+2c3SRaMtQmppuO878bpnyTS9wuApjIYTGJ6St 1ZCxTQwqUSkimg3MIsJV10rsHT3ng4VIolBfZw1aCCH6GySG6c7Lqx9sfM11gQBW6EJs Do9C19vJfNsUGnAliMp8Oewt55HGjmjBhItZLKXm30u7c7MGXXST4ZC1tRbhpuZGFkmj X0nqaXN1VFIRI+Km/v07L0QjvU/OFYQjvWOCLnX1EG6ui58CEntavVkqdQvXjDFGAMOU ee5j2dYrgROJLHvxBFgLPji6aZKYnpNWAfpXx2ru7lMCMMtAKH+LCZjhEuNpnJJwQccV hyfg== X-Forwarded-Encrypted: i=1; AHgh+Rpyqmdj6Bpl5Jw/AYmZhxBw3VTqLg0MjfNCcgzzbAd7Dr9wvn019VZOCxk0hMiFDsiq5IIy4nQTlGvChwM=@vger.kernel.org X-Gm-Message-State: AOJu0YzkJ8reL6ex5rWlIytr8vyHTBFHFQd/nUGKM2rjLS+Zt5ISoCax pu6H+VvixuD+Z1Jbh1bfTxEs8/TqR3zOPGCy7nZWLdpAHt1ChvYyASbtBXbQqQ== X-Gm-Gg: AfdE7clfKdXm1DCUU4y0EZagUkzs/0UUF/Qa+Bh+XT2t++7KxTBTkDxs6e5Z8Bt9702 FvyBZQ1NL5zx6vl7ebWtKnLIGWYuXw1oSoVyGQhj1pzbp9h9Yyj2S+4gs+CeTcHU4XzGJGz6qbp cyKOEq9iKPc4CEMqDNsfhvNDbR8Bv/VsKtSNDUfB8GhZ8ELftjylnUfBLAjIOsvJ4DEuETE0gvf MXEx8YWdtcUdJ7+210ud1PKj+9p7BccUs+gsa2UhFBwaJ41PhZ0Jd/10Z0/UCYirFiq8Q4beJ8U NfRJS8YfGUjwZiS3MYUGaUWnIFSuxAQ8kKlpUzVhG7BFj1coew0fhnr6yxesKa1e/TnnGvQtqEL C0KGtwtC7WoXYLSvk9+KlQJJqa82q2VspEnTi8wXNt0z53qvKTJKJdRxjRl04G7Phjg00t4v7O4 vGo1gAi/jLaJcxYErRUjnu4d1E2wyqo+8HxoeIMVcREIydBJGZdrBCJtIIIWA2CkaYXD96YST7U XZXroGtwvKKrzc7UGBgbXMBv+DCSXVZAqPLgZM+duIusWdB+BXG9LpXmiLLmBVB2Q== X-Received: by 2002:a05:622a:2c5:b0:51b:fa52:807b with SMTP id d75a77b69052e-51c8b49bff7mr50185091cf.47.1783550955465; Wed, 08 Jul 2026 15:49:15 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51c41e084e8sm143000721cf.28.2026.07.08.15.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 15:49:13 -0700 (PDT) From: Rosen Penev To: linux-gpio@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski , Jason Cooper , Arnd Bergmann , Thomas Petazzoni , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2] gpio: mvebu: validate ngpios before use Date: Wed, 8 Jul 2026 15:49:11 -0700 Message-ID: <20260708224911.964245-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If ngpios is read as 0 from device tree, it is passed via irq_alloc_domain_generic_chips() as irqs_per_chip, which leads to a division by zero in DIV_ROUND_UP(d->revmap_size, irqs_per_chip). Reject ngpios == 0 early. Also reject higher than 32, which is the limit. Fixes: fefe7b0923459 ("gpio: introduce gpio-mvebu driver for Marvell SoCs") Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- v2: reject higher than 32. drivers/gpio/gpio-mvebu.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c index a863b0bf46ff..73f4bbd2a0cd 100644 --- a/drivers/gpio/gpio-mvebu.c +++ b/drivers/gpio/gpio-mvebu.c @@ -1176,6 +1176,11 @@ static int mvebu_gpio_probe(struct platform_device *pdev) return -ENODEV; } + if (ngpios == 0 || ngpios > MVEBU_MAX_GPIO_PER_BANK) { + dev_err(&pdev->dev, "ngpios must be between 1 and 32\n"); + return -EINVAL; + } + id = of_alias_get_id(pdev->dev.of_node, "gpio"); if (id < 0) { dev_err(&pdev->dev, "Couldn't get OF id\n"); -- 2.55.0