From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 682AF274FDC for ; Wed, 8 Jul 2026 23:47:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783554424; cv=none; b=Z/6IhDqwPG5ztn0IzW4NbmYmDbALKQZ3cGbfEwOePZPnSxILtPmkyTDOfdv3Y3ztjvVsZE82zrPV8y1Vu5T7xSzSo/rLstcVnoC1AfqPoxLx7sEuse0TG2eCRx64Y5K3aNtzmOTMaPhBzfsQaKAgsxBA7tKmYW0S3zqkthe8OR0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783554424; c=relaxed/simple; bh=zqhII9pIIg1up9u2s0T3nyYMp8Nuwcx+oic1cmCY3Og=; h=Date:Mime-Version:Message-ID:Subject:From:To:Content-Type; b=kk3uXnQBvCuRWb/FyYe7Dt7cbD4EvP/80r8bBm+zGUxKBDGZ9YYGDDAXCgrVXSd+V8N5G5D2lodwYSyDClYtzsUWRnGSksPThlZtvBznTvmP7CaF7N72uSafZDZSfrB5ZFFVaeNifGy7SoAwk6r9s5mbEWnrPG44d1lBRsuLDhg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XJC4PWgC; arc=none smtp.client-ip=209.85.215.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XJC4PWgC" Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-c88ad1558f4so656591a12.2 for ; Wed, 08 Jul 2026 16:47:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783554423; x=1784159223; darn=vger.kernel.org; h=content-type:to:from:subject:message-id:mime-version:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=IW2Krk1JBTo+ci2ZZx0kx/gVLoo7HWWPBLR16dqq0Y0=; b=XJC4PWgCQYnVVmzfHMb+XckrjiAA4SKs3bISP3GUi7nX8GHDVjTY+5bREbqJ1w9Aab WOsvhB6JfhnQum2RRU15h22sXabetAPEsAb8CJg49z7tSproRiz9PzcLp3ohEZ/L9DZS bszBNmfP8ULb6aFtBsGYFY6mHu/VppO8G1mAgAY3tCIxmBcgQ74xrG1QU8fA2KX8g8Am 9vP52Txur+ux4SEspOgshOnmZn6oOBrFWwbhOdBX9yDaZ58JX7QVy5ZtWr3YGWFloc06 +4B/kIf6qJsYnXzsTlIxD+Ufc9iw+Geyc/LA6XM8jgmwLq0pWGsXZZteOGoIZb2hOvVJ yCbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783554423; x=1784159223; h=content-type:to:from:subject:message-id:mime-version:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=IW2Krk1JBTo+ci2ZZx0kx/gVLoo7HWWPBLR16dqq0Y0=; b=ieK4kjM/Wb13qmQgP0mE9iMrBHAxv1k64rhegx0ITHJ7xCllbp1XUaZ+tiOAgobULf X38VVj3MmX3xDlaD9AXjlqBmXCuax9Wp2PeOG6EFqC5Si5IsSgbiVm4rpQMwZDxqREL6 I1WN6c/FR0igni95OEwIkIQamahvHQZy6bO3ajq1fEv35jQBJGu40dvLdqWvx0IJy5c1 vdIUMAscQUBVqNJq2kO09nRCuXN9+Oj4zmWkFWXFmQQTWRXYJwGFFuWEp30v/wVORZ1A iQOVN2Zme7cC/LU/MaJ1AOV9h2gI7tN+/T/X3pLsgXzCydNXoXzmtVWSgILY/Mpl6F7r Ouuw== X-Forwarded-Encrypted: i=1; AHgh+RoFdbI/S5BQEgJpedSPkZbDIlVCow+6+seWEilfwqe/Nnves4T0VP1v7ulY+rWPcW0pgkxUNWUEU5g/+P4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2n4+Jzg8Pe7Iilqu3jTy0nwN4elUf4CYszX+03EG4iCcStdfl Nr0ztBYReWKyxSgRJjIqsJuYytfOrFC4hOHdmYpcRI8alr5HMs51t3Iw/wtFCirNpQPifMD/aR0 mouCRD4aVEg== X-Received: from dybb17.prod.google.com ([2002:a05:693c:6091:b0:30c:1aab:2586]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:12cf:b0:3b4:b216:2b26 with SMTP id adf61e73a8af0-3c0bcbe7824mr5802033637.5.1783554422610; Wed, 08 Jul 2026 16:47:02 -0700 (PDT) Date: Wed, 8 Jul 2026 16:46:44 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.55.0.795.g602f6c329a-goog Message-ID: <20260708234646.1040003-1-irogers@google.com> Subject: [PATCH v1 1/3] perf ui hists: In report UI ensure thread is set From: Ian Rogers To: Josh Stone , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Tianyou Li , Dapeng Mi , Zecheng Li , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" A map_symbol contains a thread that provides access to the wider perf session. Recent changes used the thread to get the e_machine to better support cross-platform disassembly. Unfortunately the UI code wasn't populating the thread and so the e_machine lookup failed early breaking the 'a' for annotate TUI action. Populate the map_symbol thread to fix this. Reported-by: Josh Stone Fixes: 0e26ba5a8774 ("perf disasm: Refactor arch__find and initialization of arch structs") Signed-off-by: Ian Rogers --- tools/perf/ui/browsers/hists.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index da7cc195b9f4..f8ffd9b73582 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -3155,10 +3155,12 @@ static int evsel__hists_browse(struct evsel *evsel, int nr_events, const char *h continue; actions->ms.sym = symbol__new_unresolved(bi->to.al_addr, bi->to.ms.map); + actions->ms.thread = bi->to.ms.thread; actions->ms.map = bi->to.ms.map; } else { actions->ms.sym = symbol__new_unresolved(browser->he_selection->ip, browser->selection->map); + actions->ms.thread = browser->selection->thread; actions->ms.map = browser->selection->map; } @@ -3173,6 +3175,7 @@ static int evsel__hists_browse(struct evsel *evsel, int nr_events, const char *h continue; } + actions->ms.thread = browser->selection->thread; actions->ms.map = browser->selection->map; actions->ms.sym = browser->selection->sym; } -- 2.55.0.795.g602f6c329a-goog