From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2212336C59E for ; Thu, 9 Jul 2026 02:32:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783564330; cv=none; b=KaYctw7QtddxmkkexarMK2mAAu59Ll9EhYDHs45Oub5yWNyjoomKDBFkCqf2BDnO5wq4BFcIBTMDbDlo340yvfINy0TySeLg9TG7Hvt8fcnx7zxFZK0KoLWAZ1N75p4nmpfft2Bc34yEE5BERroWZ7mrahV/FuV3bw6GcA8W9LA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783564330; c=relaxed/simple; bh=9dYLJgGNu8I32f87if5Q5pK0a3jpWdv8Kp36e3F2ygI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JOzkuYJmCUhNtlJGF4ZAc651LNJUzy95bd7IYbv0N+fa1tffFZQCpBv+N4EgECLzf5eYGR+9UzhefKsLQeVtEbPhRalAsDdrGBE9zJCg/DltcWtz6xpaABveaY5/rxIPvG/3XU45i1P+u+X/ADI5y3aI7DOa/FcWA1niaJ/j9jQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NZ7IBiwF; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NZ7IBiwF" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-847a52edeb2so1193356b3a.0 for ; Wed, 08 Jul 2026 19:32:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783564327; x=1784169127; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9apZB0ggetfGgdc3bmsqNaTtxOfdIcGG//LQF2MtOco=; b=NZ7IBiwFBnqQKDXv+u1cV8E3CiaSeWei7qip4bWRQKEseGpJwTneJ6aeOUyJlcvBOn FoCzMtnrZE3nETm5mlwLdNmD+wcxIG7xfiOBSqKtT0HxnZcWrtSqlTEgshnGkWX421Go XPO0/086D2ZRa58YefZv/PxUyU2TyIKeF14oNC047JO7jy2LwDy+2M1agmX9Y3QBBoXg LyhO1PKiTncMMEb/5W5HPrbFv7OIVDKE+UDWdwLFEgrcuoLPS0uu2q7ikHRPgE5qHNCS JyKH6bT84x3SqmagPpCi6UDUB91A3bnSow8+50ckENhEhL0lpt5c7wB7rupr24aPEsfs RM2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783564327; x=1784169127; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=9apZB0ggetfGgdc3bmsqNaTtxOfdIcGG//LQF2MtOco=; b=NUdSqz02PShkqepyh1S9sSfDAiuKMSjRFyG3zarBwpPvNXMujkIJPvDz1BFAl9CIeG +nrjZsYRV9/e1DMDRFLpyDKURAyG/SZeiP0dOK3kvdcWV4I3QgV7vhb1fSApBpTckhP1 mZelMJk35HuZFGNhPJQfNcjHnC8EQov/sH7yU2A6cZH5Hvmgq9sNhXyQ9OU24xS0Y0py QlCUGytYxhMfnCy/J+RkJVGtd0+65FMZ0ZWF5Nh1EWgZ/KnDaMz4MIpzs4uRPTt7DC21 tdrW7QO2YL8CfFYt9z6h7AmrTcK3kBdhY1+2VAx2CnmgzGAHf2bXoZq1k3RtF4a2Ow8v QGNQ== X-Forwarded-Encrypted: i=1; AHgh+RqncAnXqdZGILlH4CiBPMVgn67k/lTl3tJyMmrTtOIejshH5V3SvdpZsgq/s0Nf/6/mC8GkKj/ty+PjDdU=@vger.kernel.org X-Gm-Message-State: AOJu0YxRFGt9Eg6iI0wVGYyKKQGHMtfyZodRMIqgHLiZ2k7wgac0Cl4s 1aA2lK5PhwBsQI1CoFljfmoLoWJqc7RyJdJH1EQFVt40D4+WGkYCyHUz X-Gm-Gg: AfdE7ck4AODaY1jVdJ8SWAyVxNc8+zOFFfoaOsq/AjY01ctjeH2u83rQk5LqEZVo0HI /Rfq5/JsYwgtFC222/3GOSZrvTJO9kmHIhmkvf9bpo7oKs3+4IFfbquSqXASXCXE69FSd1vNMqS 48YjCTJYK5C40Y/6uTIeg8aMptyGd7r/7zqkA9uXdg0+vsW81JYr063QERsqmD2YEPVDt0KROKG JVH7Ow914kDEsCA6ojSzbI8JMYlQRhFUR9nZfJoBS6JU9B4ajjFQbuxSAeChQY2OrvgSt1BDpcG kXuaTu6Y6YX8NDEdoyMdbCLay2TLPlocqYFQUGbeOQan1koaHNcDd7lz+qFAschrBiM0GrDI/jo lQqApDG3FF9ieUUPgDvw1+OtijVpJL6b4RPf/hlR6WWmqbAIykMS0kVLhWJU+m/ORlFklHN+CPG rDkJ1ImBiZQD6Ap1TEU37vodbmsSZFsx53oB0VFaPN8Ewjno0lPVIEFBYM2o1xTt5tIiMZBbPtT MVR3/1fV0ZDCmKuSqw2oxEE/NPTlFzVRsgDVICU+1GdRtwjGMB0anE7yAkw8JAKyg== X-Received: by 2002:a05:6a00:4091:b0:845:eb88:3d86 with SMTP id d2e1a72fcca58-84842f9fe12mr4778768b3a.48.1783564327517; Wed, 08 Jul 2026 19:32:07 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6b975a0sm7935954b3a.14.2026.07.08.19.32.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 19:32:07 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , Jeff Garzik , Prodyut Hazarika , Mark Miesfeld , Rupjyoti Sarmah , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv3 2/5] ata: sata_dwc_460ex: enable SATA interrupts only after IRQ handler is registered Date: Wed, 8 Jul 2026 19:31:59 -0700 Message-ID: <20260709023202.2132165-3-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260709023202.2132165-1-rosenp@gmail.com> References: <20260709023202.2132165-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit sata_dwc_enable_interrupts() is called before platform_get_irq() and ata_host_activate(), leaving the SATA controller's interrupt mask enabled without a registered handler. If a later step fails (irq request, phy init, etc.) or if the controller asserts an interrupt during probe, the irq line may fire with no handler, causing a spurious interrupt storm. Move sata_dwc_enable_interrupts() after ata_host_activate() so that interrupts are only unmasked once the handler is registered and the core is fully initialized. Fixes: 62936009f35a ("[libata] Add 460EX on-chip SATA driver, sata_dwc_460ex") Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/ata/sata_dwc_460ex.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c index 442c6e9d06e0..e206fbf6d2e9 100644 --- a/drivers/ata/sata_dwc_460ex.c +++ b/drivers/ata/sata_dwc_460ex.c @@ -1164,9 +1164,6 @@ static int sata_dwc_probe(struct platform_device *ofdev) /* Save dev for later use in dev_xxx() routines */ hsdev->dev = dev; - /* Enable SATA Interrupts */ - sata_dwc_enable_interrupts(hsdev); - /* Get SATA interrupt number */ irq = platform_get_irq(ofdev, 0); if (irq < 0) @@ -1197,6 +1194,8 @@ static int sata_dwc_probe(struct platform_device *ofdev) if (err) dev_err(dev, "failed to activate host"); + /* Enable SATA Interrupts */ + sata_dwc_enable_interrupts(hsdev); return 0; error_out: -- 2.55.0