From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6EED371CEE for ; Thu, 9 Jul 2026 02:32:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783564331; cv=none; b=Xj22C8F06vgMx621nyIVrszIdk4JCk55sgYoVb59+2Gelo69sBaInrq3xbOGJromHYaBYMQ3mdQ+0iB7gUBTc12SYIeCjgrjlm0/ldytI1wh2+dKS+PeZRi0sw10BHdFCwpD+RwqQnpZ54g5eZiDrZ+HkOCbYe164i1CZ2XkGP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783564331; c=relaxed/simple; bh=FFhvi3eKrkE4G789Snz08i/HdQMFrqRe72TBATuHHLs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qmklk6K4/kBPLXLGSF0tWrEVOOuNgtt9GuBIU4O3UN5cTEuiH9h6w2b+YcU5RHlCZ+tT8ycJByMC8m2Ev/YbtIGe+/Nxwk1J9LxxHZsWXxoUrg19+CQOt9R3+378wm8ZVqieEek6/iGptqc0BnziZL3m5OluZfQepQE9s7oerPE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cHAQ84vB; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cHAQ84vB" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-845c92bc464so924627b3a.2 for ; Wed, 08 Jul 2026 19:32:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783564329; x=1784169129; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZG0vOQBo+nL6M7xPLYpjT9WudAim/g/N78fOZlycf50=; b=cHAQ84vB7KJMZu0D24URt8kkZeymV6d7gsms35Aa+p+Bz9RyoRYHw+GwFpkaZLX8Kt 0ckr9QBP12/taLPNJGvxHRwONUVlpzcuEReHQPlmr+eV7SdhJSZSWX2p7Z7aQoxcoCoA i8eFaU7t4HZ8GvtsvSDHhuKlWXnhUJ7oT+RNUOWOWMdRBKNg8HekO+gGhs7LytcBgVdU /NBAXEPjlnDbp+Eg7fG6BJv0ywSqbSpJHjxZhnY2FoUyOyStrZmMDG8WLcC719ly2IE8 0XOf13oQvaH94c5oeOhFAnwCgTOyirO3IcYqwvmnqBsJdBx+SotXrHmNm0isGI37ETEj WiMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783564329; x=1784169129; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ZG0vOQBo+nL6M7xPLYpjT9WudAim/g/N78fOZlycf50=; b=DT73B7D3gsd23jSjBypBWVDxoKNB5QkuIfuvh8TbHflQ+LshyppjR4fTHG3ZtUv0j2 zdTfEuZJP5aePYGe5TeQWyfMWa84I+eaWj8r3aAozEQxWtq/7m5dd5bpyn9sJxUY7iZ0 vgafj1JeSbxXkx0ZyLmgfuff4Ad2nrinPHloXNj/tqWYag3ABK821hkKxEdaOldMs/0d +XQANgORkaZOMu6sRI3cQ1FBrwM4URjfKxhNePxJS5MzOyBJrNo/lAbruMKGMrnxA1tR Oa/P/hfEaKJ7UZ/7Ob2s7bodiXROdQM9pZxHcaxjrnq9ZUnXWNxE1mJC4YFg4jT70g7n dkSg== X-Forwarded-Encrypted: i=1; AHgh+RqnwjDnpiL2WSh5i/MI0nZ554kwu7eLYa+aVCng9ma7+RFiCxpA6zWswt7OEyS/Bq5qJdAc0KVxvEHBB1I=@vger.kernel.org X-Gm-Message-State: AOJu0YzWWBeRsowepUSPkBetuodYHhWECncLBYtXePKizJAFn0EYvN8R 8AKMnSO33/bjyyazEQ7UD/6gXBjS2BrtCR9nxeOBJGYC6gFJwWdxu+qZ X-Gm-Gg: AfdE7cmihjEvAF2KFH9aADFscC3zNpX2sDqf36og3yeJ0FMx6SdG7ox9SJE+pIKCLsD pWIUgX+yxxdVPEkmlk3Y6n+aIJNWotPH2mEXPhXNcTQxvchO0MJwT6x+IZSqK5CTF7khqrsfC64 XaeQw4jGt6ax4KQEkFKkYuvOZE9oE8OdqrmsFH/OBtWO9ujxKA45ziem09hgr+P4f36Z8q8MDPq 1CC2eGUZ4dCNnKGdwrVsxElJX/4XMuy084o6WohUNtoXYYhUbXNgkpSMW/vSqLi4tsBW5DJ2qJm rox5u2Gzc2ip0fToASkXO0qARhawZpuetprn7bynlCC2f8gsCBLjBivFyAP1JyAEfzXtjjFSDkL hR+/4THq+UT/prNd1TmxKAxiT73CtTpSPyBAXZ7tEYAtK2TRq9SxFORov/JfPYBqL1mYCqcugDo 96Spl4sRSADOKh7Mn18ukktvNP/WQS5FvdA+O29Zvvi2HrXm12J2wII8owJI3qfO9EtWD2QthCX CE5vjA00Z6ztT+zojbpVVxZXtf4ogF5OgJihzu/yOch4Y2fQXC9cSDTzLafJoH4GQ== X-Received: by 2002:a05:6a00:3996:b0:842:3aee:12c0 with SMTP id d2e1a72fcca58-8484302c747mr4865759b3a.23.1783564329021; Wed, 08 Jul 2026 19:32:09 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6b975a0sm7935954b3a.14.2026.07.08.19.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 19:32:08 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , Jeff Garzik , Prodyut Hazarika , Mark Miesfeld , Rupjyoti Sarmah , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv3 3/5] ata: sata_dwc_460ex: fix clear_interrupt_bit() clearing all pending interrupts Date: Wed, 8 Jul 2026 19:32:00 -0700 Message-ID: <20260709023202.2132165-4-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260709023202.2132165-1-rosenp@gmail.com> References: <20260709023202.2132165-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit clear_interrupt_bit() ignores the bit argument and performs a read-write-back of the entire INTPR register. If INTPR uses standard Write-1-to-Clear semantics, this clears every pending interrupt bit, not just the intended one. Coalesced interrupts (e.g. DMAT + NEWFP) would be cleared together, silently losing the second event. Write only the specific bit to clear so that other pending interrupts are preserved. Fixes: 62936009f35a ("[libata] Add 460EX on-chip SATA driver, sata_dwc_460ex") Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/ata/sata_dwc_460ex.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c index e206fbf6d2e9..097b060a9ee6 100644 --- a/drivers/ata/sata_dwc_460ex.c +++ b/drivers/ata/sata_dwc_460ex.c @@ -394,8 +394,7 @@ static void clear_serror(struct ata_port *ap) static void clear_interrupt_bit(struct sata_dwc_device *hsdev, u32 bit) { - sata_dwc_writel(&hsdev->sata_dwc_regs->intpr, - sata_dwc_readl(&hsdev->sata_dwc_regs->intpr)); + sata_dwc_writel(&hsdev->sata_dwc_regs->intpr, bit); } static u32 qcmd_tag_to_mask(u8 tag) -- 2.55.0