From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36DC5372EF6 for ; Thu, 9 Jul 2026 02:32:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783564332; cv=none; b=h1k1Xn+P/8MQBWWtgpZYbhzFE7/dBFxUUKFOpb9FJnhnslcuPkFJJHWBPMl8O131OJUUsQifFuQhxm+x8iffrjlQCNob0OUJojiZPtbPQwAsHhx8CumBqKrlkacYRzhx6tZOOarDPoU1jFd9VpBNQldsBuQfAPZPfhB2BFWnR1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783564332; c=relaxed/simple; bh=nFd8VNJfU3myVZBHymp3cLlppbZEAbYTvyZX1OHSZpg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K4roqsRqkgcfshkHCZM+7xXBK8MMtGln70KrO7ODghabveN6LB6SeO0TKRT1YXCtsFQKu3SK1YlEkLdQi7PEHlPhNjSGqigDD4Q7OtC+j+SnQWKnNac8M32Uf9R+QoceYyas7fpzaLKj9cy4BSUB1mH5v5+39HipVRqnBk22bQE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GsyYVzou; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GsyYVzou" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-847917c3678so297695b3a.1 for ; Wed, 08 Jul 2026 19:32:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783564330; x=1784169130; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TmOxRfgq8x+l85tT02jD5PytU+B1L3p5EI6y3uwnQjA=; b=GsyYVzouryA2QSsYyfyW6uMRAMgjzEqpHIziHVcOcEPla9lrdIEoWPvjY+U0EHfwKs /4yX9W5uRlglIOcE3llgxSamRPA2i9RZwWvGQvGRBODWH34B/AhOXS8uGPdR3BPO1th4 Mu4NSjUHyPQm1kZjCCEA3Ac1fMrkr3iUkqMrgNuB2KRXEheAv51vn5+F4YJ0UAYOxyjR Ch5PYvGfI7q+qf5FdJ6OuTMHsmGOeUlsUBtlYRLJmn2XZfHWuvQ8HQgz6x7W862iNKgx /3he+O/2sePjOlO9Jw9AYkSZVAN/k++yXRaJqDDRiB0yvuxsfZWqJO7pCsoSNAUJMwPh 36fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783564330; x=1784169130; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=TmOxRfgq8x+l85tT02jD5PytU+B1L3p5EI6y3uwnQjA=; b=k9s01iCQ+zeRooYN5TBfthGXMBSyBSZs2JO2l4wDM9P/2xWyFPmSmwbzgtc+DubW4t Id9dc8S2toMK9+89gR9qiwLPRvectYpRyGCpFQt5M93pLjV/aSmzFP7lYhIkSTOVKsm/ DhQdfo7Ylt3OqKWdw4A3ToCdM2V8eLV+UPb3KHH8LryeO20D8KCDLNoq8J6b3g+95ZoN uiQeC/tbEzYRN4xJHKtBzReP/8/UO8A6O+CHQLX2qFTrONjBIxX3hOJlli6JbMjEUMdb 9rOnwSsjPVKxygEmtQP8nrFxenz2LKKCZzfpejjCsRD2MFmaP4XXtI3CRvq561WVJshG ujWg== X-Forwarded-Encrypted: i=1; AHgh+RopfzgG5WrFkRHel1MCranEwjMRAdCtuLNcXs/twQeOZNClcYnfye9TlxpFdSkUYI95sGyXzpOAiZR784I=@vger.kernel.org X-Gm-Message-State: AOJu0YxYZb7eXys65HFcNgrEOZs4pbiEtXB5xEIng1U7+TuRVmFEjNi/ tDj8MpA8saozzOBxoSsl0aB+aPLc9HBou7WQGLp3ef7C5B34tb78sstm X-Gm-Gg: AfdE7clvHmYxsXPx3nSu5cG8ob0bY/5Jo2UN2n1Jb/Ewn7euXqMlq4yLkLW+Iqgf4/n u+7OBjCLsX1Sto5+lhpZsgMo7t9x74OEgjELzc7iNDUpJcjvEttX8GNqCAsfqvdLlz6cHhxpw/B 5FDNTnL+v2Oy8j/uonLJ2IeL2GE+uVdfEeODsPAggk46Lj6k3CYDvvogfEx6FnI1GTB9N/HV4Vi h0Xc3sP7PHFEMpCNrOMLEH5TF68tY4sB/oC2BQaipKuSvtbxN2dE3NdcGZuIQr/Vrfw5SSeHjuf X+7RL6OOf30upxOzlGuPUSFK+2AEPDi1g/AU/mF2gjZOgFgyPh3CRNH09hDLvHyCruCXhlVRBLn DbKQ38/5HAh/sfhElnRJ89tGxaiVrBDNhpwYPSqEQ23u2zb/ymrLa542BEMG67Tw4o3SCCbISC0 sIAoTxVkmU/SCArj6d+jYiqcF47SLRnBO1hPuYJdqqcJNuzwO/DYC7+1btzUbz9zkxOkDmQ1F7y JbQgBP/s5yuBQMscSYTbkZUzrbxlW9A0TyCZXp1zsBg21qWqRQ47Wsy/iqLCZldoA== X-Received: by 2002:a05:6a00:848:b0:847:9803:ec6f with SMTP id d2e1a72fcca58-8485aafa6fbmr885416b3a.10.1783564330465; Wed, 08 Jul 2026 19:32:10 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6b975a0sm7935954b3a.14.2026.07.08.19.32.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 19:32:09 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , Jeff Garzik , Prodyut Hazarika , Mark Miesfeld , Rupjyoti Sarmah , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv3 4/5] ata: sata_dwc_460ex: fix infinite loop in NCQ tag completion bit-scanning Date: Wed, 8 Jul 2026 19:32:01 -0700 Message-ID: <20260709023202.2132165-5-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260709023202.2132165-1-rosenp@gmail.com> References: <20260709023202.2132165-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The hand-rolled bit-scanning loop in the NCQ completion path has an infinite loop bug. When tag_mask has only high bits set (e.g. 0x80000000), the inner while loop left-shifts tag_mask until it overflows to 0. At that point !(0 & 1) is always true and 0 <<= 1 stays 0, causing an infinite loop in hardirq context with a spinlock held. Replace the open-coded bit-scanning with __ffs() which correctly finds the least significant set bit and is bounded by the width of the argument. Fixes: 62936009f35a ("[libata] Add 460EX on-chip SATA driver, sata_dwc_460ex") Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/ata/sata_dwc_460ex.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c index 097b060a9ee6..08d40e287bac 100644 --- a/drivers/ata/sata_dwc_460ex.c +++ b/drivers/ata/sata_dwc_460ex.c @@ -607,14 +607,9 @@ static irqreturn_t sata_dwc_isr(int irq, void *dev_instance) status = ap->ops->sff_check_status(ap); dev_dbg(ap->dev, "%s ATA status register=0x%x\n", __func__, status); - tag = 0; while (tag_mask) { - while (!(tag_mask & 0x00000001)) { - tag++; - tag_mask <<= 1; - } - - tag_mask &= (~0x00000001); + tag = __ffs(tag_mask); + tag_mask &= ~(1U << tag); qc = ata_qc_from_tag(ap, tag); if (unlikely(!qc)) { dev_err(ap->dev, "failed to get qc"); -- 2.55.0