From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AA123769EF for ; Thu, 9 Jul 2026 02:32:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783564335; cv=none; b=WVX/8IKM4qNFRowFgD09teK3NF2hsl1JpDtaJY5TO9wgg6qIAEdYeelNaUfcIfN0FGBpXJGgs07WNAuE9h50iLMOYgyWWaI589Od/FbUmzhfOC3xLjKdCUNf1vXW98L34GMM4lOxq5zkTbVt3HiDaR4LKskimp8BfOjjVFupscQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783564335; c=relaxed/simple; bh=2Dtmbs89HKUndcVX4gVLy7bjqf9OKz9nj6X8XiPjNJ0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TyiJoT+RHNqc/d/hxE8GfXbuWmgbAgHE3Z8lJ7o5BN29xobtBdaDDG5mej/DLlfBgwdFPOaoIlW7Pum7LTkdH6MsZjR2RF6V5ZD8Cr4x7CvZLsplVtbyX+UdhvPymtrW9lYNzqDT5u/eQV1RR+8kMy8P1ebI0bYd1WynPlJu/F0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jh9LLdgs; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jh9LLdgs" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-84347ad88edso1893003b3a.1 for ; Wed, 08 Jul 2026 19:32:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783564332; x=1784169132; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=18JTIpV0nCmEL5fegM0Z7dyxwLAxPNhc3uNEqo12imk=; b=jh9LLdgs54WHDC2I1oZqVOp5RX47vfj8MN9/RbqTnpxVkRPWZ0O/RZBcfHHt2Fcbma D0Iq4+seaNZpOwF63F3u4c36mITvGsjpj2omVrryD7qwApl+0W20JvU7Kw0dEwDwc6nl hrzWNLi4Gehc5FQleGyTIJJ1QP6DQzQCXIAQjly8DvG1oBtyQrhvBU8Ex+2JpOODENnI Ya2Wmrknw7rjaDzEqe0N44JxLV5iSK/7Sew5SqwGSR7SjVpqFn3p5+lCb119SJM9vSZD Fa4rKkLHoeq4vQ8BU9MOco01BkMaXcm1KXL0rhRFznD1JdVvNGlw+t+Ols0wXTiougLx tmGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783564332; x=1784169132; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=18JTIpV0nCmEL5fegM0Z7dyxwLAxPNhc3uNEqo12imk=; b=B+FcgLJJFKrXsNc1RNYZ9V9tj3+1nae6rqUgac46duJrJhQjrZ3QbLXLZxQEKUocWS /s2E9EM8kTfzfrcxZQRL9KrFoXgSPAzXhtRwYO0tZIYu6r0JSX5+xOk60/7sQCTBKUsJ UD5CcqwdeVTIIGHn3+vHZYZtK6iDIrbmeIdt7EKPCcgQfIJXC4ooL7knnsMRrBmRicyh 8ytXUOZaS2saDiOXNW7QXc5KT+X4acUwPw4m4jJ6j5L46F7Ef+RI0AjkZO31UwKfGLj9 HZA/Sv2qGD0i2J8nr+5EGzo9INZl3J166rKDg0xbdAxql+Eq22b0rU/mnsrGEmk3VOzk Z8kA== X-Forwarded-Encrypted: i=1; AHgh+RprqPrYvWbUo++sx51cHVvAt0E9AOI3cm9HZ+L9xBOj/U+kyZxlzbhW4nM6bnViaDS1uTZygsk3tlERwNU=@vger.kernel.org X-Gm-Message-State: AOJu0YyFxMfXTTVH3ZyM4h1HSHFVTBVSYcdR287wXcpInlPFc874XeE/ gxPlhB1+lUl0iH75bYtjSWmzyj54bcu6BMAR2SA6KRHCX+46E2vmx16K X-Gm-Gg: AfdE7clGDvlE/aY6GcFCxXLNktwQehgmwIkVlnDAErrsC42XSThQq+26Z2E5VK1z7Lz y/aVwmA4U9Vh04qdPvy0xpcqsuffHviWPcj7jW/kgfrbBBRDqdrnzc28LplaMTkCHw50Ymnsqdp kZAIKImTv/XTHxJmNN8DNdRhMwER3NfYsxcaeDlsOlHLMOA8mL+WuzTV+wRlnLk+V+muYPdRYHr rjmd7my8AFjuXzPMmSxmpMxm3Qr0y22G5V4a6d0WV8Btn/EhGfQqS4zQxNQZjZHkcFGHSO3dlxK 9C/qTqYKNhzXgihLP3Ogx30u0mFotsxzvXj8TWkCWaREXKWTAhXJdhYcDj4QJknyGvV1y8vcao3 haRrrx4HJQ9T+pShsara2lY8Yj8JbDXFAzPcRY+gBUw4qxpD+zzmevJM/BQgOP+WqO3lRsU1nLj PSVcmEwFqmbEM3AgNjWcry+xxSEyxCJk4f9w2oYQsv0Keu0zpNvlO9BbvR6tUNyv+AdNCl2+cBa V/G7KZ6t1mmniWLp8ajwL3w0nQVT2IWFRryDtcezynP/qzYosFpLzTKJ5XfejH+rRMKt/kzwsWy X-Received: by 2002:aa7:888e:0:b0:848:2f77:e2d8 with SMTP id d2e1a72fcca58-8484390d246mr4750121b3a.65.1783564331717; Wed, 08 Jul 2026 19:32:11 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6b975a0sm7935954b3a.14.2026.07.08.19.32.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 19:32:11 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , Jeff Garzik , Prodyut Hazarika , Mark Miesfeld , Rupjyoti Sarmah , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv3 5/5] ata: sata_dwc_460ex: disable SATA interrupts on device removal Date: Wed, 8 Jul 2026 19:32:02 -0700 Message-ID: <20260709023202.2132165-6-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260709023202.2132165-1-rosenp@gmail.com> References: <20260709023202.2132165-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit sata_dwc_remove() fails to mask the controller's INTMR and ERRMR registers before tearing down the host. If the hardware asserts an interrupt during teardown (after ata_host_detach() but before the IRQ handler is unregistered by devres), this can trigger an unhandled interrupt storm and potentially lock up the system. Add sata_dwc_disable_interrupts() and call it at the beginning of sata_dwc_remove(), before ata_host_detach(). Fixes: 62936009f35a ("[libata] Add 460EX on-chip SATA driver, sata_dwc_460ex" Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/ata/sata_dwc_460ex.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c index 08d40e287bac..381ace5d33e1 100644 --- a/drivers/ata/sata_dwc_460ex.c +++ b/drivers/ata/sata_dwc_460ex.c @@ -752,6 +752,14 @@ static int sata_dwc_qc_complete(struct ata_port *ap, struct ata_queued_cmd *qc) return 0; } +static void sata_dwc_disable_interrupts(struct sata_dwc_device *hsdev) +{ + sata_dwc_writel(&hsdev->sata_dwc_regs->intmr, 0); + sata_dwc_writel(&hsdev->sata_dwc_regs->errmr, 0); + /* Flush posted writes */ + sata_dwc_readl(&hsdev->sata_dwc_regs->intpr); +} + static void sata_dwc_enable_interrupts(struct sata_dwc_device *hsdev) { /* Enable selective interrupts by setting the interrupt maskregister*/ @@ -1203,6 +1211,8 @@ static void sata_dwc_remove(struct platform_device *ofdev) struct ata_host *host = dev_get_drvdata(dev); struct sata_dwc_device *hsdev = host->private_data; + sata_dwc_disable_interrupts(hsdev); + ata_host_detach(host); phy_exit(hsdev->phy); -- 2.55.0