From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 719E12E7F38 for ; Thu, 9 Jul 2026 04:05:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783569940; cv=none; b=HceAbRaxaW99yMPJ4lJstBoN2n4G6dKYl8G7w42yiXL1nUF96JvVFLI4yP0pMXrth2xUm/GXmwLyYxkmBNmwotyWvM5Kc/F9Sm9dY+cwkWMGskQCAFXPAVnlKAxLIi2QWv5U30RFjCxS1BjXHFmDgoLyR+0LOTxanhidU6NI2Zw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783569940; c=relaxed/simple; bh=NUkT6/ShlhXQfW6C+ENmEC2nVNz5PjvePWYznkM82FA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tqRNRvq7DF1Ay51xw0Cqua1NjZ0ti4oLH8eNc2oGfELpGuKHpdgdnbGElzdOmEHx6RLFwtBQOqSdU9z407LsG+jj/NpTlONStE69CJVFB+ZovqifynxTdeOuDGcWljGfUNUqo5LIWq/6TovmsvpeLwIIXv9pRGbww0J9jE+tMj0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oA877p3y; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oA877p3y" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-51bfad59921so3479601cf.0 for ; Wed, 08 Jul 2026 21:05:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783569938; x=1784174738; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=zZFkyFq2h98y9zFF3PAgNEsTvcMZMCQphOX1Zg5eGwc=; b=oA877p3yygRhtdDj3Rxp1+chOUjQfmjoZ66DkafXDSihmstZQOvTFFHT75u3qihoKx fz/5JLOC5UDlO1xq/7X2ovaHAbVOm2BcjeLE7lEUmKy9q4oaheNcml7zFTbaBiLvCcxA jBZa6MJW+NAXiEeYatpWP2p5a1UnXmfAVHC8hAygcVHXnZbofV4LE9+2CuFdRmkQWuPe RTW4CVUZlAz+Ym8rW14B7z0LqaCFaudOytdIAjTZJ0HojK8fdDUPbbO2aEWkC2tsu4PE Zo8HJWcp9qJkmTUAvCmccBxvaG1KR6H0SwbotAocbl0MqPc61YptNor7C8OTUiTp3Zdi h++A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783569938; x=1784174738; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zZFkyFq2h98y9zFF3PAgNEsTvcMZMCQphOX1Zg5eGwc=; b=rWNxT3gLvHT6j6Vlw2ynFzlZsehEWjtIE+d+598PNdkc11w4V46q7bkiF2JgBkJUh9 ix+9TRvcBVuCH7wuAcOK24UVt/IbkgPojInKImiNtSH40ElbMJv/k5hlV1OO4iC5McsY F4SWVv8t9DSV9kLyKUi53mDKAA+OzPKWxwkpVQc9vJxU/Q8Gz2xDh2j9D0nR6h2NdBDY /jyzDVVDRjAeQ26wy4YqxLiryydgcsCvSOQLYvnp5cPeklxVs/llVZuGM7wb18bR8tE6 +gm8rzvns/+U8kAkUYYFDvyK2Qvro21K4uRR9H4NxXs12zEYklJwfoOUr+W+cb9hjNTb FbSA== X-Forwarded-Encrypted: i=1; AHgh+RoShQAl2RZdOcBAqkwgHGz9dApIVpy8N2WZGULuNddSV3Cs5ByJ/OO1IDcMXf/m0B1m+faQVsZb/2ob/fY=@vger.kernel.org X-Gm-Message-State: AOJu0YyAh2EB3C4jRGiOsH3hf7l5u9049VSYlD1RAdRvb0bVTyaijMZb DPFiFCg+MymHhjC2x74JuuGaV6/9zge71rVTwxRUtV72ksSlHWeCOsaP X-Gm-Gg: AfdE7cm58pUTq5jfqJg6KeH6TbaG4XvLp6CepRl2kZt5e8eAJGAr6fRhvwnYx+V5mjF E8V7eKmaw8heir+fkJwe2Blr1/tqXJxrbuIdvI1NLFjdnwp7wgTQyZnjz0I/ygHjyPJef4vt3Dj IUnXs9cb7x3OkZC6Ey6A44kAUXbpEmgct0M8xgGJ1L3mdFx7VcETJmOgm4vE2NvoSqPQqOx7tIM UWV3U1Y3VIA00MSUh5BOcuSRRZblR+ubd3vZJ8Lib+3fiHXw9Wl7aCU1LqLtf7vk9KE1+5bG059 0Kg0qonzC+t94KNIqVsVb4sRFD7lVFLzdWHCoPqdtur8UUKEZdMM3vxySif8BiXZDqdLsHCHizp aT6/Vhhr+8rbpUXVP6mxMGY6srufrzJYGw+yOk1G6NprxQDVtzpHXYu5HdCrdNzcyZFg0Hqylza 8RTg2MRsPIkZ7Py6uB1+kyAek8hxn+Y77XqIJe8/PSc9o= X-Received: by 2002:ac8:59c6:0:b0:51a:8c9c:7f3e with SMTP id d75a77b69052e-51c8b4fd27emr53968021cf.65.1783569938404; Wed, 08 Jul 2026 21:05:38 -0700 (PDT) Received: from fedora (c-69-141-67-19.hsd1.nj.comcast.net. [69.141.67.19]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51c41abb484sm160848081cf.4.2026.07.08.21.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 21:05:37 -0700 (PDT) From: Aditya Tipre To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Aditya Tipre Subject: [PATCH] staging: rtl8723bs: remove else after return in enqueue_reorder_recvframe Date: Thu, 9 Jul 2026 00:03:48 -0400 Message-ID: <20260709040419.216324-1-tipreaditya@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The duplicate-frame path returns immediately, so the following else is unnecessary. Use continue while walking the reorder queue and fall through to break once the insertion point is found. Signed-off-by: Aditya Tipre --- drivers/staging/rtl8723bs/core/rtw_recv.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index 86c5e2c4e7dd..c97c5fb73bb7 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -1783,14 +1783,17 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl, un pnextrframe = (union recv_frame *)plist; pnextattrib = &pnextrframe->u.hdr.attrib; - if (SN_LESS(pnextattrib->seq_num, pattrib->seq_num)) + if (SN_LESS(pnextattrib->seq_num, pattrib->seq_num)) { plist = get_next(plist); - else if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num)) + continue; + } + + if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num)) /* Duplicate entry is found!! Do not insert current entry. */ /* spin_unlock_irqrestore(&ppending_recvframe_queue->lock, irql); */ return false; - else - break; + + break; } /* spin_lock_irqsave(&ppending_recvframe_queue->lock, irql); */ -- 2.54.0