From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80CD439281D for ; Thu, 9 Jul 2026 06:28:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783578533; cv=none; b=ave+l/rpoHKhVVztZO2YFkBWf3GBjKg3uWBgOC9OrpVC5EPZe7OVPmWxe/fHQU3aHRvtx7Gz00AaqKqRxyp8i0+COaasQtU35YNTJBHEfffu9lHP5WU0mhtROH5OxQSFSJRf9QfFGNin5LSu5aOZFSIKUBeermZlY3HuSKBnpms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783578533; c=relaxed/simple; bh=6ZD5u1j99PnID68jkgO+3ccB0arYOSegCbBXuh/jBos=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Xy52AQS6Vvi76J2Lpd+yqLj0aILCM6WgQisR+bNODqmYTyazbQOYvfkEzEaDF5G3E1k44ZNL+jTwjUMMpvEQi9Sl1FA/Cm4pVzsR3H2iBfOdGkgldnrtA9q0wpp5CDXDxcakxUNKzKVUK0qSYiClHyMuDzOhwC5wqNdlua7ekyM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id B1B1E68BFE; Thu, 9 Jul 2026 08:28:45 +0200 (CEST) Date: Thu, 9 Jul 2026 08:28:45 +0200 From: Christoph Hellwig To: Nilay Shroff Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, hch@lst.de, elver@google.com, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, bvanassche@acm.org, gjoyce@linux.ibm.com Subject: Re: [PATCH v3 07/18] nvme: add context annotations for nvme_subsystem::lock Message-ID: <20260709062845.GA18056@lst.de> References: <20260706141452.3008233-1-nilay@linux.ibm.com> <20260706141452.3008233-8-nilay@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260706141452.3008233-8-nilay@linux.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Mon, Jul 06, 2026 at 07:44:09PM +0530, Nilay Shroff wrote: > Wrap the initialization of nvme_subsystem::nsheads with > context_unsafe(...) to suppress the context analysis warning emitted > for INIT_LIST_HEAD() during object initialization. Still not a fan of that vs adding a proper helper. > nvme_ns_head is allocated with kzalloc(), so explicitly initializing > nvme_ns_head::delayed_removal_secs to 0 in nvme_mpath_alloc_disk() is > redundant. Remove the redundant initialization, which also avoids a > false positive from Clang's context analysis. Please split that into a prep patch.