From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAE2F3AD52D for ; Thu, 9 Jul 2026 06:30:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783578624; cv=none; b=s35hyQX0vFwzRqYMeK1/GVBYWLz9eLHBxurMkBGBXRqj+FKzLYO/dQZkNJ3TINoftpyzu99shdsgD09G6aH7TsRROAqYkM0pPu1f+cky32FrNcE4TFHKT8Fqxed/mjBjAprWIu4fd8GqKZA92Pufkxx40SjSYpj9TgGBWuO4Qyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783578624; c=relaxed/simple; bh=kV3JC501VSbN6zJZ6k25HeN7hLJxg0+b7ZVQGOX2QKk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hAJQAGNH1CwO9ndAe5pp0O+gB/XQd5dZwix3OFRLWBER2jvzYKkxmvbm8BqJNEjwOyb1x/zhl6/loN+EC5elSOQortWVKAHubygUF8HOu/7DyqxmIRmJ9quSe0JbM+acoBUNYW3j1A0h9LRtvqaVhw0c4/baX5rL8gwg96yPGX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 3F4E068BFE; Thu, 9 Jul 2026 08:30:21 +0200 (CEST) Date: Thu, 9 Jul 2026 08:30:20 +0200 From: Christoph Hellwig To: Nilay Shroff Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, hch@lst.de, elver@google.com, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, bvanassche@acm.org, gjoyce@linux.ibm.com Subject: Re: [PATCH v3 14/18] list: Permit context-unguarded access with list_empty_careful() Message-ID: <20260709063020.GC18056@lst.de> References: <20260706141452.3008233-1-nilay@linux.ibm.com> <20260706141452.3008233-15-nilay@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260706141452.3008233-15-nilay@linux.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Mon, Jul 06, 2026 at 07:44:16PM +0530, Nilay Shroff wrote: > From: Marco Elver > > With Context Analysis (viz. Clang's Thread Safety Analysis), list_heads > that are __guarded_by(..) require holding the appropriate context lock > when accessing and manipulating them via the list API. Because Clang's > warning diagnostics do not perform inter-procedural analysis, this is > enforced by Clang with -Wthread-safety-pointer in the caller at the call > boundary; a warning is produced when passing a pointer to a guarded > variable without holding the appropriate context locks: Same thing here, maybe try to get this to Linus late in the current window as it's trivial and makes dependency management much easier. If that doesn't work, move it to the front of the series.