From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FB462E7364 for ; Thu, 9 Jul 2026 06:31:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783578665; cv=none; b=iEr0TvD87FdfOa3wdRnEH995MRJGr9onoV0DtUAQKRH8eQXCvFEJtCRH2fcbFN5YhehxtenZzLKGWGFfN2dMO5O3u9sqZEwiXJDArjJetZ4FYS5bLO3IbFRABkIyJQ27BAHyJJ9ZSUfwmhLD4TmfoF+/RJplcGLxUyiTThk47Lg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783578665; c=relaxed/simple; bh=ivdY19FVLNAUzv7R0oMKolYyks48OYioTJXWgFwGCsU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lm352ItVquuL1Zc8tlbDGRLWszBDL9nuieZoNsbDaXFuPXFUBcnVEXvjjrNS3tQ5noKV7kl51CHVf3kDC4bgzXjjz69UIp5FD3Q0oPp5r8BiIYtGxrBqx9WOJR5bYnyOrYEzhUtBzF8HvevtwhsXxm934Tfvm+L//nqJFB7gK/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id DE1F268BFE; Thu, 9 Jul 2026 08:31:01 +0200 (CEST) Date: Thu, 9 Jul 2026 08:31:01 +0200 From: Christoph Hellwig To: Nilay Shroff Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, hch@lst.de, elver@google.com, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, bvanassche@acm.org, gjoyce@linux.ibm.com Subject: Re: [PATCH v3 10/18] nvme: add context annotations for nvme_subsystems_lock Message-ID: <20260709063101.GD18056@lst.de> References: <20260706141452.3008233-1-nilay@linux.ibm.com> <20260706141452.3008233-11-nilay@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260706141452.3008233-11-nilay@linux.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Mon, Jul 06, 2026 at 07:44:12PM +0530, Nilay Shroff wrote: > + /* Initialize unpublished lock-guarded variables. */ > + context_unsafe( > + INIT_LIST_HEAD(&subsys->ctrls); > + INIT_LIST_HEAD(&subsys->nsheads); > + ); This is still making a mess for no good reason :(