From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99E8634F462 for ; Thu, 9 Jul 2026 06:32:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783578738; cv=none; b=nC2x/Y0s/+xQ1EXRDpqQG9nSbZ4nq64ELPXZc1E0fL7gTQ62MirIkXh4uJrdxS4Hy0KYZNMRk8aXE2HrJijEX/xGjvgl2GF9iaoVPbizWlTKgmufrIufy3qcx0xjEAS7PmbKF2vD08WRK0DJzFaLXrBN+d3FdnpEofG82sFkEIU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783578738; c=relaxed/simple; bh=Dk02ykVc9rivLUToMnd82XFjyH5ECqan82WwQsR8Mgw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=swegRpgkSTfu0Zy8OZSkJQBzkM+Fv55c7ZuEUWNoEdFSuYEFZn6qnnvhJ2oW11GaEBSowO52d3UXhLtOEFCPr1iGkZFjNmWj6hIJj8ECm6p8acG+KM2plyuvalfJqNLuBCY1dA2Ujho/m5/2AzvfIjJNX4JdFuhQqz/FQ25jWj0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 1374368BFE; Thu, 9 Jul 2026 08:32:15 +0200 (CEST) Date: Thu, 9 Jul 2026 08:32:14 +0200 From: Christoph Hellwig To: Nilay Shroff Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, hch@lst.de, elver@google.com, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, bvanassche@acm.org, gjoyce@linux.ibm.com Subject: Re: [PATCH v3 12/18] nvme: add context annotations for nvme_queue::sq_lock Message-ID: <20260709063214.GF18056@lst.de> References: <20260706141452.3008233-1-nilay@linux.ibm.com> <20260706141452.3008233-13-nilay@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260706141452.3008233-13-nilay@linux.ibm.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Mon, Jul 06, 2026 at 07:44:14PM +0530, Nilay Shroff wrote: > + /* Initialize unpublished lock-guarded variables. */ > + context_unsafe( > + nvmeq->sq_tail = 0; > + nvmeq->last_sq_tail = 0; > + ); We'll still need to find a way to avoid this mess..