From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6A943D903C for ; Thu, 9 Jul 2026 06:42:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783579363; cv=none; b=XBE3SnCPpEd9VSLdCrYJe0kDXMeBozawjWITZEeoWPboI9EoykEy1XWt6RCVWNDov69juFZ5J+tB6NbjtiaV1zPOYMdoCGkAnjDXlAF+mbmpwF4g5XCCx69UDgmL9pJpdN2Wa3iHMNL7fBlfE7ZpspVt2hlP2kK+XLkyPMGnhsk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783579363; c=relaxed/simple; bh=ZO5wpnG7quvfMvg3nW6xyPYhhRBDymP84mxQ0084mB4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P3Kr3Jr+MQq7gB3/hMFrFtxN9mY3E58ooZ1qDm8J+/rrBpPTQefVXQcEIAdXSNZHkjKIgc/YX1DMjF/Rm7JaSUEmULWUatJsZfDIEYlKCJfgLyr7/4+gQ45cTLSB3PThO0Kr0cUXNlnaovnS6uI9g37ZU6sJxW2R2aTNWdew9w8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 9734868BFE; Thu, 9 Jul 2026 08:42:34 +0200 (CEST) Date: Thu, 9 Jul 2026 08:42:33 +0200 From: Christoph Hellwig To: guzebing Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Guzebing Subject: Re: [PATCH] nvme: make firmware activation poll interval configurable Message-ID: <20260709064233.GA18381@lst.de> References: <20260627010610.47768-1-guzebing1612@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260627010610.47768-1-guzebing1612@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Sat, Jun 27, 2026 at 09:06:10AM +0800, guzebing wrote: > From: Guzebing > > nvme_fw_act_work() polls the controller processing-paused status every > 100 ms while firmware activation is pending. Some devices can complete > online activation in only a few hundred milliseconds, so the fixed > interval can add noticeable latency before the driver observes > completion. > > Add an nvme_core.fw_act_poll_interval_ms module parameter to make the > poll interval tunable. Keep the default at 100 ms to preserve existing > behavior, and accept values from 10 ms to 100 ms so systems that need > faster completion detection can opt in to a shorter interval. > > Signed-off-by: Guzebing > --- > We recently observed this issue while performing online firmware > updates for Gen5 NVMe SSDs in a production environment. > > During firmware activation, the kernel quiesces I/O. Detecting the end > of firmware activation earlier lets the driver unquiesce I/O earlier, > which is important for the long-tail I/O latency of production > workloads. What value does this device report in the Maximum Time for Firmware Activation (MTFA) field? It might make sense to scale the polling time as a fraction of that instead of requiring a manual override.