From: Simon Horman <horms@kernel.org>
To: Thomas Martitz <t.martitz@fritz.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 1/1] macvlan: allow source mode devices along with passthru
Date: Thu, 9 Jul 2026 16:18:18 +0100 [thread overview]
Message-ID: <20260709151818.GP1364329@horms.kernel.org> (raw)
In-Reply-To: <4ffe7fe8-fdbb-42a1-b2b1-d11a351b2e16@fritz.com>
On Thu, Jul 09, 2026 at 10:49:36AM +0200, Thomas Martitz wrote:
> Hi Simon,
>
> Am 08.07.26 um 18:43 schrieb Simon Horman:
> > This is an AI-generated review of your patch. The human sending this
> > email has considered the AI review valid, or at least plausible.
> > Full review at: https://sashiko.dev
>
> Thanks for feedback. The remarks are valid, I agree. I also begin to better
> understand the macvlan code so I'm a bit more confident now about which of
> the existing "macvlan_passthru" checks need treatment. I'll send an updated
> patch.
>
> General question though: The initial posting triggered an AI review (I see
> that now, I didn't know about https://sashiko.dev before). But it did not
> trigger an email. Can you explain why? Because I accidentally dropped the RFC
> tag from the mail subject?
Hi Thomas,
If I understand correctly you are asking why the sashiko.dev review
wasn't automatically emailed to you.
If so, I believe configuration of that feature is on a per ML basis,
and it is not enabled for netdev.
In principle the sashiko review(s) show up in patchwork
(although, perhaps not completely reliably). I would
suggest checking there.
...
next prev parent reply other threads:[~2026-07-09 15:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 9:23 [PATCH RFC 0/1] macvlan: allow source mode devices along with passthru Thomas Martitz
2026-06-12 9:23 ` [PATCH RFC 1/1] " Thomas Martitz
2026-07-02 6:56 ` [PATCH RESEND RFC 0/1] " Thomas Martitz
2026-07-02 6:56 ` [PATCH RESEND 1/1] " Thomas Martitz
2026-07-08 16:43 ` Simon Horman
2026-07-09 8:49 ` Thomas Martitz
2026-07-09 15:18 ` Simon Horman [this message]
2026-07-09 9:11 ` [PATCH v2 0/1] " Thomas Martitz
2026-07-09 9:11 ` [PATCH v2 1/1] " Thomas Martitz
2026-07-10 7:48 ` [syzbot ci] " syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709151818.GP1364329@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=t.martitz@fritz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox