From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A61A23D7C2; Fri, 10 Jul 2026 14:32:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783693980; cv=none; b=NJ9mpu48NpqrTRdjgxv/qkoeHF9ATTl2P43TgRLOEJ1zjpJ2qgLQvMD2zy3enar8NpY/AjU7reQmJNnKzp6cbvOwWedHmcmsVIhxNgMZ3wkpI28eT4RCyYKcl/y1Z4MOAb/nTsZQoqgfWi95D6/jQloTTn2SWE1DP1QJ1ykLPeg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783693980; c=relaxed/simple; bh=FYPaH+l+XTQ5sU7Qv4cn8DYzP7Jz4mGDL005ddMunCU=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=EpkWgHe/pSmgg45tAUx7DFeWPZ8rYAtMGoANdNqRZh+3HKO8WZIhwEKMuL1hQA5e/Izdhz7MTTAHJQyaO6hbTpkjnsP8jkUTsY/N6y+/gHSoeAZwzPGTeuurXoSjiDrrDL4xU4Eg1hCKh8fD2ZW3kVeIb0YjSuOImlvHp5FFA6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h3ZNjoUy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h3ZNjoUy" Received: by smtp.kernel.org (Postfix) with ESMTPS id B2371C2BCB8; Fri, 10 Jul 2026 14:32:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1783693979; bh=FYPaH+l+XTQ5sU7Qv4cn8DYzP7Jz4mGDL005ddMunCU=; h=From:Subject:Date:To:Cc:Reply-To:From; b=h3ZNjoUynAUc/2aLcOmwWnapF2+u6UTfNSGyb3x1qUF8r0ovYWv5En/UsvqY2m2MK zzvNHkG3nXMR7ik+prSajZjHGOuqGLtCaCsv4h5GJ3ljULkzh6Br24i5gVhWnIF0eI QUkOv3oYIdXG6/hF+/TZMwGuT40EeFYsb8XtI/ss0bhURZ83FaN2QTsYAhEWxlAEl5 0W17sWrl2xyvnyegIrFuY5Nby6hIxySd7rUlcuXEc6gHLUDGXgXKRkpv9xAVsaKRgj k3f5ODJdh8LcRLNiM7wgjsN4LiUgqqYpPnR+J8a3zughxQ1/acBSu63Fi87+VKvJUa wMFChqjZ2it4w== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D912C43458; Fri, 10 Jul 2026 14:32:59 +0000 (UTC) From: Jahnavi MN via B4 Relay Subject: [PATCH v2 0/7] rust_binder : Implement dynamic debug logging mask Date: Fri, 10 Jul 2026 14:32:51 +0000 Message-Id: <20260710-rust_binder_debug_mask-v2-0-2846410e3ae6@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAJMCUWoC/3WNwQ6CMBAFf4Xs2Zp2KyV68j8MIZQupVFa0wLRE P7dSuLR40zy5q2QKDpKcClWiLS45ILPgIcCuqH1lpgzmQE5Kl5xZHFOU6OdNxQbQ3q2zdimO1N SVbLiolR4gjx+Rurdaw/f6syDS1OI7/1nEV/7S8p/yUUwzs7a9AJ1KbHsrjYE+6BjF0aot237A Pv13G+9AAAA X-Change-ID: 20260702-rust_binder_debug_mask-636737015624 To: Greg Kroah-Hartman , =?utf-8?q?Arve_Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Christian Brauner , Carlos Llamas , Alice Ryhl , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Jahnavi MN X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783693978; l=3639; i=jahnavimn@google.com; s=20260702; h=from:subject:message-id; bh=FYPaH+l+XTQ5sU7Qv4cn8DYzP7Jz4mGDL005ddMunCU=; b=iymmeidSegkN0WgX29oEAgF/EVrw8oCYVHfMf2H9kNpNWthk3+z1WhirYD4PsnJQKm8RGUJP+ /ogUSKq11B9DL1cL2i0cWBblc+I/xLYpfmwgMpexNnfFIzfIEM0zhkr X-Developer-Key: i=jahnavimn@google.com; a=ed25519; pk=9aLfw3FepTOJwTS7jRXm7pDH87eBeZMXBPrqwU0//RE= X-Endpoint-Received: by B4 Relay for jahnavimn@google.com/20260702 with auth_id=849 X-Original-From: Jahnavi MN Reply-To: jahnavimn@google.com When a user-space application sends malformed data or makes a lifecycle mistake, the driver rejects it with a generic error code (like -EINVAL). Without internal logs, the driver acts as a "black box," forcing developers to guess which check failed. In the legacy C Binder driver, this issue is solved using a dynamic debug_mask module parameter that toggles verbose logs for specific subsystems. This series brings the same critical capability to the Rust Binder driver to provide developers with clear, real-time feedback. Instead of rebuilds, reboots, or guessing: - Developers can enable logs instantly on a running device by writing to `/sys/module/rust_binder/parameters/debug_mask`. - It prints the exact reason for failures (such as alignment errors, mismatched call stacks, or invalid handle references) directly into `dmesg`, reducing debugging time from hours to seconds. - It protects system logs by keeping logging off by default and only enabling it when developers are actively troubleshooting. Based on top of: https://lore.kernel.org/rust-for-linux/20260707-upgrade-poll-v6-0-4b8fae7bf1d9@google.com/ Signed-off-by: Jahnavi MN --- Changes in v2: - Defined the debug mask categories using bitflags (impl_flags) to resolve potential Undefined Behavior and match Rust idioms. - Added a tgid helper to rust/kernel/task.rs to expose the task group ID and optimize default "PID:TID" prefixing. - Implemented the BINDER_DEBUG_DEATH_NOTIFICATION mask to log OOM failures, lifecycle updates, and async delivery to user-space. - Added pid fields to ThreadError, DeliverCode, and FreezeMessage to ensure cancellation logs show the correct process PID instead of background kworker PIDs. - Removed duplicate PID printing across workqueue, transaction failure, and stack unwinding logs. - Refactored log formatting (e.g. formatted BinderError with {:?}, used "strong"/"weak" strings, and improved message wording). - Fixed logic bugs (restored missing update_ref block, moved manager lookup warnings). - Cleaned up spurious newlines, corrected indentations, and adjusted all commit titles to be shorter and more meaningful. - Link to v1: https://lore.kernel.org/r/20260703-rust_binder_debug_mask-v1-0-9bdf12b5325c@google.com --- Jahnavi MN (7): rust_binder: Add dynamic debug logging mask rust_binder: Implement BINDER_DEBUG_USER_ERROR for freezer-related operation rust_binder: Implement BINDER_DEBUG_USER_ERROR for refcounting and death notifications rust_binder: Implement BINDER_DEBUG_USER_ERROR for transaction parsing failures rust_binder: Implement BINDER_DEBUG_FAILED_TRANSACTION rust_binder: Implement BINDER_DEBUG_DEATH_NOTIFICATION rust_binder: Implement BINDER_DEBUG_DEAD_TRANSACTION drivers/android/binder/debug.rs | 80 ++++++++++++++++ drivers/android/binder/freeze.rs | 70 ++++++++++---- drivers/android/binder/node.rs | 30 +++++- drivers/android/binder/process.rs | 62 ++++++++++-- drivers/android/binder/rust_binder_main.rs | 16 +++- drivers/android/binder/rust_binderfs.c | 3 + drivers/android/binder/thread.rs | 149 ++++++++++++++++++++++------- drivers/android/binder/transaction.rs | 15 +++ rust/kernel/task.rs | 7 ++ 9 files changed, 363 insertions(+), 69 deletions(-) --- base-commit: bf694eb01b1313f5510645ca34be4ed034ae08de change-id: 20260702-rust_binder_debug_mask-636737015624 Best regards, -- Jahnavi MN