Re: [PATCH 1/6] dt-bindings: iio: adc: Add AD7768

[Jonathan Cameron <jic23@kernel.org>]

> > +  adi,common-mode-output:
> > +    $ref: /schemas/types.yaml#/definitions/string
> > +    enum:
> > +      - avdd-avss-half
> > +      - 1.65V
> > +      - 2.5V
> > +      - 2.14V
> > +    description:
> > +      Common mode voltage output selection.  
> 
> Why not using standard regulator provider bindings for this?

Interesting question.  If that was done there would need to be
a consumer which means explicit modelling of any analog circuit.
We do that in a few cases but so far (and yup this is a driver thing
in a dt-binding) I don't think we have any way to consumer data when
a backend is involved.
	
> 
> > +
> > +  adi,vcm-power-down:
> > +    type: boolean
> > +    description: Power down the common mode output buffer  
> 
> Is the buffer separate from the output? In that case I would expect
> buffer to be in the property name, otherwise this should just be
> part of the enum options above (and the default one at that).
>