From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4CD82C3255 for ; Fri, 10 Jul 2026 02:32:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783650724; cv=none; b=DdEWww+DrrsFCf5nZj8lZV9Ob3benOITNwXwAJ4lwM1cHMyLkAhYQ1YfKeCDh9TMTPPtz4CWMRTmn4ycC4ZRpen0VWzYi/mp9QlPUftITjItf39vzwyhRZArQdOpz/1XJgH1WvtJUD1hv2eU4AoL5GrgIF3Gt/Mkv14o9DP8rP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783650724; c=relaxed/simple; bh=XAdJ/tsGYcNj7MCZVoa+YxBZ7K9W6w6UcY+bnzhzGUM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IU0jexMf3+pI/b4DoCrX+6sZT1vNswkam9y6pxpyQSau2EHXEfXGz8/33x48KgsxVM+P9d+b98ke3+FiEc068S3nBxLmNc988pvKUBggY23swvUJ1zPzFBfD573sigkd5kxS3/Oxs15RleTW+6RS5BDBZEnZJEOQkppReC4KP9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kjEFUDN3; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kjEFUDN3" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-92e54f8c051so18600585a.3 for ; Thu, 09 Jul 2026 19:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783650722; x=1784255522; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=GfQtbikmekSxNqjFjSAFJmT5+XBv2183xfWostgHcOU=; b=kjEFUDN3LGkljnZFiJA18m+T4QR508MdGPeEXJB3wtxIx+VM94W6jJbUwn99Rq6PB1 t//ZmmSmXV07L8b5jzk//4jPEYPfe1VkA3lRQYl2bXyMWFcDcpXmkj9EKCnYRCJVcvwk I8O2A8Z+A4HsBr3DA1ItG1krXtav/4Ew/a/6jRdwb6zSQd1b7pE6iHOWeUwc3E4+8Pd0 vBr6fIOujint7gFTcXv17NLKjCeQsDdIwgeerGocHRjpa6xNb8e2m7BT87Kdq/AqmN8A uiwULvXBSHxEbqRp0reGCyl1BnPNITR0HHv3gFyI5AMKFJRv9R9XIdRoYrEEDWtkkRsd WfVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783650722; x=1784255522; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GfQtbikmekSxNqjFjSAFJmT5+XBv2183xfWostgHcOU=; b=BLo2Ip4UZmFy/snVlRhjn3Phbum/DhOUje1CUGfRjkJDJRefGGKgampUDgGOnZ2hAs 2N0ItkmvesRc9RcplSJTB7F1xJ0/SSglNLrAfnb9nuaJdzjvtrCcFMSZEUhTkQ2G/Myw hjRERrbouekAH3U5FcwRnvD8QEocUn1YXLoDVgzSFbcnyFmz6C34OI2qj9WXoUiPnofv 1m+S/bsOS8Gfkpekezo3dwp2sskaOSzzQfTdj2mlnHR5PRkn5P3whxyLJfktoVU8Fvq3 ngTUVK9tWDdS4sUVnt3Akj2F62zNBv3eAHbbn/o6Td7ePTfZI2El6X4QOdN/cVK+MnQu PnCA== X-Forwarded-Encrypted: i=1; AHgh+RqgGHADXBUbdstll1hDZGU95+a9XIWdWq0bHcPZgwH6hguwIT45g0dcVTpkLD2qUoRB1EBHq//0vsjE+J8=@vger.kernel.org X-Gm-Message-State: AOJu0YyNL2xz/4Ac8zdzvBQxdUfbf4E6AMVfDQoymDIPKClGV17OfrAz 3ogy+6WmLPgmm4JUGI8vU0aw/BgL/XLaxc3UUVvx2UMQEoG/I00CAu+L8Fjn7lvOBdc= X-Gm-Gg: AfdE7cnQJohay72u65Fwr2F7Pclq4JDzCQRDhXxqpwKK7w3Q8Rt10TWWe+C7CHOBzVe nxU9KOqEfhUCVS4VP9pHfCCU/I/+8FZ59B3QvKDyIL8hO9ZXQ+yn+Apf0OyuGk5AZla4GNDY6fQ KSuuJkyYhKxzoYaZ2E+OUNyLFb8b4Ld+6DM9VlT8yYbI8vu5ISNsKoWreJsfxNrCTkHIp1o87P5 B5ZKdvrQG/+EKO+1Sx51+jyO8hmbdrtP9Bk5fsKZwEWKeD23wBaaPV584nekHuk/+VR1D8rWPeR 0hBJsL8lcydvnX9/kxfPbuf6voTCAKZbJT1imzZJwp3e/ZDLzZl0wHy5lQxtA9WejcwugxXZwcL mfGPH7pSEeLhPc2MfvTzFyMoeiPRivKXJsCNExVMQib8FToh7TASAfpDUvbMzyEfNDYqid4SBlt ffFGTD8yuUdmEkTKkp0FevNs2ODRSND6eypsfbFFTL03Q0GhvvT3VGLITS+z3hLETjUlcOYIXp4 ZlwG1kBF7VxFZaREukGpdmuCfPTIImPR+I7zm9/dTY= X-Received: by 2002:a05:620a:4410:b0:92e:6fb0:e79a with SMTP id af79cd13be357-92ecf527f6cmr992424485a.2.1783650721652; Thu, 09 Jul 2026 19:32:01 -0700 (PDT) Received: from server0.tail6e7dd.ts.net (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92ee5cfdbc7sm89500985a.22.2026.07.09.19.32.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 19:32:01 -0700 (PDT) From: Michael Bommarito To: Hans de Goede Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] vboxsf: validate directory entry name length Date: Thu, 9 Jul 2026 22:31:56 -0400 Message-ID: <20260710023156.3749541-1-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Shared-folder dir entries carry host-reported size and length fields. vboxsf_dir_emit() checks that name.size fits in the returned buffer, but later passes name.length to vboxsf_nlscpy() or dir_emit() unchecked, so malformed host data can make the guest read past the shfl_string buffer. Reject entries whose name.length exceeds name.size before either consumer. Fixes: 0fd169576648 ("fs: Add VirtualBox guest shared folder (vboxsf) support") Assisted-by: Claude:claude-fable-5 Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Michael Bommarito --- fs/vboxsf/dir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/vboxsf/dir.c b/fs/vboxsf/dir.c index 42bedc4ec7af7..702d243169936 100644 --- a/fs/vboxsf/dir.c +++ b/fs/vboxsf/dir.c @@ -129,6 +129,8 @@ static bool vboxsf_dir_emit(struct file *dir, struct dir_context *ctx) end = &info->name.string.utf8[info->name.size]; if (WARN_ON(end > (b->buf + b->used))) return false; + if (info->name.length > info->name.size) + return false; /* Info now points to the right entry, emit it. */ d_type = vboxsf_get_d_type(info->info.attr.mode); -- 2.53.0