From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ADD63ADBAD for ; Fri, 10 Jul 2026 07:38:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783669141; cv=none; b=S0wz80gKSc8VSbC5fBkvUjQtSrix1bgRp1uTuI2olQtXnlMe4TMxZltIqbYaIzkCMiNIgzSihD1vnR/iq37I0QeUfM3LblYJSqRvwOp8IL9979xz5Vsismz0onvHkBmAv+nw22xF43fIFP13oc8dJQR8UFtdcSSHR6BaU5Mgy8w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783669141; c=relaxed/simple; bh=xSNIeyQeUHQgZHGjLA322pu93/7oHBT7D8w6q7YwSZU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UmvkN8rwMf1K58i1RY1bhOQhdxm9p4qonla0z7/EOTvUhMZpuVJ4KkhnU7uxA//FNdtZLpnKpUCUZs4HHmBGnr2WpILVrd7wR9Ida7givmO2+EgsEP9hnh5Hu5Mgu97oL5pD1eK4Jvq3w66YcmQyyrC0ryPLe/4ukqTCJec/reI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=KCdmfVNq; arc=none smtp.client-ip=91.218.175.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="KCdmfVNq" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1783669127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xSNIeyQeUHQgZHGjLA322pu93/7oHBT7D8w6q7YwSZU=; b=KCdmfVNqyUT+aXz3av1Mlph3kPfUMFvt9IgSgl9i9QJvbLNnPzbn5BL/edpQDexUYk5Hsd foiRM5fDCMMMM50djFYVXvJXBq4Jqc6CAfYRiBVdkmkv81vVneipr84BsiWqiSPCTiqm1t 32MvIDJjIvV1wzIg9suxmuSZ+bGKH1U= From: George Guo To: joe.lawrence@redhat.com Cc: chenhuacai@kernel.org, jpoimboe@kernel.org, peterz@infradead.org, jikos@kernel.org, mbenes@suse.cz, pmladek@suse.com, kernel@xen0n.name, rostedt@goodmis.org, ardb@kernel.org, nathan@kernel.org, nick.desaulniers+lkml@gmail.com, yangtiezhu@loongson.cn, jiaxun.yang@flygoat.com, liukexin@kylinos.cn, guodongtai@kylinos.cn, xry111@xry111.site, wangyuli@aosc.io, loongarch@lists.linux.dev, live-patching@vger.kernel.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 04/12] livepatch/klp-build: build LoongArch with -fPIC to keep GOT-indirect symbol references Date: Fri, 10 Jul 2026 15:38:27 +0800 Message-ID: <20260710073827.27064-1-dongtai.guo@linux.dev> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Hi Joe, > This might be my personal preference, but I think it would be quicker to > review patches: [...] if they were squashed into one patch. [...] > the combined commit remains complete thought, i.e. for LoongArch > KLP builds, replace the arch's KBUILD_CFLAGS_KERNEL (dropping -fPIE and > -mdirect-extern-access) and add -fPIC via KCFLAGS instead. Makes sense. I'll squash patches 03 and 04 into a single patch and drop the forward/backward references from the commit message. > I'd also pull out the configuration checks into validate_config() to be > consistent: [...] > and then build_kernel() only needs to adjust the cmd / flags accordingly. Agreed. I'll move the CONFIG_RELOCATABLE / CONFIG_AS_HAS_EXPLICIT_RELOCS checks into validate_config() and leave build_kernel() to just set the flags. Thanks, George