From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 647F4407CFB for ; Fri, 10 Jul 2026 10:22:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783678932; cv=none; b=FTKlCHf+g2mivIDP8vK7BudYOzlAIDgPbOhSbHUEbuHR1FlbT8dM6XtH8DDARRZy9l2zLzwPThw+Clhti8920Q13KIEQG5Tl0LGZzWwmc97giMRsmYrRHPD1lu2b7i0h7rshZJUGqFfyv8tdJGLoFwICcxg0g7x+wMvArFHWWSs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783678932; c=relaxed/simple; bh=0A+xKWEJw2IA5pPYAvSYhbSRxxQoM65GpKdqqKapL+Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=seS3H+QN+/e87MJxHzLMrODr+HLvlH0MSBz9i2A128R6zFAntwh1vUtkj9uPgXnyPqjp+Lv2E9BlM6rf4QRRhuWr9GkGHCYfp2CsKseRIL+y0Fu/L6F7i6ZA0uZpKVJTapzFGPocSohJ8rj8AUcgDK8GhdN6vKOZW40FO3VGAEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SFXifyhN; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SFXifyhN" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-37df72c9984so1267375a91.3 for ; Fri, 10 Jul 2026 03:22:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783678930; x=1784283730; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Oh5hIJ+7O2JY7qrrtymOMkiruUIettb3qb3leyRUg7M=; b=SFXifyhNokJMKjkBNTnr0phEIpAVhD8blKsSrDwhwbmhi5c7aNwBMcmz6nZVJTw0qo tZI+v4Wimmd9EYVeN3/o+1/QJ7ZxO5m8w/hVSOidIpUz3SXfhbJQv955A2o8wzpvM006 XnFtW1ubkq6In3cas4f5pamVTqSkdXY0nNfzK6aluLJzB36wqmrKOkHVHCQsBGjGVW1J U/9+Untnzpkuhf0u6VFWc2/Z69HSNg9zvJLGge0fe2SIJ5+X8pdhcfJ2th2cbQm63BV2 sQH8RSlwfHOv8ms1QnfVJ9lEJOMzxJLDBcD/RyIFDTPWoGqNDrkcETOBJPmokslxIqgp H2EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783678930; x=1784283730; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Oh5hIJ+7O2JY7qrrtymOMkiruUIettb3qb3leyRUg7M=; b=RGzHS4CczN4D62GhZ06e39zlPFEnUJ3AzPHdW9cbjpPtsLcXzcCccLzgBuGTaW3+L+ yiqTQj58ZpPMUQY8T0g7sZ0axUT5rOZRMgcGDtMr/nmgizwYoHqp+p7P7iukc3fIRhUv QplV1SnfEGXAu/UC08yzp0wfLhr1O8QSFhtz6vXAkhQLLq4PBfHLmFl2LeiS7XZSRArV HWDDU48qUEemTv+nu7t4MFyK1r3wC7UYYIL4wbaMchfdTOHegT8iea7gwlyvU7h5G+Sg my/Xth93Ufs54/MzgwB+fGGoulv9zUmoRL1ndOk6zRjwHSIDRVGttVUZ1jp1PzTF9svz KuQQ== X-Forwarded-Encrypted: i=1; AHgh+RpRNsx0PehF9oE9+cprlrgv3ImEjZrCAlrJF3AWBkXSyVwpcRtT1gfXds0I8Gae0ptbsoy1VXvyjh6AOPs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5Ma0QfPlY2+Q5fFlWoV+R1HpAedhIIS7YLlyVTUkb3FkOBC0h 9XDdl/XD+zz0188Omnhi4309jLEOyH0G4X8xGJ7hENdMTiEEnx3rzt+v X-Gm-Gg: AfdE7cnIvA6g2jQDPCYieuEnxWulWNHKlm7frrQrmThmO3XIsUYwxaCJ8vAcBXz49am OWvX2FNubw11IdzWRhh9Ykj0D0sbVo+mUiZSb4sG7vl+VB7ywh/lmFDFMCRvD0XtNvbUS/H8Mlb R5MdYLlFRR2euXblYt5RhUivLcsVbjHOd/V1nxA0L5d1fQ4S+k2jjpPIUEXGW2ZX29MrxX1W8OL 6jCABmAf0xV0qfIxgLC2lQvbOl6+tN+5JdQcb+QtK8dMduibMfKmOVcoE0mG6gdEgtCkMAA6/l/ ARmSGQ8gmCE2O5/ifwwgpjqRQM6cqC1cJJc5B1zyIrcPfaBlWEVv/pBR4/LDiGkB26KaFF6RCQU NJ1ntcNhw5awL+WlxUabKCii0W81XKU+Uq006TRJvJAcl5pSFo4mtrAOcXs/fxpzWHq4ER1hR5Y GmFxeG5mfWc56TJR2SjTg/yvQmQcBIDNSuOIAjG0rOVfbsKLA= X-Received: by 2002:a17:90b:3b45:b0:380:71eb:4014 with SMTP id 98e67ed59e1d1-38940731d1bmr11115641a91.15.1783678929613; Fri, 10 Jul 2026 03:22:09 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38a5516abffsm2490240a91.4.2026.07.10.03.22.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 03:22:09 -0700 (PDT) From: phucduc.bui@gmail.com To: Vincenzo Frascino , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , Michal Simek Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH v2 3/3] ASoC: xilinx: xlnx_spdif: Use dev_err_probe() and drop redundant error handling Date: Fri, 10 Jul 2026 17:21:38 +0700 Message-ID: <20260710102138.29347-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260710102138.29347-1-phucduc.bui@gmail.com> References: <20260710102138.29347-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Use dev_err_probe() for probe error handling where appropriate to simplify the code and properly handle deferred probe. Also remove redundant error messages when the called helper already reports failures, returning the error directly to avoid duplicate logging. Signed-off-by: bui duc phuc --- Changes in v2: - Adjust line wrapping. sound/soc/xilinx/xlnx_spdif.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/sound/soc/xilinx/xlnx_spdif.c b/sound/soc/xilinx/xlnx_spdif.c index deb7225c1b4b..ae05818ba064 100644 --- a/sound/soc/xilinx/xlnx_spdif.c +++ b/sound/soc/xilinx/xlnx_spdif.c @@ -249,21 +249,18 @@ static int xlnx_spdif_probe(struct platform_device *pdev) return -ENOMEM; ctx->axi_clk = devm_clk_get_enabled(dev, "s_axi_aclk"); - if (IS_ERR(ctx->axi_clk)) { - ret = PTR_ERR(ctx->axi_clk); - dev_err(dev, "failed to get s_axi_aclk(%d)\n", ret); - return ret; - } + if (IS_ERR(ctx->axi_clk)) + return dev_err_probe(dev, PTR_ERR(ctx->axi_clk), + "failed to get s_axi_aclk\n"); ctx->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(ctx->base)) return PTR_ERR(ctx->base); ret = of_property_read_u32(node, "xlnx,spdif-mode", &ctx->mode); - if (ret < 0) { - dev_err(dev, "cannot get SPDIF mode\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "cannot get SPDIF mode\n"); + if (ctx->mode) { dai_drv = &xlnx_spdif_tx_dai; } else { @@ -282,19 +279,15 @@ static int xlnx_spdif_probe(struct platform_device *pdev) } ret = of_property_read_u32(node, "xlnx,aud_clk_i", &ctx->aclk); - if (ret < 0) { - dev_err(dev, "cannot get aud_clk_i value\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "cannot get aud_clk_i value\n"); dev_set_drvdata(dev, ctx); ret = devm_snd_soc_register_component(dev, &xlnx_spdif_component, dai_drv, 1); - if (ret) { - dev_err(dev, "SPDIF component registration failed\n"); + if (ret) return ret; - } writel(XSPDIF_SOFT_RESET_VALUE, ctx->base + XSPDIF_SOFT_RESET_REG); dev_info(dev, "%s DAI registered\n", dai_drv->name); -- 2.43.0