From: Pan Chuang <panchuang@vivo.com>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Tomeu Vizoso <tomeu@tomeuvizoso.net>,
Oded Gabbay <ogabbay@kernel.org>,
dri-devel@lists.freedesktop.org (open list:ARM ETHOS-U NPU
DRIVER), linux-kernel@vger.kernel.org (open list)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH 1/2] accel: ethosu: Remove redundant dev_err()
Date: Fri, 10 Jul 2026 18:59:35 +0800 [thread overview]
Message-ID: <20260710105937.409992-2-panchuang@vivo.com> (raw)
In-Reply-To: <20260710105937.409992-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/accel/ethosu/ethosu_job.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/accel/ethosu/ethosu_job.c b/drivers/accel/ethosu/ethosu_job.c
index 74f3493fb11a..cdc0d61ee53d 100644
--- a/drivers/accel/ethosu/ethosu_job.c
+++ b/drivers/accel/ethosu/ethosu_job.c
@@ -338,10 +338,8 @@ int ethosu_job_init(struct ethosu_device *edev)
ethosu_job_irq_handler_thread,
IRQF_SHARED, KBUILD_MODNAME,
edev);
- if (ret) {
- dev_err(dev, "failed to request irq\n");
+ if (ret)
return ret;
- }
edev->fence_context = dma_fence_context_alloc(1);
--
2.34.1
next prev parent reply other threads:[~2026-07-10 10:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 10:59 [PATCH 0/2] accel: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-10 10:59 ` Pan Chuang [this message]
2026-08-24 21:37 ` [PATCH 1/2] accel: ethosu: Remove redundant dev_err() Rob Herring
2026-07-10 10:59 ` [PATCH 2/2] accel: rocket: " Pan Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260710105937.409992-2-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=robh@kernel.org \
--cc=tomeu@tomeuvizoso.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox