From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f4.google.com (mail-pj2-f4.google.com [74.125.227.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6665B413D95 for ; Fri, 10 Jul 2026 11:15:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.132 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783682120; cv=none; b=a/N3wa7CYPaQIaX1knqPMM1PJoLzHm2Ozd78Ahm/TW+GXNF1AtR87ydZ06sW5NYIcc4vOZTra1G8I+YcBjgOFzZmMuKlZYdvMq5hZvTusTsdVOZpbgyD1nGBauMl8xqWCn3Ks/6fw/i79hTndeIIuNgz1oFb3wKNKh3F6QFMMtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783682120; c=relaxed/simple; bh=iMApwtVfAiHTe4uNdsg1pmRa4ajqzJGEhdVZ2CWz9x4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TEDdeMriNi/DHsZtLrtWpepgB0VYV2pe4G63gGWD/pzolL3gTdFHSG3aRxPLaUYf7Lt1y8VKcGj+CdvTiKJfxgnpKApTNqIHeng9csq32S+mUMfn5zRv2zyp/8JoRgVkEUPWlrVHfhNieT5709+cqFXR8CP2ChE+6aouNiZTXWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JDJhdfGQ; arc=none smtp.client-ip=74.125.227.132 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JDJhdfGQ" Received: by mail-pj2-f4.google.com with SMTP id 98e67ed59e1d1-381191ea2adso510423a91.1 for ; Fri, 10 Jul 2026 04:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783682118; x=1784286918; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iMApwtVfAiHTe4uNdsg1pmRa4ajqzJGEhdVZ2CWz9x4=; b=JDJhdfGQBxUjA9GI4ZgYxiUIICZlQpVTC4FsBPmBPZ3PnvRPEw+Qw1Iti9RG4Q7I5O KgMN3Me9pVgYN3b9olAQdOj+2oBLSf4d2IL8mHX4+k6q3QFsWA3C3MgMCjrpQOjkExMH CA+0ExaAhBP3cKnZ1GXeZoasW13st+nkK8AO5In0SP9kEA4iXU/ih79p8iGVHo1BC/cZ arTg68yQf6wuOPozjCz1FO6ZSEKuoud0ZSV903WnuajC9+Dwc7XSlkq1rfFSdaUQ0KeX Z/ZQznnAkFLOhlt5PfZ3sJBTQGTxn8yoznjBbaR8BdVLD0fUo+LuxYYFvN3f3YFcoowL PBtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783682118; x=1784286918; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=iMApwtVfAiHTe4uNdsg1pmRa4ajqzJGEhdVZ2CWz9x4=; b=fC2TtGUnutusgfu8AzcOxBpfz4xYNN9c+OgvmqZjr8RUxv0owY7X5u6AR7zgNMkP2U 9po//Oe9gqOYGu9d2J4yxySsrAsAZrfAC3Yfl+JbNkrX7fuOpIxzW3tMhBkU/fQu/311 YA0BI+haG6yHVKIOGqP6FpWcCcDaZ4CM0zdi5PO3DIEm+8xtZBd9DH68P4SuAT37LHXr V4HtGSsGUYiQlHDgvjZmyZKXmoZAfPS2dOnW3twZjI4z3ViV3bIVhw8f5hmrGBOgcv/G kuedQRy82arBwIY9GTSHYT+hnjrzXa2K6cNRZ5N7EV9EYK8R/8hAUYJnX5keaLR8jg03 EVIA== X-Forwarded-Encrypted: i=1; AHgh+Rp+JIzXlaZbU2GGCS2cZGFz0cNqak1ZqMcawywqH1dVtWqoqmbUdLy48yAzrgUc9yQgV7e1GdzbKnfGqY4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx91IQ/o6kwcDCsHtBO6pyalNBWt3OZycj5Oqbf06QVSszVX/bK HV1wFrgw7zYQDUa8u6xMiCOrR5EPcw41KTCP2AuUlAVvJkAPEhkSofbT X-Gm-Gg: AfdE7cnvyjG2lc4Rz4dg8AjB+DEsD28EcrHYmXhEaUnkOLX4bMOzAH6LC3f50xrawb5 OrruOpol1nQWEpp2lW7hx+LT4HwBbgP+NmN8XPiLINT8iVrBxBWyOqQxQRQ7Ak1Bn0j3UEngggf MoMe3JiCiXiI+PRxcwmqgHEFM7/4LqPWccgj4R6xukQ3+Gy6w+gq1cNjI1CPPkoVwO92XfKRm9D P8JUsNHqRIm1dqEkims0BAliJnFKxxbz6VjYZWijd8YhRLNIUTggd7Gu2sw2vuGPu1m/qJbSsdS oueW+YeRbZjOkGlaH39IW2mXH8YWFyawcf6cPargG4S1XuocRN68scS+JH0RQ+jJss9tQ/NvE28 DLAdyXaJ9HbOdWVnSOVAS46Gqe5j4vpjGLfh57OZudaN41IV22p3WwOkqDX9Cm6tex+PLlx1c9K B9O4kqaiJNFC2bM5+deCKOf4AJVohALJ25maDLquIaB64l3mtncH4/RGrH+5D8YDYtXcy9md8= X-Received: by 2002:a17:90b:37cc:b0:387:e0cb:7f5 with SMTP id 98e67ed59e1d1-3894298482bmr11227568a91.41.1783682117496; Fri, 10 Jul 2026 04:15:17 -0700 (PDT) Received: from ubuntu-gnu-linux-24-04-3.hub ([2407:7000:af23:3e00:eb86:437c:263f:195f]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38a5622ae99sm2576177a91.14.2026.07.10.04.15.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 04:15:16 -0700 (PDT) From: Jiaxing Hu To: Will Deacon Cc: Heiko Stuebner , Joerg Roedel , Robin Murphy , iommu@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/rockchip: implement .flush_iotlb_all Date: Fri, 10 Jul 2026 23:15:08 +1200 Message-ID: <20260710111508.917486-1-huhuvmb88@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260710060513.863714-1-huhuvmb88@gmail.com> References: <20260710060513.863714-1-huhuvmb88@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Fri, 10 Jul 2026, Will Deacon wrote: > So I think this is the wrong direction. We should try harder to remove > the function rather than add new implementations of it. I'm assuming > you're only adding it for some out-of-tree code that calls it? Yes, that's right. The only caller is the out-of-tree RK3576 NPU (accel/rocket) bring-up I mentioned in the commit message. There's no in-tree rk_iommu user, since the in-tree consumers all invalidate through .unmap and none of them call iommu_flush_iotlb_all(). So if the plan is to remove the function rather than add new implementations of it, then I've got this backwards. Please drop the patch. If the NPU driver ever goes upstream I'll make it stop relying on iommu_flush_iotlb_all() rather than bring this one back. Thanks for taking a look, and for the pointers to those two commits. Jiaxing