From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1716D41B346 for ; Fri, 10 Jul 2026 11:36:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783683390; cv=none; b=susn3tcXWq+RVgrYPFPWd/w9EUVtfsTyYL+os47zOSObIUfoNawdTeig9EtQtLgP7EbVpEfW/GOhufhF0M1TZSQXIbZqWqBgwev1dyoDc3Vj4Z+e6FlXxbURT+OAH59u8eErz1vqLK97ngEcqFAw5xgm4hue0+7ZCu9DTBB5F9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783683390; c=relaxed/simple; bh=7OLa5VSZga3c7xHtQ7LDudELJy00EvKKS9zK5/3jRY0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TO3L5GtCqzflhuBUc5ecE3tl2V9ydRJ4yc9hYmwfbt/5gQs/VyzJxRyXE0alich/opg8hZUmXj8VayUfHx7r8+/VeEL0FmgLxBP/Lc46i2a6WmiyI0Trdsq5/mdkz1atExUKU1sGMx207CZGt3yAP7MVZgvAxVgEcd/vdvPDLZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dHy8zXyl; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dHy8zXyl" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4938d5f86f3so5711365e9.1 for ; Fri, 10 Jul 2026 04:36:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783683370; x=1784288170; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=S3vn/hujzrD+r1/zdSZb7/P6FDyllIFs8N7tqn2TGCg=; b=dHy8zXylx44vVRwGd3ioJUsQ68I9HPhK/Wcepgx7Y1wbQbVDt+Bn8GmBvarNp5ZAKC yLFW5pREbp3UH60Iu2PGB3DPjnIYSo/1Ku1ARmDCDcCVQdO90vRpBh0dPEPoZdh7Eixw LJnkxza7nJidLfB771O9vcmbeKMJiJMlFt+3N0zAC+bsYCxNcbBsHDEz3r3MFAAmiB0U gX1mDGYdCj70hwcus4hqtngzSZeUFZNZuOb/gIJto5/9vd7FF39xVvda6yOBvK7xadkN dmudSoxeY7tfFdWlA2PZyWx2I9HqAVSVm2s+0I7/GSGS5Sigh4lyILa1ls6FEPBBnX/A SuTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783683370; x=1784288170; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=S3vn/hujzrD+r1/zdSZb7/P6FDyllIFs8N7tqn2TGCg=; b=JoYf4Vq1ADQYKW8ouhLoR8NpMvpm95CetvQyZEDsLMOQgReay/hFLheiRwCdJPP1Z4 b4Ui7M62vQwFrP0dxAb7d63C/vQakBPPkeKTo5NJQjtPFZ8U0qiaYgDi7dz/lzL12osN ALg+GFA7LJsinoW8aG3kkIbx68GnPd9ecLDivn0wT+jkGIzAOGtUgcth9VqfE6cyy0NU gtUJ4elUefhAy8LWxO+dLJEbv/4uCW1KUY72QDd7iK6UM5MUikaxvvaC9c2N65Q0mrOy QRng2Kduv5Qy6pbC3rzmXsDgojlpqFAL8x0Vj/hHR8dbfO9HHs2+jXuhOERlYsN5StDY hQew== X-Forwarded-Encrypted: i=1; AHgh+RqbixQC1JwdB515TkVSnyo36EqQ6Ryg2B/YRCAHM8Ib2fXndPKvOzYjoERsg8hoM1+mYWzawi+aK3QWpAY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzhbr1rpo7WZoUdBltHH5fQz7BBhcp4fXoB/LwByrE1rj5Z/y/3 d6ijA29ZDmAqUozRmvxNpN2oKMcKXpk+fDxxopPS2haIx+um2f++oCzh X-Gm-Gg: AfdE7cnmlvaELtHVZ0Cq/DgN/I2FMN9hNHXRyAmBSLA1wcRrQWtLD/cZNeCd9vINHld SMHjY2JFYBNne7iz7DeNYL8pAhZ3d/8EHQbR77SL4TVUXBhWQOjy/Q7GhLkRCM0zc5wT1PiGbAS gNoUJtxOK2qg3VwEd4WKz8GGJu81eiPo1CIiLJ/HMDKT9ehibBgdgcEXwq4WRFsoLXO8zunJ7/6 EHWDOUf+u9uBAikFyKZqMjN0IRNb46SxLgHjSNJDw6la89oEFcvpvxwK3Xjt7i3KIrjHttWXAS1 GJxeXgf2ufdcryAs7nij5TU9ZP9V4+gicvEjzZ86cbaEj+iCr9emqwOPd/SNMkaiARFoDp3rIEs XC0ZYB9T2pNDLbREE+czwyqoZhC3WERBWdJm9kFRqfWwP9vRjaXrVeZc4e0WZJBaz0MJq4cSoZt kSFtJfsIBOOe6EHWd1Wcdu1l4Wsh0LcNrwTtDpH0msxfktu6y/ZB8GS0sPbeC2NNpBZkM= X-Received: by 2002:a05:600c:8119:b0:493:ee34:d875 with SMTP id 5b1f17b1804b1-493f2b3369fmr30839765e9.10.1783683369863; Fri, 10 Jul 2026 04:36:09 -0700 (PDT) Received: from fedora ([196.121.194.252]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493f2e77c2esm37069885e9.2.2026.07.10.04.36.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 04:36:09 -0700 (PDT) From: Jad Keskes To: Borislav Petkov , Tony Luck Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Jad Keskes Subject: [PATCH v2 1/2] EDAC/device_sysfs: Reject poll_msec value 0 Date: Fri, 10 Jul 2026 12:35:47 +0100 Message-ID: <20260710113548.46266-1-inasj268@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The poll_msec store allows writing 0, which sets the workqueue delay to 0 jiffies. This causes the poll work to spin without any delay, consuming 100% CPU on the polling kworker. The comment has said "must be at least one millisecond" since the file was first added, but no validation was ever enforced. Add a check for value < 1 and return -EINVAL. Fixes: e27e3dac6517 ("drivers/edac: add edac_device class") Signed-off-by: Jad Keskes --- drivers/edac/edac_device_sysfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/edac/edac_device_sysfs.c b/drivers/edac/edac_device_sysfs.c index b1c2717cd023..89adfd3091e0 100644 --- a/drivers/edac/edac_device_sysfs.c +++ b/drivers/edac/edac_device_sysfs.c @@ -96,6 +96,9 @@ static ssize_t edac_device_ctl_poll_msec_store(struct edac_device_ctl_info * and set a new one. */ value = simple_strtoul(data, NULL, 0); + if (value < 1) + return -EINVAL; + edac_device_reset_delay_period(ctl_info, value); return count; -- 2.55.0