From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED42E362133 for ; Fri, 10 Jul 2026 18:45:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783709102; cv=none; b=eJ4bpsr6lKFJ3xzRq9Bbl7s38paQf7dKLrebRfPx5kQ804JNvlIu4roYhXg43yg8XcPjbzLDbAJvG8zuV8EWE5zRRtPtlRNstPQEnOUAGTQKgwgaG++F7tuFn9jrgQ+JVTQHVFwOEsSDJ/YDxomI5LVkMPU5c5OHZHSgNhlqlYg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783709102; c=relaxed/simple; bh=OWVcBh/B5Q/OzHFhu50NkXsCby3kerKmG8ulK33TFAw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nwrZrptnbG2GkbdNOiqnkCyBQRCXms+yIEFuiYRsoMqogveOyd4xTC3qqKt6PcO4rf+bx/xD2XNhq525l89bLc+oEBgvAvtIwu42hHGj7Te/JW2sK80BXquVZchvQSK3mSFZAryTVtFiA1IrtOQkvP3eWZeIaZ/TaS9ndWtBBX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BXWcv9yQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZHWmkgtx; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BXWcv9yQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZHWmkgtx" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66AH3WdY1501987 for ; Fri, 10 Jul 2026 18:45:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= z+OQYxq6XVFtfTI3prmJj4k7rM7HASfxezwfOnaXnKk=; b=BXWcv9yQghXGUJfj LUV2tpUDR3QUfh2xA1u1WPeXoFSPEAHPahLalkdhVL3d0T/nf35q6NIrDiVpF/Io BghSi5DR4tY8YZpn0rRG+fRhvlegUAnjnxalh9gb+Tq4zgQKbfGNs0/EB1RqwsaU htbPGrxuKYcwEcRgx1jDHeeZ1cSMlGU1uoLx3w6iuMFLqRmCtoKKKl2V1qD6fUCB pORU+v2AjJridYsot+TVZgFFIyr9Zk367qi57IaZvC5oy0UZQVB8DjX4lrLfjbET VxGcVM+il5+j+IvoiUtxfXnQe8RbhNwmSMd+Y15LCQa4ewlu6719sUrfmooLaUKU 7yyVxw== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fb3xvrj8b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 18:45:00 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-848693daa20so82720b3a.3 for ; Fri, 10 Jul 2026 11:45:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783709100; x=1784313900; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=z+OQYxq6XVFtfTI3prmJj4k7rM7HASfxezwfOnaXnKk=; b=ZHWmkgtxY2gQbalb1JYcYNiY/W2LU6S21ydGuxS6wgOnBSoKUS0gg1qRC59IMITYgq ZCt6bxz10ovIT5fDodJvYgZPn3FYJE8xTm5zy8hBe54HiShzFogHRp93l839s5eSeLfL MEsDhI+RTPhSxwaC7fyD4NtIirFNNbP8rBGt01oWeHurigiRf8R8f97Ulab9acNl2aiD XSmO5rkiJk2N1WEKyKW0NPJK/xH1KlkJrhLYPlDeA2Vv2X6Q5yqAeg+Tk24VHdOOR3s4 ZWz1wTbzJNMnKSX+c4oqpbFFWjPc8HheoB7UbskF5wEtiwRptYfpyJKrP6VEyqoKO8/k mXHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783709100; x=1784313900; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=z+OQYxq6XVFtfTI3prmJj4k7rM7HASfxezwfOnaXnKk=; b=qBii0fCnqHpmjgtFkhmlZy+HeP/UOlH8lI4sgv+rWJDzCCxw82HmZhttU0T2uo/QP2 YCDHcLpGpVLEgbZkLMT+8tciVlBXpnw9lUrXAtDjBVa84rhfdKbKxe4wJNf06ky9nBiC 8sBKdDsokuY4xWFuSzQLCfEFfxmh9n8WH+ZeidygCFCzsnaxSYcb46D7lrEJGyQtySDp M21qkoRcGuRv5MswYlq2dhe1GYdUWSxqlF8vbKLFWGMwPvT78sQMayGfstT1u0mcqc5n DeeSe8LzrQcrY3MzCz2wdd1fLRN+8nX534D6jUZcWHFcSjDripsPSQAd1h3PflSBTEOs mTdA== X-Forwarded-Encrypted: i=1; AHgh+Roa0FIGCdG7OLm67dNW7cu+fyeyMMrWT8FUaNqFQRTS7xYmbz/q23to+/7b1m3VuyE+mOe0KKWve1157i0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+t5+7vfSiHBb7bLY+jXiPZI1cxzb/TjsLwjVDXDnSzShO+5LY MOjQUSUr0FGk29x6KdqNm7TBvi0XJXItfwZp17mdmlYdbKc2TXfg/9UoMLHXrENs1LjAtelDD9e dSrS5CsirJSVxvfJxNJ9hojaxqiZ/NX/5qx0vyBS/o1LFyRheHxvdwNoXYT8KBBBVCbk= X-Gm-Gg: AfdE7cmK4RG9TZUgGk5clBwDpgYdk14MrO7JcwBRyl07xC5AqdPOXkt7g+sqpuR+HE3 OnYLtadVZBf5F9KC+6QnbakUySWSQ7wBiwfirqNMiRmK/mPCmW6lp6w6uvguctO0a+vb0hSoCfl qrTWRw3pmGW8c4kAqA5GEslB76rEozC8DYfZd0Wuloet6J+K8/YogvYEK+MVmPNnft0eTt3CWoI oWLowUafK8TgU7v/CngTfLoyRBtxsdLobTIbMn7XBlfe2KgjFs8qPb8lzksnEU66qbt62NVlaAb Fa+GlYwIZ6WFoaDSt6pm2BXqnBXh5Xhu432jrVTvmR+Wll3VXVaNVzlvInojTZMd9DvcbG2v+lS N3dvZQ24LbOglbyWUKZoz0rhap9oMWJdfm/M7 X-Received: by 2002:a05:6a20:3d0c:b0:3c0:9c1b:d0be with SMTP id adf61e73a8af0-3c110a24bb4mr244273637.73.1783709099616; Fri, 10 Jul 2026 11:44:59 -0700 (PDT) X-Received: by 2002:a05:6a20:3d0c:b0:3c0:9c1b:d0be with SMTP id adf61e73a8af0-3c110a24bb4mr244236637.73.1783709099235; Fri, 10 Jul 2026 11:44:59 -0700 (PDT) Received: from localhost ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31189cd8234sm33343564eec.9.2026.07.10.11.44.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 11:44:58 -0700 (PDT) Date: Fri, 10 Jul 2026 11:44:54 -0700 From: Jonathan Cameron To: Andre Przywara Cc: Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Len Brown , James Morse , Ben Horgan , Reinette Chatre , Fenghua Yu , Jonathan Cameron , Srivathsa L Rao , Ganapatrao Kulkarni , Trilok Soni , Srinivas Ramana , Niyas Sait , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 05/16] arm_mpam: propagate MSC read errors for msmon helpers Message-ID: <20260710114454.00003aa9@oss.qualcomm.com> In-Reply-To: <20260710144520.917375-6-andre.przywara@arm.com> References: <20260710144520.917375-1-andre.przywara@arm.com> <20260710144520.917375-6-andre.przywara@arm.com> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: spGWu_OmQTLqWOy7A-_EjW2JKZo8TWiK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDE4OCBTYWx0ZWRfX2Nz+dCCmxWHQ QA46bALlMLO0h6pQWa2dU2TnR3q//NkN2/oDCYpPdwRUNVcIPI4wgM6Hmy8LX0MUBOPde2hqPEV wqJI4om49NR9AufJMUmrrkYgD95ZQmJlB4MT01jxOdJYwNHvLngR1Y0P0/pRu4bAXcVlwtiXW9V 8rqJCusJTVuEOWfFG+G94fx5D9KzMcLVBfSh9RTEUH4Mre35HO43aoqpB33npjgGpZ0fGF3qyr3 UO7Vp5MJQZlCTgq5O5d5MMCb9KdXNMaiLETvkZnLrUtTcuVMIUb5JGPNsHtfNBBfMZTXKF1mDVw oKf8FiR9Um5fL+lSEfDFBzyM7nDzr3TWoF2VsPDbZR1wRJxc4mgZwKHE61qpXizO3ksMbj1omCW RpOkF8hLIDl44HWJjrbtY/291dEv+VNGLTkQSphZteN0SfldQxmFzbZGB3b5mbt56Z10TsU6n0j OQSYuWc/QH/T3/OyE3A== X-Proofpoint-GUID: spGWu_OmQTLqWOy7A-_EjW2JKZo8TWiK X-Authority-Analysis: v=2.4 cv=HInz0Itv c=1 sm=1 tr=0 ts=6a513dac cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=7CQSdrXTAAAA:8 a=gC5c3gsx8QPM0zVGbwkA:9 a=CjuIK1q_8ugA:10 a=OpyuDcXvxspvyRM73sMx:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDE4OCBTYWx0ZWRfX79qkeM5T1bEt dQDODD5Vjbq4B9vAR66hiZ45vbObGloqmKUaZKVDGS7XBBZ0dHZuJakCyePyRSvuy6ox+xlzXlN 2502t2aTZF4HpeFBAwBJhPZ/JJRV+LQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_05,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 clxscore=1015 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100188 On Fri, 10 Jul 2026 16:45:09 +0200 Andre Przywara wrote: > Allow the helper functions for msmon accesses to return an error, and > propagate read errors from the lower level up. > > Signed-off-by: Andre Przywara Hi Andre, Trivial style suggestions. I'm fussy - I read a lot of code ;) Jonathan > --- > drivers/resctrl/mpam_devices.c | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c > index 3b6f9e552a9f..041fca018e68 100644 > --- a/drivers/resctrl/mpam_devices.c > +++ b/drivers/resctrl/mpam_devices.c > @@ -1201,25 +1201,31 @@ static void gen_msmon_ctl_flt_vals(struct mon_read *m, u32 *ctl_val, > } > } > > -static void read_msmon_ctl_flt_vals(struct mon_read *m, u32 *ctl_val, > - u32 *flt_val) > +static int read_msmon_ctl_flt_vals(struct mon_read *m, u32 *ctl_val, > + u32 *flt_val) > { > struct mpam_msc *msc = m->ris->vmsc->msc; > + int ret; > > switch (m->type) { > case mpam_feat_msmon_csu: > - mpam_read_monsel_reg(msc, CFG_CSU_CTL, ctl_val); > - mpam_read_monsel_reg(msc, CFG_CSU_FLT, flt_val); > + ret = mpam_read_monsel_reg(msc, CFG_CSU_CTL, ctl_val); > + if (!ret) > + ret = mpam_read_monsel_reg(msc, CFG_CSU_FLT, flt_val); Burn a few lines to make this flow absolutely standard with errors as the out of line sections. Obviously it is a minor thing but the more standard code is, the easier it is to review, ret = mpam_read_monsel_reg(msc, CFG_CSU_CTL, ctl_val); if (ret) return ret; return mpam_read_monsel_reg(msc, CFG_CS_FLT, flt_val); > break; > case mpam_feat_msmon_mbwu_31counter: > case mpam_feat_msmon_mbwu_44counter: > case mpam_feat_msmon_mbwu_63counter: > - mpam_read_monsel_reg(msc, CFG_MBWU_CTL, ctl_val); > - mpam_read_monsel_reg(msc, CFG_MBWU_FLT, flt_val); > + ret = mpam_read_monsel_reg(msc, CFG_MBWU_CTL, ctl_val); > + if (!ret) > + ret = mpam_read_monsel_reg(msc, CFG_MBWU_FLT, flt_val); Same for this one. > break; > default: > pr_warn("Unexpected monitor type %d\n", m->type); > + return -EINVAL; > } > + > + return ret; With returns above, this can go. > } > > /* Remove values set by the hardware to prevent apparent mismatches. */