From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 859EA3F823E for ; Fri, 10 Jul 2026 12:32:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783686769; cv=none; b=I8RbDw603HPKXWPJRZGQNBQwA+YERZpvtjLIERhrvYCrHXzfmaeCdMjUP86nsitfJgaIRxgfb3V/cpQm/zxZmep/UF73xmSzO3KPnrZ5PloFZ354nOdGk20Z3SYBRMN2aTIbAumcFyDqSEWfMweJERrOVFvqVfWn6Uo+QuMu530= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783686769; c=relaxed/simple; bh=yn/OWPMkK8tR6APkGlapqLRo2TERIGRqc8UVfF9+/Cc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FYl66gzkT8irxOdJ8HWkRzvrcdB5taKS5wldHKn2aH9I1x2WLt1QMmyq7VCwwYxIlt9EqCjGCA2uvVDSZ37JHtaSD1FaN2pIm+C39iBNN6Oyuaf7bQKkRG5ty8gCJc30QHzxfvy6MJZ1vfw7Mv6vyKXd4ORz1BgKmENb/610z1Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-8485b358552so892187b3a.2 for ; Fri, 10 Jul 2026 05:32:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783686765; x=1784291565; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=HIq1CvwVZbx9/5QAPVeHeQOM9JIh/J6rwMjIo/6qFcQ=; b=XhokixKXkr/4BEHZjouvI2k25EfXHyM83E0eN47YOdPqptISL6LjEpG/DlbRAL5EI/ y3VZlXqURmmk9/z9StCDPG5bFMpNpOs5ZvMsDtfKcBDeVE+opnxjDuJnzHGnXNJdfQ// SiWngylHCKodSJwvfz3y9mKVN4+dwbffXvnkG65DBrFnOPVxyTFnggTtHFMcpUhRgcZY g6d2YiiMRkVgGrnsqaIkX6zC5c+Z0rZoiepKCiGpnIgaCUGnB4o3xU71V4WVYalmu3mG WQPltuXdC8xaOjx8ShUZD0ZD/l39oqxsvbva4yVtKHp6Pbya32q82LC13fv0Z832BGeL 5Oog== X-Forwarded-Encrypted: i=1; AHgh+Ro7ev66xYum28Gssn55juE5jZt2qnijgYQjlQBHebLSY0N5u8fsLZjSq0MFXTcyGyVoHKGTqiccQOlod3Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwPQpeYr9+OqCwXi8HRzSt56rxI2TwEVP7MnbF56W+mdYqPrP87 EuXsqdeUprWKvtXjee+zeUqW3L1ZmAU3WiVUzh+Y8sDdkR1H4GImqhcO2EMpFko= X-Gm-Gg: AfdE7clk9u/Yt86Opx9cUW4D5//Nd5Knr45Ilf14R5wJVsODLvkiW1erFXyperMSrfQ jLCCDd5ghu86MN2WOgNZJlmN9aGQNIbsU3MquHiRbrbgSs0ucygglVHfZFWxt8Cs5/pweL5By3E TJuLecLpo22mjjYxOMvE/JeLmbNU6gztd5zwuc7XI+o9jqTiCYFSd7w6GJ4cFTtROK3s1hzXYbs 9g05nvuhM+i6dwaWhVi1bvmnKJgV/Xz2uzm5WXrvnzHUBshnmRgDKReZbS6FuI4DwHY9tPIBG6J PJSA9OxhZ08pzN6Pjvb6rmm63D3+E/XsXcBnVjcXmh7G2UbVhWBVE1QCF/IRR8AFJS8yjPfSyNl 3koW6SkawqKypnObqp/v4GHU8XMHX2Y/nHMxOfEnPTnwIz/xykiVuvoKCXJLuuT6HEfaCPhN4xT IIOaioSapIjjYRUdsQ+2pXxhzy5YgZjLe2qKqGVpJm6niq9fOqW7iKWU/FSNQ46+ryfMKVmo4bR bHFzkXTU5fZo/Mpxk9s07b/cw== X-Received: by 2002:a05:6a00:a889:b0:848:2f84:734 with SMTP id d2e1a72fcca58-848430404f3mr12130220b3a.71.1783686764638; Fri, 10 Jul 2026 05:32:44 -0700 (PDT) Received: from penguin.tail0a1999.ts.net (61-228-54-80.dynamic-ip.hinet.net. [61.228.54.80]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-848686d6e86sm1929058b3a.19.2026.07.10.05.32.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 05:32:43 -0700 (PDT) From: Shih-Yuan Lee To: Henrik Rydberg , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Shih-Yuan Lee Subject: [PATCH 1/1] hwmon: (applesmc) Convert to hwmon_device_register_with_info Date: Fri, 10 Jul 2026 20:32:36 +0800 Message-Id: <20260710123236.10508-2-fourdollars@debian.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260710123236.10508-1-fourdollars@debian.org> References: <20260710123236.10508-1-fourdollars@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The legacy hwmon_device_register() function is deprecated and triggers a warning in dmesg during driver initialization: [ 24.706091] applesmc: key=620 fan=0 temp=37 index=36 acc=0 lux=2 kbd=0 [ 24.706270] applesmc applesmc.768: hwmon_device_register() is deprecated. Please convert the driver to use hwmon_device_register_with_info(). To silence this warning, convert the driver to use the modern hwmon_device_register_with_info() API. Because the driver creates all its sysfs attributes dynamically on the platform device, we define a minimal struct hwmon_chip_info with a single temperature channel and implement a visibility callback that returns 0 (hidden) for it. This satisfies the new API requirements while keeping all existing sysfs paths and attributes completely unchanged, ensuring backwards compatibility. Signed-off-by: Shih-Yuan Lee --- drivers/hwmon/applesmc.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c index 90a14a7f2c4c..2b10bef24d8d 100644 --- a/drivers/hwmon/applesmc.c +++ b/drivers/hwmon/applesmc.c @@ -1307,6 +1307,26 @@ static const struct dmi_system_id applesmc_whitelist[] __initconst = { }; MODULE_DEVICE_TABLE(dmi, applesmc_whitelist); +static umode_t applesmc_is_visible(const void *data, enum hwmon_sensor_types type, + u32 attr, int channel) +{ + return 0; +} + +static const struct hwmon_ops applesmc_hwmon_ops = { + .is_visible = applesmc_is_visible, +}; + +static const struct hwmon_channel_info * const applesmc_info[] = { + HWMON_CHANNEL_INFO(temp, HWMON_T_INPUT), + NULL +}; + +static const struct hwmon_chip_info applesmc_chip_info = { + .ops = &applesmc_hwmon_ops, + .info = applesmc_info, +}; + static int __init applesmc_init(void) { int ret; @@ -1363,7 +1383,8 @@ static int __init applesmc_init(void) if (ret) goto out_light_sysfs; - hwmon_dev = hwmon_device_register(&pdev->dev); + hwmon_dev = hwmon_device_register_with_info(&pdev->dev, "applesmc", NULL, + &applesmc_chip_info, NULL); if (IS_ERR(hwmon_dev)) { ret = PTR_ERR(hwmon_dev); goto out_light_ledclass; -- 2.39.5