From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86E66391517 for ; Fri, 10 Jul 2026 20:21:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783714918; cv=none; b=JRRnR2TwCQcuDifZ3DkgGhPtey9rcw+/duQqifAV5K9Qy8Vdw0cTcD1llNyvxldWlfDGuo3SGjIJktqrB3oWp0dqm93MSrTasxXid0orKOGEyRAf9pbxUdGgG661RyyBVmxK6B3Kg1oNqGQAhXGQpHXwIkB4oa179yL5v7g8st0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783714918; c=relaxed/simple; bh=mwmcHxrVR+kz/WQi8iOjtcMfnkGRz+vLnMOAEhzR2Uo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=e4yOqf7iWQNj72cxN5XSro71czYSpKvVjioTSyvzMmIEE0IvlUTXRPoUSR/DPJ7hR/iK+3mLQOrt9Ntw4jgbbE3YL6sQQl4JWYIaPl8b689/EeVCR4yAFNuZxG7Vox9LdLH7ve9Q1UqKYMYyvV1HoHnVlg/P6WvzHt4SRla/cGc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RRaayQZ5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CeNYHzfd; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RRaayQZ5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CeNYHzfd" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66AK3Hdj1841696 for ; Fri, 10 Jul 2026 20:21:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= f5MBPQjfTBEuM72l/dKsAgwUJbCHso/oUhnZImxy64I=; b=RRaayQZ5SX846iDI LV0P5ysidPkoDfl8AHncZ6zLIPkh8pIQNfFx5uEucad6t39P5//Q+Gk2+jHRaVbH vPJR716lgEY+dOIiWziGWqwrLNCK8L6hBC6ruKLTSK0AjI1Mv1Q1cuRK+pxqxEFN lWpt+iKZ9gCqiEFVaDNLPWFRBiF49NnLInuaOBZnYsRSaw7O1TA44y3kO3GoXYeX eL+OuWAEjjlYg7eIasHjLOLjoHXSJ/OK+hjSshOCEaBx8nWwMAeGP7mvjeTJ101X Yel0bA/vddguKGpWA2Gf+5yGiFeuWSZLmQwZUDgdlYivwuVxDIXErTQSnXpSr7x1 5gRxIg== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fb3xn0ux3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 20:21:56 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c88fc985a65so2247205a12.2 for ; Fri, 10 Jul 2026 13:21:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783714916; x=1784319716; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=f5MBPQjfTBEuM72l/dKsAgwUJbCHso/oUhnZImxy64I=; b=CeNYHzfdzWxuUc4MPdpJOr/C+st3TfiYb+DNvAH4GAWewpJTyeypDAavZqt4bB5fvb HFCNENNJBa1Qh771iSBzRylkFeUyXMraUMUX8CBg/O0Lefwks8Vfn6SQzR45+6sz27XO rZHWpcpxOxtM4h0XHUmxoyFBalMiQta78MdNnu1eDLgMB+Hvzq63yucGKWokMxWLVMJQ irVX3bk5Gj6B64SM+eqc1s3M/4GKV1/DtUp7Dffy+U59mrrejbIBYqIzrNwwaDE6X6+b M7lS0Kasgfg4ihPAabuRTKeY54wyfy7VOToq/blYD/iz8JP05VkRnI+RyqfzQ6NFwuZ+ LSwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783714916; x=1784319716; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=f5MBPQjfTBEuM72l/dKsAgwUJbCHso/oUhnZImxy64I=; b=IwaSZhxxqb84LzM/qx/lBvDlSoDefIaH7+l+BBync0kZkR45UKTazG4mNkAA9X9l8l X4ZkcElnd5zhC/YHS0MXwYWKqR6aDua8AvWQEvQ+3jWGk2Hh/mJvxZ16yFUcWFx4j4b+ gCpx5HqOvCDzX7C2RpXaERvjEpGodHV5bRH7qaPhMgHx3xNFkxkKioWTklrAkuccFq0A AYS1zDm0fK+sGL17+CwxjDxoSCjy6nYsqj4Y5r+r1TsLUppBM753Us8aiDMqgMk4NOh5 6uM8pNBETF0KM8SXLtypdJWC3i9+R/PAe7dSf17HZ1o/7zIAlePNdQufGqp+Xmm2GjMz l81w== X-Forwarded-Encrypted: i=1; AHgh+RqSOAJ7JuR3gFPYNSZgqnj1Msw6kMwSA3bL1j1iONV91xn/odiY5Xw0hr2m5B1MoT2zrlh0vUpZX0soGfY=@vger.kernel.org X-Gm-Message-State: AOJu0YyABW678MWp05cDoyHpuZ4a3aQn3om8yeuOIAWgkZZcwJE/mRwP dZlSdzHZVwSOS5qsbJShEgZIaONewb1VBY6sT8A602aZD8Up9vUZBLo2lqjxfti6fMyDLdCP31/ mz4t/co60OrBYbS0xEc3MAACrL1X5ECpdj5qT+857K/llBtvxL0D2ufSORBmJvzhYLgY= X-Gm-Gg: AfdE7ckKKJ56Mv1uqneNEaPvXALCZyZKxc1iO2Vj2TwxqD4iURvyut9t9qIhyCeB0Az 9EzUlir6qEDHc+xqu22ujyOx5rAiAGOLuW//IoE7odZISTM9WlIrqaSxxPIQh6Uk3+CZcAwk2UX SEONzixwTtm57zGMWWQNX5X2FWnnMN8NBxM5XaA8KeQ14BP8kHSXpXVTxFZitdOoBK6g1IZ5gci qgIARmnm7I4N4wvWrCNWB2HOdGopuXqiLCjFk6Z61Y90XWKqzpFjE5wE9cLEfmkVDoTLyTmToU+ xv7eFAwg8wqxRKwT5qI23MAgNo3tiR3hyXFTIhmShzIdn5JpqcU4ZIfxmTOjibc3ubgdjXDdjnk YkKLDhj8+G3kN6TnHIu/wAo5nXe8PSouBZv0N X-Received: by 2002:a05:6a21:e083:b0:3bf:7fa5:8922 with SMTP id adf61e73a8af0-3c1100092dfmr545787637.2.1783714916050; Fri, 10 Jul 2026 13:21:56 -0700 (PDT) X-Received: by 2002:a05:6a21:e083:b0:3bf:7fa5:8922 with SMTP id adf61e73a8af0-3c1100092dfmr545761637.2.1783714915523; Fri, 10 Jul 2026 13:21:55 -0700 (PDT) Received: from localhost ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b658a99afsm41399058c88.0.2026.07.10.13.21.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 13:21:55 -0700 (PDT) Date: Fri, 10 Jul 2026 13:21:51 -0700 From: Jonathan Cameron To: Laxman Acharya Padhya Cc: Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Yasin Lee , Joshua Crofts , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] iio: proximity: hx9023s: validate firmware size Message-ID: <20260710132151.00000f37@oss.qualcomm.com> In-Reply-To: <20260710152842.53659-1-acharyalaxman8848@gmail.com> References: <20260710142212.52225-1-acharyalaxman8848@gmail.com> <20260710152842.53659-1-acharyalaxman8848@gmail.com> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=JJYLdcKb c=1 sm=1 tr=0 ts=6a515464 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=pGLkceISAAAA:8 a=VwQbUJbxAAAA:8 a=I__WuZVpHmGD6N4htagA:9 a=CjuIK1q_8ugA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-ORIG-GUID: DbKcZAVULQmvH-YPXCJTyz2cmmMtggd5 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDIwNCBTYWx0ZWRfX7uxffa3gsMz4 cSIJc+OYzVqar8CCjeUz5MirRuqdVxZA5uCHpjXTftJKwajpzzRP575za5KSQi+8IdohVVxMQvZ WjOHyj10+fNfBHx201BV6M2owMX7HII= X-Proofpoint-GUID: DbKcZAVULQmvH-YPXCJTyz2cmmMtggd5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDIwNCBTYWx0ZWRfX6R01p26N2PUJ iI1Hki1LCslcZKje/mPKwB2VAtFPVObwxghFMmXnkxe6wwpJDI7EnJSShh2solWyRikZToiYigk YzL6kA5PnC/5TlptzBX6oO5ScO+8iw5jm4JmtF738BvkTyTYoxg4/SoNc/1QWESk+IdYzs4o0Le KbdzKAJPDpGFFqG7Y6z1JERLFDii3J3uDvfWFcp9eV65qN9S2DzgIAAtP/yAhZt4Ji5lTC0ICbE jVzGyNszjuuMqgCTLKsr4nFUFxtBnB0ew534Swo9hPexuSJMMVQsG8OqSJQjK75hdHUIXBMIKSz 9yfKmfa1SgCKDONCl58xY8XlL3/z7DrfcUKRjXCgmCAJgkhNS1mdCApJBeC62izhOJtN+LcnaI7 Lwf2wfIny4meyzO6l+jtrQfpUycGA41rxqAFR+w3KTbFK34VceOY4PocrxI7F77ORUXnswIeJnE 3bsd2Tdt+uL7H49XlMA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_06,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100204 On Fri, 10 Jul 2026 21:13:42 +0545 Laxman Acharya Padhya wrote: > hx9023s_send_cfg() copies the firmware into a counted flexible array and > then reads fixed offsets from the copied data before walking register/value > pairs starting at FW_DATA_OFFSET. A truncated firmware image can therefore > make the driver read past the copied buffer during probe-time configuration > loading. > > Reject firmware images that cannot contain the fixed header, reject images > too large for the u16 fw_size field, and validate that the advertised > register count fits in the remaining payload. > > Fixes: e9ed97be4fcc ("iio: proximity: hx9023s: Added firmware file parsing functionality") > Cc: stable@vger.kernel.org > Reviewed-by: Joshua Crofts > Signed-off-by: Laxman Acharya Padhya A few minor comments. Thanks, Jonathan > --- > drivers/iio/proximity/hx9023s.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/proximity/hx9023s.c b/drivers/iio/proximity/hx9023s.c > index a6ff7cbe9e6..9d91ce681ac 100644 > --- a/drivers/iio/proximity/hx9023s.c > +++ b/drivers/iio/proximity/hx9023s.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1031,8 +1032,11 @@ static int hx9023s_bin_load(struct hx9023s_data *data, struct hx9023s_bin *bin) > > static int hx9023s_send_cfg(const struct firmware *fw, struct hx9023s_data *data) > { > + if (fw->size < FW_DATA_OFFSET || fw->size > U16_MAX) Add a comment on why you've picked that upper limit. > + return -EINVAL; > + > struct hx9023s_bin *bin __free(kfree) = > - kzalloc(fw->size + sizeof(*bin), GFP_KERNEL); > + kzalloc(sizeof(*bin) + fw->size, GFP_KERNEL); This doesn't belong in the fix given it is just a reorder. Maybe it makes sense but if it does, separate patch with an explanation of why. > if (!bin) > return -ENOMEM; > > @@ -1041,7 +1045,8 @@ static int hx9023s_send_cfg(const struct firmware *fw, struct hx9023s_data *data > bin->fw_ver = bin->data[FW_VER_OFFSET]; > bin->reg_count = get_unaligned_le16(bin->data + FW_REG_CNT_OFFSET); > > - release_firmware(fw); > + if (bin->reg_count > (bin->fw_size - FW_DATA_OFFSET) / 2) > + return -EINVAL; > > return hx9023s_bin_load(data, bin); > } > @@ -1058,6 +1063,7 @@ static void hx9023s_cfg_update(const struct firmware *fw, void *context) > } > > ret = hx9023s_send_cfg(fw, data); > + release_firmware(fw); > if (ret) { > dev_warn(dev, "Firmware update failed: %d\n", ret); > goto no_fw;