From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF5AF2E762C; Fri, 10 Jul 2026 14:23:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.194.8.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783693398; cv=none; b=q/OgGrAeswvhuusrY7lI6VaSD9Axl6vNo6df7yocQY8C3O8vITimIJd4HVmnkS0rI+vov7oMIfjMAHOZHvQ9vRqK7J85Nu5Gs9Z/hB5ucCv4uXZNVOPFbCY2GgHNaAPzWtmUPlLeudFJOXIKnEzr+mSkP3b5gPtMnBsrPcFTb8U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783693398; c=relaxed/simple; bh=r7/9LOboyLHHkT/0tArXdh/IvtIzxUswzEgA8gjenPM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=EU1Ar6C3LnvNceMqxppSdeoMjOtwSG31mD0ZRcFsX8oWkq20Of60J1h73unBZZREGrF1Md+ipGQX6uO6ZP5ivlqvaLj70rSCOMVGYnTZMSMfInZv3REoPbJdZ9btVzLVd2jxMTHAuqQFMJEZa1kBBqSr3HVGwQCoHzgh/5L/aXc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it; spf=pass smtp.mailfrom=dolcini.it; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b=kz6NjpeR; arc=none smtp.client-ip=217.194.8.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dolcini.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b="kz6NjpeR" Received: from francesco-nb (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 38E9422DFC; Fri, 10 Jul 2026 16:23:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1783693391; bh=JlXhDK3SpK/AwHtqfGwbsNmOHHv27/h4myvZJQX2l3Q=; h=From:To:Subject; b=kz6NjpeRbTYmnfuDSIt8IL2piA7VkTT8eogW4xffawLKWHPrTsiiLLiqC5YZUrc94 wV1D27ma7RHGY+kFRiABCthGssea+3chpcUtqZ5FoCAhMvzi4n1D6TkHI+ZmqIBGFw SMaKOTJnUCu1sHC6FfLid7nR6f1oB9h+G91mpfeoHrjyCf20I/3pQ6Z7D4aE+Y4eOl Ym0Vl/m8OUA+b/9HBUzmPq+BdAZWPgil0AiNkLzr+GsU0WQC0Zv3sgotYlltXAY3y/ fL99RSPJt2brJnx/+yLgdqDDC3Um4dY5ZsGESQkmmS5FclCXOTeplB2fTUQWclwMkA 2xmOrLlV4gAxg== Date: Fri, 10 Jul 2026 16:23:07 +0200 From: Francesco Dolcini To: Johannes Berg , skyexpoc Cc: Francesco Dolcini , Brian Norris , Miri Korenblit , Kalle Valo , Kees Cook , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] wifi: mwifiex: bound uAP association event IEs to the event buffer Message-ID: <20260710142307.GA77999@francesco-nb> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8b98582b-1120-46ff-8fa6-fd30a6b13016@Canary> <1462bcdb0944bfd3ae7ac9618cc59ab6cf75dfc6.camel@sipsolutions.net> On Fri, Jul 10, 2026 at 09:41:26AM +0200, Johannes Berg wrote: > On Fri, 2026-07-10 at 09:21 +0200, Francesco Dolcini wrote: > > I think we received a few patches that are validating the data received > > from the firmware (including this one). > > > > I did not review any of them yet, what is your opinion on those? > > > > Should we consider the firmware trust-worth or should we validate > > everything we receive from it? Is there some agreement on this topic in > > general? > > I don't really know fully "in general", but I/we generally treat these > as issues. I'm not going to worry too much about them, but I think we > should fix them. Ack On Fri, Jul 10, 2026 at 07:44:27PM +0900, skyexpoc wrote: > > Should we consider the firmware trust-worthy or should we validate > > everything we receive from it? Is there some agreement on this topic > > in general? > > For mwifiex there's a concrete reason not to trust it: besides the > SDIO/PCIe parts, mwifiex also drives USB dongles (8797/8801/8997), so the > "firmware" can sit on a hot-pluggable, potentially attacker-supplied > device. A malformed event from such a device is the same threat model as > any other malicious USB peripheral, not just a hypothetical firmware bug. ... > So I'd say it's consistent with how the driver already treats > firmware-reported lengths and agreed, worth fixing. ... and ack. Johannes, Brian: I will try to review those patches, unless someone gets to them earlier and they are merged. Francesco