From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9834C2EA75E for ; Fri, 10 Jul 2026 15:09:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783696161; cv=none; b=izajqasj4+46mRyfS0b6S51PsUKiZmqXaHrK9e32iaqO+YyPtGSABI4QtTYwhR1EVYfRkJzz5lvG1iN4Cq6LHqNN95bv+wMhvEZw4FNl8D/FXh/TkKJUGQedQ3y4iSdUm5n6t4cdTWrULtvHAfdhXBF44cUHYm6keJtZROvPk1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783696161; c=relaxed/simple; bh=AHERf1Vd15oGvCU1vIrFwXvrM9ofJI08NgRSLGkpoVY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ly8ikr8Xzk6eeyBMxIlD7HP4wQKImNufRALTOeBaAapGPMKRgS0d+vC9RHJjR6La+7Xb7eDJicgbsliGdXjmc4BM1XaNYndW9eZ21CskoXmaCCItxSk8hLGCq+5nERQ19PpNWxsBEdixsztgUtPHDhPW0FhA2SbtdMr0UuMLmC8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ujo2f55d; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ujo2f55d" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783696158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=pNxulV5VaX1gfQVD8fWS7g6QOBG7OlPjf+taGpK6D5o=; b=Ujo2f55da4hQ4j2mtWzFZazHr9u7G1qaBoj3E1Sji/LlRvZWBd8ryyUHX7aLy7Hp0qiOXc yHq6k+VxacqnxgYQZe3c+lcsxz2Ab616TXKGwNWSgmnUsDV3YcVFX/3XYfXy9a3d70YEqD 5KOExmg2NjmpnUFg6gRMr569yvasPcg= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-VtsCZIbkPIqF1enU4HK2WQ-1; Fri, 10 Jul 2026 11:09:14 -0400 X-MC-Unique: VtsCZIbkPIqF1enU4HK2WQ-1 X-Mimecast-MFC-AGG-ID: VtsCZIbkPIqF1enU4HK2WQ_1783696153 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 127831955DDD; Fri, 10 Jul 2026 15:09:13 +0000 (UTC) Received: from shire.redhat.com (unknown [10.22.81.211]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 089291800592; Fri, 10 Jul 2026 15:09:11 +0000 (UTC) From: Steve Dunnagan To: Lee Jones , Pavel Machek Cc: Jacek Anaszewski , Linus Walleij , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] leds: gpio: Skip unavailable LEDs during shutdown Date: Fri, 10 Jul 2026 11:08:41 -0400 Message-ID: <20260710150841.19669-1-sdunnaga@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 gpio_led_probe() leaves an error-valued GPIO descriptor in the LED data when an unavailable platform-data LED is skipped. The entry remains included in priv->num_leds, so gpio_led_shutdown() later passes the error pointer to gpio_led_set(), producing: gpiod_set_value: invalid GPIO (errorpointer: -ENOENT) Skip entries with error-valued GPIO descriptors during shutdown. Fixes: 45d4c6de4e49 ("leds: gpio: Try to lookup gpiod from device") Assisted-by: ChatGPT:GPT-5.5-Thinking Signed-off-by: Steve Dunnagan --- drivers/leds/leds-gpio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index 8ae71c2e91e0..63cb517ef385 100644 --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -304,6 +304,9 @@ static void gpio_led_shutdown(struct platform_device *pdev) for (i = 0; i < priv->num_leds; i++) { struct gpio_led_data *led = &priv->leds[i]; + if (IS_ERR(led->gpiod)) + continue; + if (!(led->cdev.flags & LED_RETAIN_AT_SHUTDOWN)) gpio_led_set(&led->cdev, LED_OFF); } -- 2.49.0