From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 417E243B48F for ; Fri, 10 Jul 2026 16:44:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783701872; cv=none; b=u/L3/nyXOSgWzq3NihoxtQ7yo3CcE52C3e9E7LQnc7e7pu9kS4NJYun1g7xQVytl0K7Ap9idkbMZKW0TeiBH7UjKooIaG5ymSRvtBzZp4BCmDCImI99CrK183cQdO45v/8wgI53gBLI39VBaWevBrvpOH65NV5jDYL5/KW6KC8I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783701872; c=relaxed/simple; bh=f7MiJ/V3Sa3Z4+LOlKBCBuiD8YraJfksnG/xFb+njPc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WwWUPq2k5Ddym+lH3mVeisZg7lkseRTtuk+btjSiYIHY+TGPEYtaFz22pmlHqayMiHFj41wVnov9VlWqXuo5fK11yZdEumaD0okwSrJuQ2Ugmpc/nlLPF1OUuin77l/tR8rjah8c1Rw+Hikl7nfAO6qf3SsbNpyCRqBeaE8Fffo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=FI3oP9YY; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="FI3oP9YY" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-51c0c68aa31so7532851cf.3 for ; Fri, 10 Jul 2026 09:44:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1783701869; x=1784306669; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=f7jwDOcuUIXFwEJ3t6jZRtuRC5qCtLyV1KSZwcqARY0=; b=FI3oP9YYHhgE4T+LuS14BPDc6wqIOy69I4OhseWi8Rt1tf/J5Mw3KqzOf6S+XJf4aX tV/TkU2s864YpvGiyNx/mIKxQhOkoEySrwrleUYzVE/nk7OeZ09B60cbMn2C3XmSQBy0 dqUTDIHtc1vDT6N+p+5/Cqtfo4tviypiymM9uA+GYCDiJoYk42KS1Thf96n87SaVikK8 5dCSyAFF9LCmzGimeccwBw2zwbOpBfwEa5eAjiDX/+tKjtEvbX2JvgOrjflIojIjBHVg u4wJfYIrprUsVaVeeMCc8E4o9AmWKP8vhp3Wh/GBkbzhgV/KPNV40AuvmCVuiOEOMOXf te3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783701869; x=1784306669; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=f7jwDOcuUIXFwEJ3t6jZRtuRC5qCtLyV1KSZwcqARY0=; b=OvJ/3TZ3+FFpzdnsatG5VmiQEemB6f11wpnqYMyIebra5DZufe1dEGIXbs6vdG+eRR ZvsY1+MtA4ixMUmDvGBKd7cdvb88i7g82VsS5p311kcPMa5BaVFh2jNttrO1EZTOaC+w f9D1RBS7lx75xB+urp9iWpM1ExyCg/1JxiY3HsIslSbpl4Rk5TyH4juQ/OmXHxGsCC3D YdYzEK1W0/e9HBQsz/aKKMAM0woXhNI4h+Uos9tOmrifx2Z/RXmyZEqYn3rxRKqEc4B9 AorBjr9FwVxd6r486U6hYzafKRVE6r0s+NtWPqYEolK71zY7qX8X/946yKz1rEGHoBXt 7R2A== X-Forwarded-Encrypted: i=1; AHgh+RpKuk9dvJ71OQIMoGpVv4BLmwZUrTZuHfehNJc6jg+parOGZYzQBWfydq6lC6CF/t21+X1yjeEKtosj+V4=@vger.kernel.org X-Gm-Message-State: AOJu0YwljPhgo3US2hnHaLL0ll7lQGCOiVy2xXfSXt5PliGs7M6ay1eP V/3QxlWrPx6xhaVjWAT4SP76IAZs9eHz/NWQ2x5e9mw7jycabu+7hxwN9fdz7iiyyS8= X-Gm-Gg: AfdE7cmxU3txJsSz8ZK2QFbF0cScWKTx9vYxni6t90CJNhA+xgGNqBKKeweLr9I0D7E 2JlkLa9MMvv0tA+eli88S+kROnbx2wKa5lxn0R7nqXBTtE8sB1c8xrBffa/Ja2THQYwVIQuMkRJ 0HXB8utBpQeErtDvUQrbWJZp4efGnH+3HlbXx8ogczW5OgXW+jktb9TSt+mE5g+ZHw37Osa0ZW1 3V5OYWfEaeMoNTtGFL7VZlKuNYnieP836jMy4+HoiIW3pPyahSsO9hgl3Dp/0Y2kvsWHgfSy9rt cOSv57IN0Wrany8qYNoZJh5o1MgCsc4gr2F0avvAvrp2AF7StmSfKW1i5kltVPpd1jikXEn/FvX k5JgjGWVQfU19x3+QdhoupEZp7RGtqFIOPmvN1n2yykd+VEdh9xSgjXPbs6Mr X-Received: by 2002:a05:622a:96:b0:51c:7b12:5ff5 with SMTP id d75a77b69052e-51c8b43fec2mr132124531cf.81.1783701869227; Fri, 10 Jul 2026 09:44:29 -0700 (PDT) Received: from ziepe.ca ([159.2.72.92]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ffd56c4b91sm45168766d6.19.2026.07.10.09.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 09:44:28 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wiEKx-00000007Yxj-3wpY; Fri, 10 Jul 2026 13:44:27 -0300 Date: Fri, 10 Jul 2026 13:44:27 -0300 From: Jason Gunthorpe To: Stanislav Kinsburskii Cc: airlied@gmail.com, akhilesh@ee.iitb.ac.in, akpm@linux-foundation.org, corbet@lwn.net, dakr@kernel.org, david@kernel.org, decui@microsoft.com, haiyangz@microsoft.com, kees@kernel.org, kys@microsoft.com, leon@kernel.org, liam@infradead.org, lizhi.hou@amd.com, ljs@kernel.org, longli@microsoft.com, lyude@redhat.com, maarten.lankhorst@linux.intel.com, mamin506@gmail.com, mhocko@suse.com, mripard@kernel.org, nouveau@lists.freedesktop.org, ogabbay@kernel.org, oleg@redhat.com, rppt@kernel.org, shuah@kernel.org, simona@ffwll.ch, skhan@linuxfoundation.org, surenb@google.com, tzimmermann@suse.de, vbabka@kernel.org, wei.liu@kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH v7 8/8] drm/gpusvm: Use hmm_range_fault_unlocked_timeout() for range faults Message-ID: <20260710164427.GW118978@ziepe.ca> References: <178345345668.660027.2952911919681614557.stgit@skinsburskii> <178345366389.660027.12986386801605494596.stgit@skinsburskii> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <178345366389.660027.12986386801605494596.stgit@skinsburskii> On Tue, Jul 07, 2026 at 12:47:43PM -0700, Stanislav Kinsburskii wrote: > Several GPU SVM paths take mmap_read_lock() only to call hmm_range_fault(), > then retry -EBUSY until HMM_RANGE_DEFAULT_TIMEOUT expires. Those paths use > MMU interval notifiers whose mm matches the mm that was locked for the HMM > fault. > > Use hmm_range_fault_unlocked_timeout() for those faults and pass the > remaining retry budget to HMM. The helper owns mmap_lock acquisition and > refreshes range->notifier_seq internally for each retry, while GPU SVM > keeps its existing driver-lock validation with mmu_interval_read_retry() > after a successful fault. > > Leave drm_gpusvm_check_pages() on hmm_range_fault() because that path is > called with the mmap lock already held by its caller. > > Signed-off-by: Stanislav Kinsburskii > --- > drivers/gpu/drm/drm_gpusvm.c | 52 ++++++------------------------------------ > 1 file changed, 7 insertions(+), 45 deletions(-) Reviewed-by: Jason Gunthorpe > - mmap_read_unlock(range->gpusvm->mm); > + err = hmm_range_fault_unlocked_timeout(&hmm_range, > + max_t(long, timeout - jiffies, 1)); Same remark about max_t Jason