From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A9E3344036 for ; Fri, 10 Jul 2026 14:54:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783695246; cv=none; b=MC8XG1KYU8AJlUTzEvadpeMao/d1a8iWijy/l5VukH4HYWz2DOC0j9z/xOYZDUofAF/iLIXPLyl8oFUEpT8b2f6DVTgokml0IvK+qA2BOMpuRKN7itZoBrnM3Fvpnia6wlmFvdyfsNfzTiaUPaJANd9MDrE5a0uEs44gypjv0AU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783695246; c=relaxed/simple; bh=zjjM4SgtY2ZYsY/pfHW4NTPajyUYDKNVs1BgTxWTkMI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Hrz4hMqurND+Mtica+jj2EMFDTjeOf5GBpvtugF39MAET/RrA9u7wSN+Wttu4Yf4FE3NciH2NfENHp5HjtTcich3kcj7kpT71SoPCWNL05RAE1RfuXqjvq2F5Db3lKoPm0DwIahjnxxqCkbwqFqr8w/uOtbEgzCfA5LbbYxTE2g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rm1wYWQq; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rm1wYWQq" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5aec6360133so714559e87.1 for ; Fri, 10 Jul 2026 07:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783695244; x=1784300044; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gl9mT3P5+btuz519aywW8mP891xmb+W2d22pXd2NmlU=; b=rm1wYWQqfe9kNet0YRksaxshVnFvKlMQqu1NqflcK2skyrb21qaVVlEVtzG1briICD jfsAHsqEKR6lzqSFpYTliMwS1mP/2MSwI6DuLIPixqdSwy8GPcLQX6aVNnwBCRBEntBn RQFz/n6OyHk26ucWOMM3DaZULDWe5Xj/Yrj7erHzBER4ZfYtOjzqmuXLo7DSmX5L12ON QxZ39XkG1BluztfCBNdaPHksd5i0htwpVjNg+1PAVyMc1kjyT2+XK9ZhA/ojARKBTFmM RVbWXXGwQEZT6f2/iREw18054rHpwffPzVY/G9Pu9zmwUN2v49WnD6m7rhQtKDataa8j Oh9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783695244; x=1784300044; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gl9mT3P5+btuz519aywW8mP891xmb+W2d22pXd2NmlU=; b=rG4pR5EdGtiaEND94df4IqqOIh/VycvkRsLFTSm2l8XhqrfFJGhrmwzN15VHvkLoUr kQNiAnPtFf5zj/inqX6Sr+ocdDQWl1nQcMBbYjNyRa4mrk4CuItKJZ5u4wRWZqBQjLo1 3oozSFUeZIWo7OsHMr3wwf/wk9JJcJ6sfHN+MQ+KTyE2gwW1BGjr5NTxhZsBuE6bi1rQ qjGAiuqIsEqUBfqItTeKd3U+sFAECyBL4QHUNOTIQLAK4sP2yvNs0TmrUTkjz/60QnXu FtyIEyM61kigZIE+VazrCcA5v+uvcitYxlc5Ec8+L8gNYkE/Gl+NjOyrSkdjtgkk86Er rTWw== X-Forwarded-Encrypted: i=1; AHgh+RpcHoxBXZRx9R7wX8PX1TiYIlzKJSAIPYT/RIDyONIJPFTqjhkE6oGvc2aSsTf6FiMnQVp/7JRJIHPWV+w=@vger.kernel.org X-Gm-Message-State: AOJu0YzB/wurMG/kJtAUkTMSizcoCgkGl6Eb0d7sq/viyTpU617rG3JS qBqX1MR6yhv7Hk6/4AoDRZ4BwxyY4Fsxju1VRGCeoL2XHGVBHdPQo/xA X-Gm-Gg: AfdE7cmYzebx3pi90AFwJ9dlqhOHm7O27lJdd/dh+/ipVyAPrc/IH3SOLr8GFYJOiaG FKziGx2TOvavqfvcpph2Y30RWG0Rdv6AboV0HV97H5Od1BPb6yfRKGhmGQfPwvCcflW0ulB4JEq t1YbBsRBQwJ691dQZ5Y4vbTTXNS6+DyLEZgXeGsmOpM9W4D8BhYsYT649wv6Mj+18Tmrul3TPnj C5TxWJiEdiNZ+bNgdFyUYbF+i4U+MrANSRyszco0C+kqwAek2pyCiaxLh35RjPvcBfEfDEd/mF/ 2YUECTTz/6vN0gGnVlsjd6AKBnYHV52zQZBf0k3LdRe8PS4XtUq2KXOZB7OqEP5INRsUdlxqsEP CMjgE6Emoe60p+XDWFqs8+Lc2BBE6JI6LweEAKeng5VHoJLkLhiWTneCrwQRR1rRht3+UZ7v7Qw 5/m6kvFWzCwj+PDqZuqGY6JFwmwppcbdvLzy2OtE9YiWd4Wrkw1tgVtBrWW34OlGczU6dAgJUdZ F1dsBkF5tdqvu+6OGdSu60MB7xdN8oOWVBypow+lw64pEZZjdPlY7ZdC7mAIJjyRpaiA9PhO3Ib h5f+8jIdhrxr289N4ovLeXKndmwhCW1y7BgWG4qdiUWM0b2E2z+TTBCMqaEbUt+aX0KJeDrA8Te c2wpOcSvdKtv9jyeBOTrGPGo= X-Received: by 2002:a05:6512:159c:b0:5ae:bcc4:c071 with SMTP id 2adb3069b0e04-5b0113f95c0mr2985552e87.0.1783695243458; Fri, 10 Jul 2026 07:54:03 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b01caa60e4sm680375e87.60.2026.07.10.07.54.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 07:54:03 -0700 (PDT) Date: Fri, 10 Jul 2026 16:54:00 +0200 From: Joshua Crofts To: Laxman Acharya Padhya Cc: Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Yasin Lee , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] iio: proximity: hx9023s: validate firmware size Message-ID: <20260710165400.00005108@gmail.com> In-Reply-To: <20260710142212.52225-1-acharyalaxman8848@gmail.com> References: <20260710142212.52225-1-acharyalaxman8848@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 10 Jul 2026 20:07:12 +0545 Laxman Acharya Padhya wrote: > @@ -1058,6 +1065,7 @@ static void hx9023s_cfg_update(const struct firmware *fw, void *context) > } > > ret = hx9023s_send_cfg(fw, data); > + release_firmware(fw); Why not move this after the if? Keep the call/retval check coupled. > if (ret) { > dev_warn(dev, "Firmware update failed: %d\n", ret); > goto no_fw; > Otherwise this looks good. Feel free to add my tag with the v2: Reviewed-by: Joshua Crofts -- Kind regards CJD