Re: [PATCH v2 v2] arm64/pcie/pmu: Add pci id for LECARC pcie pmu

[Bjorn Helgaas <helgaas@kernel.org>]

On Fri, Jul 10, 2026 at 06:24:08PM +0800, Braden Zhang wrote:
> From: Brett Zhou <brett_zhou@lecomputing.com>
> 
> This patch adds support for the PCIe PMU found
> on LECARC SoCs, which utilize the DesignWare PCIe Controller IP
> 
> Signed-off-by: Brett Zhou <brett_zhou@lecomputing.com>
> ---
> Signed-off-by: Braden Zhang <braden_zhang@lecomputing.com>

Bad S-o-B chain ("---" shouldn't be in the middle because things after
"---" get dropped).

Since PCI_VENDOR_ID_LECARC is only used in one place, please put the
#define in include/linux/pcie-dwc.h for now, per comment at the top of
pci_ids.h.

Is this all that's needed to enable the PMU on LECARC PCIe
controllers?  I see that the SoC uses DesignWare PCIe IP; is there
already a native DWC driver that can operate this controller?

Update the subject line and commit log to follow the style of previous
pcie-dwc.h changes.

> ---
> Changes in v2:
> - Format: repalce space with tab to separate the macro name and the value.
> - Link to v1: https://patch.msgid.link/20260710-pcie-pmu-v1-1-1519e580313f@lecomputing.com
> 
> To: Bjorn Helgaas <bhelgaas@google.com>
> To: Jingoo Han <jingoohan1@gmail.com>
> To: Manivannan Sadhasivam <mani@kernel.org>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  include/linux/pci_ids.h  | 1 +
>  include/linux/pcie-dwc.h | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 1c9d40e09107..eb0020f9d366 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -173,6 +173,7 @@
>  #define PCI_VENDOR_ID_DYNALINK		0x0675
>  #define PCI_DEVICE_ID_DYNALINK_IS64PH	0x1702
>  
> +#define PCI_VENDOR_ID_LECARC		0x0720
>  #define PCI_VENDOR_ID_UBIQUITI		0x0777
>  
>  #define PCI_VENDOR_ID_BERKOM			0x0871
> diff --git a/include/linux/pcie-dwc.h b/include/linux/pcie-dwc.h
> index 8ff778e7aec0..1a31fe4db228 100644
> --- a/include/linux/pcie-dwc.h
> +++ b/include/linux/pcie-dwc.h
> @@ -32,6 +32,8 @@ static const struct dwc_pcie_vsec_id dwc_pcie_rasdes_vsec_ids[] = {
>  	  .vsec_id = 0x02, .vsec_rev = 0x4 },
>  	{ .vendor_id = PCI_VENDOR_ID_SAMSUNG,
>  	  .vsec_id = 0x02, .vsec_rev = 0x4 },
> +	{ .vendor_id = PCI_VENDOR_ID_LECARC,
> +	  .vsec_id = 0x02, .vsec_rev = 0x4 },
>  	{}
>  };
>  
> 
> ---
> base-commit: a635d6748234582ea287c5ffeae28b9b23f91c7e
> change-id: 20260710-pcie-pmu-5ef78c56c3b6
> 
> Best regards,
> --  
> Braden Zhang <braden_zhang@lecomputing.com>
>