From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDB3C233D9E for ; Fri, 10 Jul 2026 18:09:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783706972; cv=none; b=M5JSW1zL00LiFw5VDODpJdJA5396EvKWzzY1g3mRwDEoS0AKwBXbUy9I64yf1IMtNCRRQ12WVK57nUhIl5wHyJPVROZ1yeqwBEwQv3w85BpeBroUeAP2pA5dK43D5J5JchwuTgKJ9FPznyKEc7j+sRYJKS0Vu6C4D97ZOmYqR30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783706972; c=relaxed/simple; bh=MH9pMA5tBj76KKVaDsd/HxMdOB1/Yo5Uc23GxTClXWw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=BgA+zyrhA6H5cmeGBwRE2+umQyNBtWpIVixNRyx4oS5WcNlPmSLJzH6L0c9c1B/ZPutA553zReckrhe4mHk9UuY78dH4GMaOyY/RUWlyC9PtNP0606217l88GCxB1uDm/8CkiyB+ImpsqZN9oTcsUvOF76r6kKQCXsNbxZNjQ4Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VxLCV63f; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VxLCV63f" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493ece78b0cso9748385e9.0 for ; Fri, 10 Jul 2026 11:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783706969; x=1784311769; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=62LK1B4AP8fb0CoLCmSu1gxf8mNW3/RpPJK1TqUpKKA=; b=VxLCV63fpV6UX0Q6cfat1bbXyGFv3bg2nqkDfwWeg9/1cM1osXnrCCjqbbegCsEst1 hzBj4jOzio1cFVtF428czlUV3MWrlzU/fWPF7qHuIL1Y5sgTfvPsfoDPkNVPiuohiOZp 7vX111WWY53wMoKLVYZWDwHy6rOZcEtX13HIg94Sfw6mqt6KjFpajc4lO9G1gU/l+/8r Gp+4U8vsSiK0AdFtqo82U68Nw5r5hUrUKGssTCSREXUeWGoqnsxo2aTmCx/XkzcHYStB YtrHNymR+SGdsJThRaNvFVJ33ndAan5JCbssyaUpm+1oQIkmJuMwx3bSjuiGrtRSq9o7 620w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783706969; x=1784311769; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=62LK1B4AP8fb0CoLCmSu1gxf8mNW3/RpPJK1TqUpKKA=; b=dWIaOH0RoGnW/EWoZ4pQYlQAo74nDSTHhLfWp0o5dTV4Is0qT9/eHc1urdPNAudxCi OrgRXtuLD+qgmwKroyr7u6KB1rAc1S8H4mZyAWW6LWcYNiZftogSNsf9fjvyEx9w+X4p bFfnUXqfBb8o0nyDFXIDB+6qQdP+bZZVk3RkI5VmsK6WEnZYugO7R4YNF3PpkRqC3YxL Fo7cYu4ecHm8mWuusnEqOeUzvm8d7Mn3OvnZo+LLZDuHLwyQVhAHi5V9PjaG/Je5AoUH 4FgIc7YyBqkvfnaREyv/8Yhdj4ldY3xUs7bz7Vs0VvFPV9KWtXoK/UIH/Uqo/GBjgbXm Xz/g== X-Forwarded-Encrypted: i=1; AHgh+RrX+sSlqHRCWq2+edI5D1r1GXPjSflw8hA/+FcQG3V0bY1vutS1nWs2UaRXVTbIu3z7ABkEOZ+klPGMYlk=@vger.kernel.org X-Gm-Message-State: AOJu0YxoZpe/WY5LyZ3RJyNjksLqcmkcnxEktYDaaR3iLnL9BDy47qSo 1ldV/k/4Qb/9rpgDYqpxFMY0ND6764bO8oXrt+4Z8jyc9+hrsLNj1YOg X-Gm-Gg: AfdE7cn3Qz+uO6URrXXt8lTGvGG7c600tecb+L9Ca01yqczT+CBMN71Y1j9vcdWcGDd VlDjvOcJzgk0VsCnfndX5ZasGxOh45ZScjuxvolAYUaZmqWn/wbYTABFdQtRRJVGkRrEZyILGiJ un9eTcitAzm5nWmWPps3qrL3iV0OybXdNN55W03vUoyjkyIEWcJITrHf6NREoDCz0cBgkZnbMzo zLb6Xil1HH1iQC9gdSngZINwwJlDj419bumEHM/Rq7iODtnVdESnH9n8Y2ReanB0rcIKWuV2Hny ZOqghsbPbDqw9N+TjbUhDW/iIeLqqZsshHVIolR7l9IXaEyqi5+2hw2Aonq2szJ2nCnHk5zyoTX hptA+N2bQbwlgBXvFByeGVCbClU+WYrqwZsGtKoMh/b3wW1jM7ABWfKOhkOS8jsxz7Ee+3uKwYm uUPSkHWHK2CviTQE9yNzOhfteFDBdyEjbedxCE2LsquLanzpfaLyUphG2xgA== X-Received: by 2002:a05:600c:1c0b:b0:492:4c2e:9613 with SMTP id 5b1f17b1804b1-493e6864191mr133210795e9.18.1783706969079; Fri, 10 Jul 2026 11:09:29 -0700 (PDT) Received: from mtardy-friendly-lvh-runner.europe-west1-c.c.cilium-dev.internal ([2600:1900:4010:1a8::]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-493eb670a41sm148593095e9.0.2026.07.10.11.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 11:09:28 -0700 (PDT) From: Mahe Tardy To: bpf@vger.kernel.org Cc: Mahe Tardy , kernel test robot , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , John Fastabend , Stanislav Fomichev , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jordan Rife , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf-next] bpf: Fix unused nskb warning in bpf_icmp_send Date: Fri, 10 Jul 2026 18:09:15 +0000 Message-Id: <20260710180915.7105-1-mahe.tardy@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Declare nskb inside the IPv4 and IPv6 case blocks so it is only present when the corresponding code is built. The case braces are intentional to scope the local declarations under the switch labels. Fixes: f3603df9aebb ("bpf: Add bpf_icmp_send kfunc") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202607110140.JeJZ6GIa-lkp@intel.com/ Signed-off-by: Mahe Tardy --- net/core/filter.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/core/filter.c b/net/core/filter.c index e4697036c67b..056deb9b3fc3 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -12575,7 +12575,6 @@ __bpf_kfunc int bpf_xdp_pull_data(struct xdp_md *x, u32 len) __bpf_kfunc int bpf_icmp_send(struct __sk_buff *skb_ctx, int type, int code) { struct sk_buff *skb = (struct sk_buff *)skb_ctx; - struct sk_buff *nskb; struct sock *sk; sk = skb_to_full_sk(skb); @@ -12589,6 +12588,8 @@ __bpf_kfunc int bpf_icmp_send(struct __sk_buff *skb_ctx, int type, int code) switch (skb->protocol) { #if IS_ENABLED(CONFIG_INET) case htons(ETH_P_IP): { + struct sk_buff *nskb; + if (type != ICMP_DEST_UNREACH) return -EOPNOTSUPP; if (code < 0 || code > NR_ICMP_UNREACH || @@ -12606,7 +12607,9 @@ __bpf_kfunc int bpf_icmp_send(struct __sk_buff *skb_ctx, int type, int code) } #endif #if IS_ENABLED(CONFIG_IPV6) - case htons(ETH_P_IPV6): + case htons(ETH_P_IPV6): { + struct sk_buff *nskb; + if (type != ICMPV6_DEST_UNREACH) return -EOPNOTSUPP; if (code < 0 || code > ICMPV6_REJECT_ROUTE) @@ -12620,6 +12623,7 @@ __bpf_kfunc int bpf_icmp_send(struct __sk_buff *skb_ctx, int type, int code) icmpv6_send(nskb, type, code, 0); consume_skb(nskb); break; + } #endif default: return -EPROTONOSUPPORT; -- 2.34.1