The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Wang Zhaolong <wangzhaolong@fnnas.com>
Cc: Jing Wu <realwujing@gmail.com>,
	jirislaby@kernel.org, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org, yuanql9@chinatelecom.cn
Subject: Re: [PATCH v6] serial: 8250: fix use-after-free in IRQ chain handling
Date: Fri, 10 Jul 2026 15:28:17 +0200	[thread overview]
Message-ID: <2026071046-glue-repeater-d56c@gregkh> (raw)
In-Reply-To: <5cf37150673ea4d5c28f94db91cdf68504b50522.c00727f7.d760.4135.8321.a6234c57c54c@feishu.cn>

On Fri, Jul 10, 2026 at 09:15:19PM +0800, Wang Zhaolong wrote:
> Hi Greg,
> 
> > 
> > As I said before, I'm not going to take either until you all can agree.
> > 
> > And yes, a co-developed-by does require a signed-off-by.  Without you
> > all agreeing, none of this is going to be acceptable, sorry.
> > 
> 
> Understood.
> 
> I do not agree to a Co-developed-by tag with Jing/Qiliang.  My v1 was posted
> before that series and already contained the functional lock move.  I
> reviewed/tested parts of the other series against my reproducer, but I do not
> consider this a jointly developed patch.
> 
> I do not require my patch to be the one accepted upstream.  If another version
> is used, I am fine with keeping Reported-by and a Link to my original patch,
> and I can retest the final version against my QEMU ttyS1/ttyS3 shared IRQ
> reproducer if needed.  But I do not provide my Signed-off-by for a
> Co-developed-by tag.
> 
> > Also, all of these really look like they were created/found/whatever by
> > a LLM, which is not being documented, and for that reason alone I think
> > I need to reject all of these until that is properly addressed.
> > 
> 
> Regarding LLM assistance, my v1 explicitly included:
> 
> Assisted-by: Codex:gpt-5
> 
> That tag was dropped in later revisions while refreshing the patch. The bug itself
> was found and reproduced by me, not by an LLM.  I used the tool to help refine
> the patch text and write the reproducer/test code, then reviewed the code
> myself and validated the result with the QEMU ttyS1/ttyS3 shared IRQ
> reproducer before submitting.  I also spent time testing/reviewing the other
> series; for example, one earlier revision did not pass the reproducer, which I
> reported in that thread。

That's fine, but you still need to keep the Assisted-by: tag.  For that
reason alone I will not take this.

> I understand this may mean my patch is not taken.  I am fine with that.  I do not want
> to spend more community time on this dispute.
> 
> I will stop here and leave the technical record as-is.  I hope the regression
> can still be fixed upstream without spending more time on the dispute.

Hopefully someone sends a fix for this in a format that can be
accepted...

thanks,

greg k-h

  reply	other threads:[~2026-07-10 13:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07 14:06 [PATCH v6] serial: 8250: fix use-after-free in IRQ chain handling Qiliang Yuan
2026-07-08  6:03 ` Jiri Slaby
2026-07-08  6:34   ` Jing Wu
2026-07-08  7:11   ` Jing Wu
2026-07-08  7:33   ` Wang Zhaolong
2026-07-08  7:57     ` Jing Wu
2026-07-08  8:20       ` Wang Zhaolong
2026-07-08  7:39   ` Jing Wu
2026-07-08  7:53     ` Wang Zhaolong
2026-07-08  8:08       ` Jing Wu
2026-07-08  8:32         ` Wang Zhaolong
     [not found]         ` <5cf37150673ea4d5c28f94db91cdf68504b50522.9be37cbd.7a04.4d7e.b20e.d3f90675af6e@feishu.cn>
2026-07-10 12:17           ` Greg KH
2026-07-10 13:15             ` Wang Zhaolong
2026-07-10 13:28               ` Greg KH [this message]
2026-07-08  8:43       ` Jing Wu
2026-07-08  8:45       ` Jing Wu
  -- strict thread matches above, loose matches on Subject: below --
2026-05-27  9:20 [PATCH] serial: 8250: serialize shared IRQ startup Wang Zhaolong
2026-07-08  3:11 ` [PATCH v2] serial: 8250: fix shared IRQ startup race causing IRQ warning Wang Zhaolong
2026-07-08  7:23   ` [PATCH v3] " Wang Zhaolong
2026-07-08  8:47     ` [PATCH v6] serial: 8250: fix use-after-free in IRQ chain handling Jing Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026071046-glue-repeater-d56c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=realwujing@gmail.com \
    --cc=wangzhaolong@fnnas.com \
    --cc=yuanql9@chinatelecom.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox