From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FEE31A23A4 for ; Sat, 11 Jul 2026 00:54:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783731258; cv=none; b=TP8eqQvcfsfr3V9Iy8oON8I3/aZKAmtqykLZfTd2LI9FW2r6rgVkRQhVyL7dwhPpsoWUe3P2DODcNvKqieAb8K5lRhgD0GMoaOVg+JX6dFzJ2NXmFw1XK6WEnf66pQPqWb5cxnBqm8ziji+tg80Ew6RhRId3obElovhpG08mZtk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783731258; c=relaxed/simple; bh=VUZMyy4yqPr33oPrmPpLcdtWGay1olntrZbuKoAmfH4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=oQrvjr1qsX0tp9ncg0WwUf7IfdtJrO0MT+Y//wSt1Fnz0sPTZJH7TmbVCVrJeqSvC0BE7cv8UhgnDS3oani8V4vauadwNcgqaek1jK2hU+MGsj7KB1AqNsIys5ysa4yACiQ0/G325TISyCkQFcdFsEoII1vA7MRw8wmJFUAThkw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--yuyanghuang.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=LK2IgSTx; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--yuyanghuang.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="LK2IgSTx" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-388cfc4848dso1726709a91.3 for ; Fri, 10 Jul 2026 17:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783731256; x=1784336056; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=m5cBCU9B06eC8xl8Z+jo/WJy1xgvxmqcjs5XDBzzPoE=; b=LK2IgSTxQDkoqyGcYqKBJiYJM+jsQSA4Q7g7Wo+9VnvjiAY9ZbJ0yTtxzrObaJV+KS JaE8LD3+pQxJvolJWBRhsffOk57MvTdudJIcMEXOMVEPF4T1deMRdN7V+wUctkfxcgDC O7wyUzthe01RoE2lzb4w8bwEWw3tuGyz+u+paHLrLsR4g1V3F4rQT3xBQL0lHwVJJqOS iPlY3gKRzXBti0KBuLmfM8h/LORl8+PMRYMmkCM2pJvF8nuuR2ltAwuhmovP3KuGKfeb JD3xE7doXr5+p0aBcof6asoC+Ur9Nyil3OZ195hx0a6x72A9zFOS/i+7bv2hg6DjdyJZ qoxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783731256; x=1784336056; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=m5cBCU9B06eC8xl8Z+jo/WJy1xgvxmqcjs5XDBzzPoE=; b=AqImEh3fxDtr5+HVZKit/qwyVqR6MlgKrxs17SA1pyznWvEFa8a3ehU7iDjKtF7qlK wXOh3OZuYNw6bBYtYkOrs990hQzAbxT6jl1WGu2pGXQU32RvrEEFrEwYaxko2kB1t9o7 c/eXiIbNNZYIwVvxT3Jh2NIuPiFR6FyRkksatBBBSzdQ6alk6+oOhIq0LWpE+m8HzPn5 CdpEB5Car7OLGI/3FvfVB+epOx6U3w8d7VwX6XDSTHk11ELss65uv/A2q6P62693+teA mDferIojDXneRpKXc8yn5ZL14bsoWyY/YkHBb26AFr1ANChcSwIee2n/rE/Q/axdc29n aetg== X-Forwarded-Encrypted: i=1; AHgh+RpYEU6p21g39EQFUahcC3ovM5MFgtmcSgToa/pNEqdghG07wbaVCethbROcieF/h+VuDzaVucar8pl/Cz8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3KZfhcsy3K96/nudXHv8LcSs5ENhnffRNCrZ0jaHOPeOQwCvx Mpo5aWIziksBoPpwlgCY2DjFJaqyg9qSjj455V2ZtD35/JSJlQ8WK+OrcynSHvqcjK2cDrnUO0P 2mKPACBQ3z6FCtULv25YGkC1O9w== X-Received: from pjjy22.prod.google.com ([2002:a17:90a:6c96:b0:387:9b6c:b940]) (user=yuyanghuang job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:4ed0:b0:381:bc4c:da56 with SMTP id 98e67ed59e1d1-38dc75f4d00mr1113639a91.19.1783731256346; Fri, 10 Jul 2026 17:54:16 -0700 (PDT) Date: Sat, 11 Jul 2026 09:54:02 +0900 In-Reply-To: <20260711005405.2861680-1-yuyanghuang@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260711005405.2861680-1-yuyanghuang@google.com> X-Mailer: git-send-email 2.55.0.795.g602f6c329a-goog Message-ID: <20260711005405.2861680-2-yuyanghuang@google.com> Subject: [PATCH net-next v2 1/3] net: prestera: ignore duplicate RIF destruction events From: Yuyang Huang To: Yuyang Huang Cc: "David S. Miller" , Andrew Lunn , David Ahern , Elad Nachman , Eric Dumazet , Ido Schimmel , Jakub Kicinski , Johannes Berg , Paolo Abeni , Simon Horman , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Kuniyuki Iwashima Content-Type: text/plain; charset="UTF-8" During address teardown, the inetaddr notifier may be called multiple times for the same interface. Ignore NETDEV_DOWN events if the RIF has already been destroyed, rather than returning -EEXIST, which aborts the notifier chain. Cc: Ido Schimmel Cc: Kuniyuki Iwashima Signed-off-by: Yuyang Huang --- drivers/net/ethernet/marvell/prestera/prestera_router.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/prestera/prestera_router.c b/drivers/net/ethernet/marvell/prestera/prestera_router.c index b036b173a308..0c4f462baa6e 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_router.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_router.c @@ -1302,10 +1302,8 @@ static int __prestera_inetaddr_port_event(struct net_device *port_dev, dev_hold(port_dev); break; case NETDEV_DOWN: - if (!re) { - NL_SET_ERR_MSG_MOD(extack, "Can't find RIF"); - return -EEXIST; - } + if (!re) + return 0; prestera_rif_entry_destroy(port->sw, re); dev_put(port_dev); break; -- 2.55.0.795.g602f6c329a-goog