From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6934F8C1F for ; Sat, 11 Jul 2026 02:42:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783737763; cv=none; b=ZsPODq7f6OkcBlpaFvx+dJy+mnu1aopegoQm9e/XOknGX2Lcesk8IKjxybjOXwDAtNtimnJYKe+M6YaWIa5FjMRr4F+xn6872xsFBeQ/0210HWlDuBxKr6DW305FN4PHuFmp2nOebPJ86oY4I2+iAXQ9Ts9JyVBM6e5+3wFuL54= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783737763; c=relaxed/simple; bh=qhzaz5c7gqai7uH8ENp4OXcvcRx5rtyjEEv0SrYq2GE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BRbRWIxlbvC2cH0T3j/Kr6OIUifYttfVWFmt+3boM1dre2z+AHrYdpPUOCXd1A8wwg3flBvvIQ+NVMrav/04A2gxTl5vE20VIcsYgTuVWj/zjTHybZ2ZkBAnFpSYrxtLS5t4PXz0NgCC3BF/z1ZvSYk27KRNW1srpnsGcigqrkQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=psb0Khvm; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="psb0Khvm" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-382ef647e20so1628610a91.1 for ; Fri, 10 Jul 2026 19:42:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783737762; x=1784342562; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=+aTWheqepBxqS9cLgqp6GBAdIX7fO7wElh36f1viqvM=; b=psb0Khvms2omV69W1Ldt+vrRixZF5QBDyXFSk4IWV+dsqpOzllj/FoTHVAjHBmiJRs EoLz73OTyOCo/sTKfBrusTtTqZHpWT3hAZEcMr9gCYNPpfYwJpoXh6xmQV4JTb5lxGX+ JuUMDHYjP2QbCZ9gPsTLLlQQ7GAiyYL51P7F0r7czSHs4jIxkDTR1t1ppnYXOj66sWRU u3GgtIGVPFhJiM6mn7g+4bDu7LuW8v3A67GngsT08ADYLG9QmVl251EmBRcBGSf0bqhj 6avHCyZSEkxPO7zCDGNmFAmkP0UYdI3H7oiZt3G43vKnIbakgzZvsXWWZhKrctVJWGG+ JiMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783737762; x=1784342562; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+aTWheqepBxqS9cLgqp6GBAdIX7fO7wElh36f1viqvM=; b=tEtHU8zhz144N758oT+DBCud+YJ06rtWDKXgX3tRzXoThaladOckf6kJ1v4LwcPM7+ 1pzjRLMGa0wU5OzX3Y6lNGK8Nxeh+I0taU762cJFNHC95OiLQisgnHbWS0kHIlo4eSUF sTjdE9pZEOoYipyXzI0RwWjGNDU4kLrV4z+ZWROd509D8dxElaOL1INBAZVHXVPVy/a/ Fz2FlNsnE0Hdng1/uXPlxTAD/EjmjsgXzce8JC60qiJu4vWB67n7KDt0D+uOrzBqdBEy 3eLiOgBoKYossjMJsDKIzZe3xJj2BSiH7LZAxlR8nOFa8f8Zmmk8Imyja1wAkkk3QZvC Ov9w== X-Forwarded-Encrypted: i=1; AHgh+Rpm9SUbLth9MeB0dfMv0GF6RgTe2okyGTjGK8+lcFIgbsJsQ661nim7AIR3udMIx5UESvwoC5h+EbZ139o=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4ygdQgRAsN1ZNFWDnhxXuXCmWmUP6Yxj7ehc2UNB0DHxgxgLV p6TBwNKnga88iGYnjVarxm0AXf9GQzcTzmFSHcpG6FBdZD6d10py40X3 X-Gm-Gg: AfdE7cn4/ESauaMeMUDE4k7S4jVYT1Jy4xf/8AG44oSi2T2U73gqzlguJjfID+vP8YL 4/APuP1JTcwbEoQvJcpU+fkkc4GdOE7ft2tcPpd75tOreSFXeAoZm6i3E8U4yyBNbE1FNoWLVwJ mLTbbq97lFn4MCn+fq6MFzTup/EIceDkO27P2P2UtU3cMPLPzcN7IJzy9RaNmh4O+kjFw1VqCH8 Gcdlgi7VSxVXL8kyueRHbSKwkIBSx0WrHTYLyAqn9O8P8sPf2kTND4XhOwkmwtL2xm/Gg46Nv5J V04x8xUaEdCSeDUkX62fO1h/A5qIaOmHkDAbR1WaOsvqWtGKp6BsXIIktjau8BmjHYR3pQTSXlU mBFOrtlU5UW6z8UDa1l8wIVvZBZ698XcAPgLfhXpQVHTCIJrmCgNojgZOncgHD/MnbMl7wpJohj uSOOLwJlsBCbca9XSYKRBFJERiYrbW X-Received: by 2002:a05:6a21:110:b0:3c0:9c19:65b2 with SMTP id adf61e73a8af0-3c110a7742fmr1779738637.74.1783737761855; Fri, 10 Jul 2026 19:42:41 -0700 (PDT) Received: from localhost.localdomain ([116.68.83.225]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311747f596asm45686757eec.2.2026.07.10.19.42.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 19:42:41 -0700 (PDT) From: Ananthan To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ananthan Subject: [PATCH] staging: rtl8723bs: replace magic number in InitBeaconParameters Date: Sat, 11 Jul 2026 08:10:06 +0530 Message-ID: <20260711024005.19900-2-ananthanr.off@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Per the bitfield comment in hal_com_reg.h, REG_TBTT_PROHIBIT packs a "setup" time in bits 3:0 and a "hold" time in bits 19:8. The rtw_write16() call here only writes the low 16 bits of that register, covering the full setup field and the low byte of the hold field. Replace the magic number 0x6404 with two named constants representing these fields. No functional change. Signed-off-by: Ananthan --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index bcaf63b2893c..9609ae025736 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -11,6 +11,9 @@ #include #include "hal_com_h2c.h" +#define TBTT_PROHIBIT_SETUP 0x04 /* bits 3:0: setup time, unit 32us */ +#define TBTT_PROHIBIT_HOLD_LOW 0x64 /* bits 15:8: low byte of 12-bit hold time, unit 32us */ + static void _FWDownloadEnable(struct adapter *padapter, bool enable) { u8 tmp, count = 0; @@ -861,8 +864,8 @@ void rtl8723b_InitBeaconParameters(struct adapter *padapter) rtw_write16(padapter, REG_BCN_CTRL, val16); - /* TODO: Remove these magic number */ - rtw_write16(padapter, REG_TBTT_PROHIBIT, 0x6404);/* ms */ + rtw_write16(padapter, REG_TBTT_PROHIBIT, + (TBTT_PROHIBIT_HOLD_LOW << 8) | TBTT_PROHIBIT_SETUP);/* ms */ /* Firmware will control REG_DRVERLYINT when power saving is enable, */ /* so don't set this register on STA mode. */ if (!check_fwstate(&padapter->mlmepriv, WIFI_STATION_STATE)) -- 2.43.0