From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6CC82264C0 for ; Sat, 11 Jul 2026 06:25:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783751123; cv=none; b=pEQIcADqZFhxrsaLjQFNggFPMxpMPYeURtrTrj3Ak4ye7AS89sAvEpGAwh0uNTt43QlNqVai9/e+Nk0ZGc7bzxA3l7Pffu+D1vYecFfLJtMch7SHxBxFWK7fgprgCMFkQ23eGndamxYqgI6rxS7dOw6nsGS35G4EBI4w0qoFZl8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783751123; c=relaxed/simple; bh=Vmurisb9eB8FtZsRd/bofS9k3i50a6aT5Y5TF+yMT/s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R8gJbanGwc8j3ZzhGMOIZ+cS1Mq+A5klpjxA8VLfLYOwFVtCsUaRs7Gt8f3stSl/7Vpr4l4NZ+/FProTUKRCAmG8kWmMdyWhHB9/RZqdzIPvcO7pi3JZ/TI9+rRn71ge+Zfbqo6ieVmdsO6yldaP6W70DU5OwR9E1cL/CMzUIK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G7UtrUHa; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G7UtrUHa" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-382ef647e20so1703055a91.1 for ; Fri, 10 Jul 2026 23:25:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783751120; x=1784355920; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1HflrA3DS7s9sHksbSEJbprS8Xnl3UhqhC/sOKdZCX8=; b=G7UtrUHabD3tNrCY9CxnWN3FcgA6a11s4SGgMFZWEGDWJMmmoXWEuzu/VARC5iMguY c4COvE2yn34VKFaSmLI/GsQPiRv1UhmTAV08v5qvRl1yPiEa+cYxb8H529sDcHjk168+ auPJAoJ3VHCYuiB3gEPq0U1+xhkMnBR56xKGDjUUm/wbSKHHT2sblxayaxkqqp+muPFb 6b25T3C6f0q3+NczEDjICa7ypdsGsQN2lbZrIbke4Cua3PeJ+dtSq7hNeC2Xo3jLwegx yUTg9xYzXma4GehzKXiwkVlaBP83Fyt3hxLWvRsLOk7z3Z0XR8b3f97pwrALGx/nxPW8 f5Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783751120; x=1784355920; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=1HflrA3DS7s9sHksbSEJbprS8Xnl3UhqhC/sOKdZCX8=; b=Ze8gciQ8dYM5mTNM+pJAq05KXEL1+me0QylnEOkAWofQsaWUZjX56uX3Ppj3K0UQB9 MtJmqGploktcf+p4FmZw+2LmC2YKrYsNN6ph1tvHOu8uxBYgbu9E1kK4/ZnjQ0uA/KoF Tp4F7sT0ik8cNtK+SdNsiQ7An5BdH1RBGwA/WcvQqly8m35YWhyjnv9U8dT+PzVKPiQ5 zow3Qw5GBNmngNwr1JLmKEsaNmheXu+tr2lmQIvQrvUS/5f/I2MHo9E7477WA/OGBtLf nsA4GlYedpuutjIJCmxi77pHQID1vr4NKSoC7RXc+5A5Mmbyrwb6X75niFZwENEpFwiQ zT8A== X-Forwarded-Encrypted: i=1; AHgh+Rq2QUi6rP8YBXyWxEqR/pFJaGgcQCyELVq3jlPOPJwvcvvsGFDoleFYD1FrPzUshi2H0XUZBuJLLCoAh68=@vger.kernel.org X-Gm-Message-State: AOJu0YxLoCUSeWv/LUwaMIwfzwGRzKNyUTjb6OLIYEbKeqEjIv/uchIv 2t3buv60bVdBGHMEkunXgUDE+6mk6Ja6Ok8xvxMkBWsrU1sIIB3MLCmK X-Gm-Gg: AfdE7ckbnBf9WppBzaQ7izlNHpWnTIswC9kU6xqgALVf5b5Kv2t6Imuk+y0BIYHa1N0 Xr05b0ml7Ba/GQFzzuE2BHEP3Dz5oyP0ClJaHTYxTUAZvmY3ogTVc81cI9LnL5NRHtscP/SpfOJ A16FhNDjK8AzulvnGCMDwwhYNx7zrceyr25AvcwmO9WSrGZUoCMxHAx61o0pEE/E19A6pvaxK2Y Oe6wVcylEgmCXnH3KBXnMgN3pb0uRgqmeQhdvYMA/XxWT2+zwCK9bl4aVoxSA421Lj5KOsfT3vZ +AsaLsXdlm3/GcHdRDQaDMvNlPt8jb1gmW1CLcc3+bsjiUZG6x5JY6LA/Uqo5AHnNOcH2kjkVY5 J3h/Ick8095sn2YFO9nJD+U8Fy3Op9ZG+AOAEDWAasOI7AJNSCkNNZjRWLNLFh/ThIOuRKmjtxB byMGsw3U4YfylN5rh6+ZSKb4BxpC5YFXpUaCQn6h0= X-Received: by 2002:a17:90b:41:b0:387:e0db:3d8e with SMTP id 98e67ed59e1d1-38dc77c7b37mr2121398a91.41.1783751119919; Fri, 10 Jul 2026 23:25:19 -0700 (PDT) Received: from localhost.localdomain ([116.68.83.225]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3118ee6080dsm31644604eec.17.2026.07.10.23.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 23:25:19 -0700 (PDT) From: Anantha Krishnan To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Anantha Krishnan Subject: [PATCH v2] staging: rtl8723bs: replace magic number in InitBeaconParameters Date: Sat, 11 Jul 2026 11:52:49 +0530 Message-ID: <20260711062248.28968-3-ananthanr.off@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <2026071157-ovary-property-4427@gregkh> References: <2026071157-ovary-property-4427@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Per the bitfield comment in hal_com_reg.h, REG_TBTT_PROHIBIT packs a "setup" time in bits 3:0 and a "hold" time in bits 19:8. The rtw_write16() call here only writes the low 16 bits of that register, covering the full setup field and the low byte of the hold field. Replace the magic number 0x6404 with two named constants representing these fields. No functional change. Bit-field positions are documented in the comment above REG_TBTT_PROHIBIT in drivers/staging/rtl8723bs/include/hal_com_reg.h. Signed-off-by: Anantha Krishnan --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index bcaf63b2893c..699e24f52392 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -11,6 +11,13 @@ #include #include "hal_com_h2c.h" +/* + * Bitfield layout per the comment above REG_TBTT_PROHIBIT in + * drivers/staging/rtl8723bs/include/hal_com_reg.h. + */ +#define TBTT_PROHIBIT_SETUP 0x04 /* bits 3:0: setup time, unit 32us */ +#define TBTT_PROHIBIT_HOLD_LOW 0x64 /* bits 15:8: low byte of 12-bit hold time, unit 32us */ + static void _FWDownloadEnable(struct adapter *padapter, bool enable) { u8 tmp, count = 0; @@ -861,8 +868,8 @@ void rtl8723b_InitBeaconParameters(struct adapter *padapter) rtw_write16(padapter, REG_BCN_CTRL, val16); - /* TODO: Remove these magic number */ - rtw_write16(padapter, REG_TBTT_PROHIBIT, 0x6404);/* ms */ + rtw_write16(padapter, REG_TBTT_PROHIBIT, + (TBTT_PROHIBIT_HOLD_LOW << 8) | TBTT_PROHIBIT_SETUP);/* ms */ /* Firmware will control REG_DRVERLYINT when power saving is enable, */ /* so don't set this register on STA mode. */ if (!check_fwstate(&padapter->mlmepriv, WIFI_STATION_STATE)) -- 2.43.0