From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 897501F09A8 for ; Sat, 11 Jul 2026 06:40:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783752005; cv=none; b=t6EGrh2WQKyc4Psl6iXSRpy3o1XT10cW1a2XpQ3/A4or16yFun5fThvRJG5Z0yMsngiysf4YND7QAI3rWn0FpY29M+Y5N3M7B2DKrgJoge48qLR3+FJTD78ZCqPab9Yj0A0+S7RRSR6YlsmefFYwlHSsSxIPK6ZYcfWguRkqw3c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783752005; c=relaxed/simple; bh=GQ1TAWjjBjrlB2S9Xqz1fc49hfjlJo5p0+PdZds9EGw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X8fd7n1gXn9JXZdd6vc1rYTzjYuioYsC7UG8saMTBzHuGrLulcDceiYGx8CSxxAYB8ffV4nfXASNEEiSdkJuJWJzTGA5OZ53kF1/eRaF2bX10yLKuEEJC5L+BVTusaQbGADzjTYwjQk1tAc2HXUzBoR/oowZGNMTmPpoB2KWBL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XFRgNPyI; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XFRgNPyI" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-ca7c1176317so1227263a12.1 for ; Fri, 10 Jul 2026 23:40:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783752004; x=1784356804; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aJ6EGOu7YfdhOIrZiHiND5M9DO4WwcJm9kCM/Ck4sNc=; b=XFRgNPyIkTPv+zCBmaq0DnzrzVVmGMSyf2jYTb0zgPntvv3B8Xw8phr2CUfs/CB7x8 8sNoX3u9RQNgKkyQ5IEPrPEkEzp3YjZ9JBER7m8CGSAGhN4IC28y4mVtYmCyR/FDN7BM f8XWnQM0PxqTJuJlLpSTvefjXryrkVpTVN05Uu+qOE2X83VoESIXW7MlFvPCLPSL8Z0c QxaD/FzxLTxVMytTMviaAtaqzyiyoAcwatYVgfmvUAttZCGng1ELGO0hPE/5iGz8dJqp emWBsPmS6ySs4HQajoimtzjkQhqgVv29RzA1Iwu0RuhQnNKXds9PPGkvzjEeVwKZFXaA qFJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783752004; x=1784356804; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aJ6EGOu7YfdhOIrZiHiND5M9DO4WwcJm9kCM/Ck4sNc=; b=WMHc0Ex0qAWQzpR6qWDp5n7nwHjyF2i0s7ihEAKdMcUNhGuWLGBasvTNUt43SM7eQ6 qZrPdEfpfEcTaq/g9gniTF6nJe3qu/3Rrtqty6KeDC1vpbr+EtHme9AE3zS6nQ0/wy0R CvmMaboh2METLgRBuZb0iaPVePbVXOcVedeTOFl7uoeqB6EdwRdDhQ0kpHsJFQhg50QN ocjujfTsJZjZRDo9VtK3ti4N3ZufrPIhSFnHEW9fh7u4o4CY92Jd2x8SS55+XnE7nkem X3eV52yxbYHuc9QHFKY3ABGz3zrBd/9QspS+wqf79a/kohzRnESfQBKwxsx8DhEshWMe odRA== X-Forwarded-Encrypted: i=1; AHgh+Ro0uTLrD9sCW8hsP9r+3HMoR76foHzijmh1ESqEXLyQH5r5D3ttBSrzL2FYs83ybzT4BdZBnGzKe9+ux/Q=@vger.kernel.org X-Gm-Message-State: AOJu0YxaaHFAHcvgLkRVJFB6Ou0ZJBeiZ8Sh7H6FAPc0a5XbvFNzh/7M PAf5qVfHkE4spKVYg+8IETXeuvRzoEUTeYimB//cl7cn/kew/9TKpHaXHYOlag== X-Gm-Gg: AfdE7clDwdBw0mWwS5dOIxoSJnwGYy39TU7IJJkeM1cb640DxBIBmAQGp5Nl+wt903K ET4HXY7iFMUm1Q+p6Bb9XUwWcfmyLANcckRyYirEGiwXrg8f+B30wu4DeO+vk8D84pTuCEoYvvd IEIYvnLUJoSx8hWH4RssFl/k5+UPpVjHFKPPolw6in2s2JTouWh1Jggdtr3CmDF9dIbEvaUSQq9 6z8dBfTbqdfYGGZHeiFgZcL0WGX5t696vLQ8isjjn4VDsMCDpbAVSIU3j4HBHSlMgIeiuUDwrch fud0xEFJL99T39C3bETGyppWNkPYsKMYDLorr5mKGfj/D2l1jA6YSbRnNqQtXqcDIz2XBjtOV4f sOaPFFv4/R6mGX3O7c+XkwhlDk+3lEkn5QdMkwWtERJA3hrd67PWz0/Fd4kn44bAy7X8U7g6t47 lU8kE8kNWfuWu2h71YJvBGt4TYFIOo X-Received: by 2002:a05:6a21:9d48:b0:3c1:85d:fa2f with SMTP id adf61e73a8af0-3c1108c2d4fmr2062836637.36.1783752003709; Fri, 10 Jul 2026 23:40:03 -0700 (PDT) Received: from localhost.localdomain ([116.68.83.225]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-311b00048a3sm17907959eec.5.2026.07.10.23.40.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 23:40:02 -0700 (PDT) From: Anantha Krishnan To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Anantha Krishnan Subject: [PATCH v2] staging: rtl8723bs: replace magic number in InitBeaconParameters Date: Sat, 11 Jul 2026 12:09:02 +0530 Message-ID: <20260711063901.30828-2-ananthanr.off@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <2026071157-ovary-property-4427@gregkh> References: <2026071157-ovary-property-4427@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Per the bitfield comment in hal_com_reg.h, REG_TBTT_PROHIBIT packs a "setup" time in bits 3:0 and a "hold" time in bits 19:8. The rtw_write16() call here only writes the low 16 bits of that register, covering the full setup field and the low byte of the hold field. Replace the magic number 0x6404 with two named constants representing these fields. No functional change. Bit-field positions are documented in the comment above REG_TBTT_PROHIBIT in drivers/staging/rtl8723bs/include/hal_com_reg.h. Signed-off-by: Anantha Krishnan --- v2: Use full name in Signed-off-by and document the source of the bitfield values (comment above REG_TBTT_PROHIBIT in hal_com_reg.h) per Greg's review. drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index bcaf63b2893c..699e24f52392 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -11,6 +11,13 @@ #include #include "hal_com_h2c.h" +/* + * Bitfield layout per the comment above REG_TBTT_PROHIBIT in + * drivers/staging/rtl8723bs/include/hal_com_reg.h. + */ +#define TBTT_PROHIBIT_SETUP 0x04 /* bits 3:0: setup time, unit 32us */ +#define TBTT_PROHIBIT_HOLD_LOW 0x64 /* bits 15:8: low byte of 12-bit hold time, unit 32us */ + static void _FWDownloadEnable(struct adapter *padapter, bool enable) { u8 tmp, count = 0; @@ -861,8 +868,8 @@ void rtl8723b_InitBeaconParameters(struct adapter *padapter) rtw_write16(padapter, REG_BCN_CTRL, val16); - /* TODO: Remove these magic number */ - rtw_write16(padapter, REG_TBTT_PROHIBIT, 0x6404);/* ms */ + rtw_write16(padapter, REG_TBTT_PROHIBIT, + (TBTT_PROHIBIT_HOLD_LOW << 8) | TBTT_PROHIBIT_SETUP);/* ms */ /* Firmware will control REG_DRVERLYINT when power saving is enable, */ /* so don't set this register on STA mode. */ if (!check_fwstate(&padapter->mlmepriv, WIFI_STATION_STATE)) -- 2.43.0