From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCD3335294E for ; Sat, 11 Jul 2026 11:39:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783769989; cv=none; b=JvmElfbusK318FYHJr53chf5jdoEE5vhiWb3KBgCxsb2S1hdfH5Iq76Nvvnflywjv7MApdkxAgZqzg8rfRDu4x9k1J8ouwSOosL59F4HJNJ3YTOUWv5UpBl1iTUjax/74YXW/wKx/SczTSZGfw5eND40Pb1PyjB4NsHxXe2UsTk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783769989; c=relaxed/simple; bh=0h+eMXw/kfLWugCSiijk6RrUkOgLb8fXGrBDBYxoGwY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c4FdPr8G5rkw5RBUTH92MkKne66jEchSvcTvyhVUpOnQ06bKS6mTPGurfnaao5hsTpCiMTwuF+0A2Wo9JaHPz+ITlj7HmNMQ9N7oP6lEgX37DEK9ZWpBStnBbyeCp+8xIIQ5fEBP0MYv2dTYlkND8ysKApj6969MS0PvMACcwT8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K0z3J/xs; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K0z3J/xs" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493c52cde9eso15991935e9.3 for ; Sat, 11 Jul 2026 04:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783769986; x=1784374786; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xjbNk6EtrHaZnnL2B59jNPMm165JgqnkuXclu5z98Bs=; b=K0z3J/xsRPisTJH/q8a9JCJcH5dAb56dHb2jZU8nKfy184rVR2TmbYLFZsOtDTNQgv qL8TU+2kY9AB0OYqkUM1qE6w6wBMMVYXLaVWW34X4tbMMTd4UZ42wK2WYMq0uKyDdULm A97VLHQ31H+1JpaUC9Wl21usrI8cyFp6BdWjRsqQIuE9Ve8eoP64HTzuwL01ylxCiEBV d5mZCJGLf1jzwY6RMxH9Owic9K6cK0V7MbnE8VLUxOTrB0vjRdTN6ujcxIjgRlg0RF4t H6MurWvkD0merGFo9N9jbNFvuLWyqEzx/ExEXWyLgiwXSOjFQ1QF7sz8zmfm2lLnRhxs AmUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783769986; x=1784374786; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=xjbNk6EtrHaZnnL2B59jNPMm165JgqnkuXclu5z98Bs=; b=TTFDFt14stao7dPPLQUkwYFunbAo8R3lw8Zserkvn9caomHMyE3kPu1nFkK2rOLjbE UylFQCm8sx5FXbKRPRY4vEmf4eeYufX5h2fwnK2QHGlmgl+Fu7QLTyzgBKXKRiUQLF1q grYH6xBz1YgNrnid/UpgvIsJJ6jR4PdyskOGp9Tat6lrlbkzdoNl4qBVWkuITFIRCAFd 0lZHu8eGXSbxvVqHzKRDCUOaNI01tjot5+l7LRKwUqDYBiApYmWTnbpq705g8KiL1uL6 yWjRXCKUSsIYEnJ5coC+LVR078TMRuQQDO3NZWCOuia4PRF3G/FDLwWLHvYokl8E9NK5 LqGg== X-Forwarded-Encrypted: i=1; AHgh+Rqs8N7XcDaYmnofaR5p0UPmsC9wFP1ZaO7fEjqEdYR+D+xpNR/fHfJI98alkEQF/BoGguurNRHRyh/Z0Qc=@vger.kernel.org X-Gm-Message-State: AOJu0YzeAdqcZ721BK/Dcbl9gzAl0d8dFPiSkKCLLlYoTCgFvcY+0U87 c5mKVkNT/6MizAC29MCtMxd5d643sqdOw5dNGZ05sTmG83nxNu6oEjnf X-Gm-Gg: AfdE7cnw3w+pr2n7IK54hginQXm+SypKRbEdiV9wQxVo0O1ilOa7El6Zk+2x42J734a uRBdFyVrI+6iXhO3zUIVuq8bzNlvRo2h1zezPB4IgCEP+fKPzwvZzHRWtZNcvJabjnMVEc589YQ 9Mp/tNYooSNJq0UfyF+NF1fxpkJp187I7bR1AFEJ9FQySMM5DWH0Q3FcEdU3t/evU/xw9bfytJn cxgX/ROhaZPNvPGqTNWROdxDkNd4VWGxRNUToggoUJvL/XkBoQ3gKtUnxCzUbLG3cNReS8rm5fP ARjLaowwFx1nqZBcm6C8ixy/lfpfgEYIcJT92e2QPxmi6XVadKV4NMb67FI3p9qW3+9RK/oTNjS MVuI9jQT6FytWUic9oNcZdMl1VwTTUE8erCmKx7hI4jmH7tLfArEVnSKV1LAuuGM7IQJWXUOkJy 4adFVrbhUXE+KEVLqiYj9xCfaErvem X-Received: by 2002:a05:6000:2305:b0:47d:eee8:ec40 with SMTP id ffacd0b85a97d-47f2dcd717dmr2491274f8f.38.1783769986131; Sat, 11 Jul 2026 04:39:46 -0700 (PDT) Received: from unknown.tail46804.ts.net ([2a02:b027:11:e106:f973:a70:bd1e:4000]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-47aa0a55be4sm62817520f8f.31.2026.07.11.04.39.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 04:39:45 -0700 (PDT) From: Gianluca Boiano To: "Wang, Sen" Cc: Gianluca Boiano , Mark Brown , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Shenghao Ding , Kevin Lu , Baojun Xu , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] ASoC: codecs: add TAS2557 mono smart amplifier driver Date: Sat, 11 Jul 2026 13:39:36 +0200 Message-ID: <20260711113936.71958-1-morf3089@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > + unsigned int asi_offset; > > Why does asi_offset need to be computed in both hw_param and > set_tdm_slot? Shouldn't setting it in one of them suffice? AFAIK both > func ran once per stream request. hw_params() was computing a default unconditionally, clobbering whatever set_tdm_slot() had set. v2 adds a tdm_configured flag: hw_params() only computes the default when set_tdm_slot() hasn't run. > For the firmware parsing, could we possibly reuse/extend the defintion > headers from > https://elixir.bootlin.com/linux/v7.1.2/source/include/sound/tas2781-dsp.h#L43 Checked tas2781-fmwlib.c. Same magic (0x35353532), same TI toolchain lineage, but the formats diverge past that: tas2557's header carries DDC-name and description fields tas2781's doesn't, tas2557 has a mandatory PLL block stage before power-up that none of tas2781's parser variants have, and tas2781's parser is built around its multi-amplifier device-index model that tas2557 doesn't need. Not sharing code between the two. > If write failed hw_params should return the corresponding error code > from ret no? Right now hw_params will return success regardless. Fixed in v2, both writes now return on failure instead of just warning. Gianluca