From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D806F3C872C for ; Sat, 11 Jul 2026 13:11:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783775510; cv=none; b=g8sRGpowRxzeT7a/n0f9jQBtltul0222WHGD4duf2hSvd4s5rq+Md1tCY6GbWZrzXX05M3CrBiuNEiIYz23uZsDU7alQsiVnEc5kuI79IDV0ZYGx8rPAnd+ss4m0dUqkQXf/YQ9kDJYuSpBXqmm00cmmabVKKwfPPkSenb8womA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783775510; c=relaxed/simple; bh=o2Hiy84rnP/9UMKURCEIhcD7/nHJlcIAPilhOK3M2oU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=La0zmBT/dDiYn0eIQ6D43Vzl3y/b9UGSpTWAJhQW32bsdY8TCrEXO35uCiW7VCtCYfOL4VDtXLLwpGN5p6garlTIBCR13jvfM3YwQk94ASueowqrm4oi7RPMqeJ0H29RHbaWCFGEipHDbn1f0008zmbnoJvXssH1Kg7ajabKxvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-381507c9380so1239839a91.0 for ; Sat, 11 Jul 2026 06:11:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783775508; x=1784380308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=kJ53oWqRjCNjVlROCxKHTEOJ8pLHHBllpxRR0nGEHyI=; b=dOYpqABRtptFu90BN6f/Owl/071Qy7aybRu3TH3XI6zwg/Izur89YCXSRAgmlOymFc G9AI6fVA48bKReVAvZz+6PlUzTbBT0iSH9Y2Eg3TFNFyqTeLI5HfwlewMB8CBw4mb5PR D/lQhiDvGCbYDVN4HzdZVlnbeZR8nBtdDT0xUPj4pGkhWxSEI+AA0YjPlipEosc9IQV7 KYj0uA7+U03YfVyDz31Sn98LUMhykSKo3GgYtFonPn5wZ9IkLN0XWoMcn4eymrc5P0Jr wEV/cr01QK7t5BaX0HsPxdQQZGeev2Jp8167m5goEYHFbUhiAM7p/5nRm1DPk5T7tomQ iwtg== X-Forwarded-Encrypted: i=1; AHgh+RpGvuFKm0tEd334SphFl7T7iYzmmba/iYIJvVkTu8do/JiapNierq6/QTCX6RMydZAf7aPYxde+0huc4N0=@vger.kernel.org X-Gm-Message-State: AOJu0YyB70FF8/05N1wC6sDKKjy/uHz7h0YsK4yoXh3QyRbAJit72iVp Q7UqSWEnC8VfcSyFl+LAaMqkaMpxA5dPPTEykRprDmPP6irY/AfcjF8= X-Gm-Gg: AfdE7cnGIvGYq0/LdmV7gVAaEkdw0JNKMoc46tJ7GJlyqlKNb6P3+95Ghi1Gv5VafT6 ShWm2yf2X1IreTqwcPYPBwKnU4meg8Ym7ed8SsXhZxkN9kljeSJE313PPvZ1PvlgPgNnmA4Oyxi 98nTk1DXorrMbvNhEifkse4r9GZcayHlR6n0eiPWtR0PQnpBmdN9EoB2QvYR357lU0emvVPLzZH LKoZikFTlc3DQ2YKYnESEu4LwXBPW9ibAqWPCimEwLMtnKlMIBuVaYRZU2jzVqdjzT9vxPXgNT8 QPn664eQFiODDTR6ToQFKxSkHYziuilYUV7ZXVGb/7LYKeqTY1UFiz/lVutv9nCk3BA78UMlS5P 1UjSG77UwPB4opfMTkOPEdZWjX5WQXSEFgGqyHJGXxmdUMQigwI+Bqce8H6prAPoXryumq4eI9z vR6x4xCRkTlW3Qyz2wg1K55NvcE/XrY1zwXYuOzx8UB0PRlOnFwoX6r9NNT+Txp3BM0diUXhyJw qTySBm1Ik/Y/eDR/g0Jpx0gvg== X-Received: by 2002:a17:90b:224c:b0:381:b64b:5a28 with SMTP id 98e67ed59e1d1-38dc779eb0bmr2445869a91.30.1783775508217; Sat, 11 Jul 2026 06:11:48 -0700 (PDT) Received: from penguin.tail0a1999.ts.net (61-228-52-13.dynamic-ip.hinet.net. [61.228.52.13]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38a55557f25sm4136221a91.5.2026.07.11.06.11.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 06:11:47 -0700 (PDT) From: Shih-Yuan Lee To: Dmitry Torokhov , Mark Brown Cc: linux-input@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Shih-Yuan Lee Subject: [PATCH v5 1/3] Input: applespi - cancel pending work on driver remove Date: Sat, 11 Jul 2026 21:11:38 +0800 Message-Id: <20260711131140.18777-2-fourdollars@debian.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260711131140.18777-1-fourdollars@debian.org> References: <20260711055247.5412-1-fourdollars@debian.org> <20260711131140.18777-1-fourdollars@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit During driver removal in applespi_remove(), the managed private data structure is freed by devres. However, the driver does not cancel the asynchronous work applespi->work, which registers the touchpad input device. This creates a use-after-free (UAF) vulnerability if a pending or running worker thread attempts to access the private data after the remove function returns. Fix this by explicitly calling cancel_work_sync(&applespi->work) in applespi_remove() before cleanups. Signed-off-by: Shih-Yuan Lee --- drivers/input/keyboard/applespi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/input/keyboard/applespi.c b/drivers/input/keyboard/applespi.c index b5ff71cd5a70..3bdb9e7cfb8b 100644 --- a/drivers/input/keyboard/applespi.c +++ b/drivers/input/keyboard/applespi.c @@ -1822,6 +1822,8 @@ static void applespi_remove(struct spi_device *spi) applespi_drain_reads(applespi); + cancel_work_sync(&applespi->work); + debugfs_remove_recursive(applespi->debugfs_root); } -- 2.39.5