From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E99526ED40 for ; Sat, 11 Jul 2026 14:43:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783780998; cv=none; b=Ut2FNUWlHvDspHPcRgmejTljvYWLyB0ogTZc6PsCA+sDZ4vdrTgEn1XCwf9ovyfL38dXEVJTdS3r8YdBLKqDwe2TccZZB3CxRkEBzmazG+ga/Gg9xJdRd2oiXsZQLihQlmSMRKmyIRbdF3TPXoaDRJfafHpj9CH4Z/4BKt7PYSA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783780998; c=relaxed/simple; bh=LJki9Gw5Fm/A5qmGEAyzobNH0PCLwcGq1UPV0wpyHMA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tzZlG6yolL+/couHzfDOkE3LFRk/IWxIZbqzYKE+W/n00TomWVkk6j62OrNRcXzISwv92Y6dzLCs9O0fM6ar1dnaO4D8DJfYK5x/aMaxTC5UzHBC8bv347mkf6+bfB86PQCo+MuIMunGIiULNPwofn6aM3VE36vhSS8QfR8gOm8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kp8/uT62; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kp8/uT62" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2cc7ef7ec27so19805845ad.1 for ; Sat, 11 Jul 2026 07:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783780996; x=1784385796; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=NrmJ+0bq+1sY9p6nXxTAfxMvIH+K5N5pqOqXO5agSrg=; b=kp8/uT62lJJia3uEplcluZyuGWYoWSG/qN2uhWURxXfpCBHoHQvJCrGEmTsMKh7IID 1KZAegYHzqECefwEUIYV0ZSSw6HTeVJbGO0EPMRQAXW5a5Ywghnsf9UPzr0dJjlq/FtC uYdkGgRnw4kgCIGvOWVz2xUWMM8+lY8LN0Yl6OLyJYrEQlgfnbKTO71lkTL2FTzqTUG5 4W96LXd/16672y7F1aUuMbNbuMRcE9iAN+YKfIM9C7CkhkAtfMdD9zOXY6QHVwFcLl7h eR4W1ai+OzdpcIoeJ3Cmki8gKCEK9ykE91AFlY3rumFBhO3rbiJ7rZbdOrzWySruDfV/ mvaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783780996; x=1784385796; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NrmJ+0bq+1sY9p6nXxTAfxMvIH+K5N5pqOqXO5agSrg=; b=eIcURqKJmmhdpQohU6MsvP59btMzj5p+udMVoLa1//6wQEszphNVSfQAJ+q7Agkiff 4y0TewwyrltTMGjvF2CMZwL7Spkt0ujFbAG0GmxywTQ0EPXuxJjuwJmB5xl75sxbqd9l u6oakwfeLyKDQJlRZE0PBvCcWRZhVIj4Yz8l5srf/iNYOA5MPE6I62aLVill8aK06cB7 aeqR4LZ4Rc3YttkUusNQpN6e1epMxepYB161e6ZZ7cOyZiV2RYTvlPdh5XYXeiZDMqpw C109yifiU0YCD/7uDMkMj3SpJK2OqoR3LDyhD+DGzH/ZONw9q/yNlySPqYvXx54nbDMI S8IA== X-Forwarded-Encrypted: i=1; AHgh+RrJlLLlUCAbHCWyoZpcFGP/E5V3zdgs19aclF2rKGDH8dh4i28tKqOBr+9oTWYpSGeG5BPybr8osHocJcU=@vger.kernel.org X-Gm-Message-State: AOJu0YyLVLC7Vr3qeXFkF4Ne9bR42EbTBmF0uV70jEBzV+GQ29FltvcJ h+Ytt8eSmtdp3Cm4JVXEvTXNq5/Qtu/xlyzohQpPzE9Tn34vGKolIDMz X-Gm-Gg: AfdE7cmckd8DDSp9go4zeosjgo8fnlU211GEyUw5lMoymauPnWDO06zFPAQI3NxnbKM +0W0RUfS7ukm8eXxjt3C2iSZh2CphK+nw4VC4KdPe+qWsTlFSr6Vs2f+ewQPbMGaHVpXet2inHo DaczcwRJ3/1BZ4/S0j72MNSvK3/DKEEwR/4qXt3uXxiiGgxdKpZG6JkdQVj3ysuXlmq+Ozxv7TY 6Rm72CmV5cbT++bjkI8x/0kEjroqetamZlfxOmU4F3wVlpDt1oMTVAYxPU0Zu7TLwHoMJhGDnvQ JLpduVNTB49N1AmmHwCPvVgvy1m4yY9CAj5UONPS+xFkh9+hr+LYOzhCXx+s1aBebrM5aI34NUE ZYQqJIxiXUFZqJfAmBA9EqyXaFronusmFv3kc/I/qxwQWXhUnDO3Ev3CpU0Tzxuz8I3WKV3TPKr 9xt/VVf38+8juUxcjPA8CNdxau74V1xr5v X-Received: by 2002:a17:903:f8b:b0:2ca:a284:a136 with SMTP id d9443c01a7336-2ce9f1608e4mr33187265ad.42.1783780996395; Sat, 11 Jul 2026 07:43:16 -0700 (PDT) Received: from localhost.localdomain ([2409:8a55:d1c4:9324:e872:b3bd:74cf:7935]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d1e1aesm75661525ad.39.2026.07.11.07.43.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 07:43:16 -0700 (PDT) From: Yuhong Cheng To: castet.matthieu@free.fr, stf_xl@wp.pl Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Yuhong Cheng , syzbot+123456@syzkaller.appspotmail.com Subject: [PATCH] usb: atm: ueagle-atm: fix use-after-free in uea_upload_pre_firmware Date: Sat, 11 Jul 2026 22:42:59 +0800 Message-ID: <20260711144259.1124-1-ceohunk@gmail.com> X-Mailer: git-send-email 2.46.0.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit syzbot reported a slab-use-after-free read in uea_upload_pre_firmware. This is because the usb_device is passed as context to request_firmware_nowait but its reference count is not incremented. Thus, if the USB device is disconnected before the firmware load completes, the callback accesses a freed usb_device. Fix this by taking a reference with usb_get_dev() before calling request_firmware_nowait() and releasing it with usb_put_dev() in the completion callback or if the request fails to start. Reported-by: syzbot+123456@syzkaller.appspotmail.com --- drivers/usb/atm/ueagle-atm.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index d610cdcef..eaf2f2d3a 100644 --- a/drivers/usb/atm/ueagle-atm.c +++ b/drivers/usb/atm/ueagle-atm.c @@ -663,6 +663,7 @@ static void uea_upload_pre_firmware(const struct firmware *fw_entry, uea_err(usb, "firmware is corrupted\n"); err: release_firmware(fw_entry); + usb_put_dev(usb); } /* @@ -693,13 +694,16 @@ static int uea_load_firmware(struct usb_device *usb, unsigned int ver) break; } + usb_get_dev(usb); ret = request_firmware_nowait(THIS_MODULE, 1, fw_name, &usb->dev, GFP_KERNEL, usb, uea_upload_pre_firmware); - if (ret) + if (ret) { uea_err(usb, "firmware %s is not available\n", fw_name); - else + usb_put_dev(usb); + } else { uea_info(usb, "loading firmware %s\n", fw_name); + } return ret; } -- 2.46.0.windows.1