From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19831281532 for ; Sat, 11 Jul 2026 14:49:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783781375; cv=none; b=XjqPbvmSoCYRZ7qPJ4JeIIZbH6ptVflWIE7TioRuIFgigwtsnysnI+T6MdDp6o8G6hS7R96itOqoBVXoehPBbUrqrFOJo7eUVl5+LH5+xsWLH+Jf7lRIARk16Gw3yY4GGIyE/Sa7PIXZVDkWbuyi/654JCJ9CaBVCaXAhy1kUCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783781375; c=relaxed/simple; bh=fm0yQ7z4cnq8Psghzyj7Wh2yTahtrMVPopS+qH6d5fc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l3Xt2BEfkN+pDI8CDJIcDNtUM4Me4lylELuqNEFC99SF0FMe3Mqz0ONx2f34IsGIcWddJ0eGrqOf2U2qeCwl4KxdUzXmpzuRi7R11uElGQBmPYHPU20SYa6RJCpY7uCKMxd40NuzdT7tzomzLteDy/62GgNnRJzVuxk4Jesi9FE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FtQR2QiL; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FtQR2QiL" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ce87c7e3bbso17555705ad.1 for ; Sat, 11 Jul 2026 07:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783781373; x=1784386173; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=F8dbFaTe/STEdFp6CIG1R/5lJi6txXpb8oJ97mPl3Po=; b=FtQR2QiLg2lkrLahVnpplmZttMLrN5PNdTxazbiyHPTfWwxsyrfR/3OvUvgBjiozGp Mnn2mTXmBwMcU3NHwnuPPdozVpTiM2TTaUlVYgWavhsDtvSojPwTad8RNTk6MB/Z/jbk 9QyZbP/EJYh6DTtQbXJZrcKy1MGaYbSY5blO6k9dabtu30q3ej/1kmX2ewBBA1xvLjBI q426BlZjd/tiQGRYmDMKNjBUDIRQOLtub4OdaLzlkq1MPez8e5J44YRstPHgF5sITb5K ve56wicjVPAfDGh7mX8DwZx1PdtSxjbLjUqk2JwUJF1Y2Gd9CDMbJMe8jN9YjjoQ5xVD 3iQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783781373; x=1784386173; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=F8dbFaTe/STEdFp6CIG1R/5lJi6txXpb8oJ97mPl3Po=; b=eB6FzFOSdhaIs34mfQDDGOXGFyUDDVwM1v0dxb4LAOFEqGJ3eq4l167Gwg4Q/38VIW TTJmoEY15qgpEDC42hLoNK8i17atUsh/lcx47tSDZjS6bgCD6MaSaIJn01CgJEnKCgcz QDHvQ11CfWnVyBQKfGBhKtxMwuA0aEGu5p0iu1KNfVP7SZTlCxvi5hPzspD9F8eyIW7k W3w4g/iIWGg0MihWuewEwB84LGEOq7rc5gdlzYPvXXCmxmB3c1LNHNolUPMUleNe5i9O E5Srz+rhL6OrK1vU0kjsUWi0njM+FVIzgdfr4XJUgnUZ2RZdzZ1vfPp7sY7L26lnh/sj nkFA== X-Forwarded-Encrypted: i=1; AHgh+RoGZvDhuE6K6NabFYiodaVh3CCHGP3HCXr3DFy59JEgu5pUUfF28cnR95fsIsCty9G7+Pvq8GDvoac8Lyc=@vger.kernel.org X-Gm-Message-State: AOJu0YziVvS/iXtPhSm7nHCEPbDsuk0nJy16WPKmYhYGENZGvccOY6JX On/zWMiRK0L+EOogR+xMO2AJNWMRQiI6L/KGY68sfzZRhb+BILkWSvoW X-Gm-Gg: AfdE7cnQw/RRnFFomkcjdzA0r7tv3as1hH2UxZwX5IbSk2EmrSWGQBBfg5otBURsqRq 0xwhL5O0YwiW0zwf5yE15wGaNZXCM45tMK4PNZzMnYGcg3q5R8fJXpjI/oKNsV63vMp7fri1n9V phNfByXg7vgX75vJekIAoQUgfZB5BTufmS6WsOHoX4toLaoOzTyQrmVhSqzTRSpk71iYmB2CO4y Boapn5kZ/t/2naHnLiuowL5T5qxiBOkGYLad4+IAwsWGgV2IIPsrDeR6fioFNGZ4iaKkweBgZd7 5L4n9f7C4CL+AssnY7dpxPIGHa8hJnT9K18u7QhsRun6uH6BWSUMQ8vTz8t9RO42pNZ9/IfzkkX Z5OoW9IENl+z0vMZAZWWkNyEemPYmS9GDUrNmhDJxGUhLj1YeD9cFTJkdwGrhVhhYptKuoQWnEr 1sXn9IBEPnxRtcF9CU9ufROLAd3zLA7D41 X-Received: by 2002:a17:902:e785:b0:2c7:f2c6:89e0 with SMTP id d9443c01a7336-2ce9e7941c5mr33965035ad.4.1783781373215; Sat, 11 Jul 2026 07:49:33 -0700 (PDT) Received: from localhost.localdomain ([2409:8a55:d1c4:9324:e872:b3bd:74cf:7935]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d1edb0sm73632475ad.53.2026.07.11.07.49.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2026 07:49:32 -0700 (PDT) From: Yuhong Cheng To: castet.matthieu@free.fr, stf_xl@wp.pl Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Yuhong Cheng , syzbot+3d45d763d18796f97412@syzkaller.appspotmail.com Subject: [PATCH] usb: atm: ueagle-atm: fix use-after-free in uea_upload_pre_firmware Date: Sat, 11 Jul 2026 22:49:18 +0800 Message-ID: <20260711144918.402-1-ceohunk@gmail.com> X-Mailer: git-send-email 2.46.0.windows.1 In-Reply-To: <6a42df07.854d4ab9.360e1d.000d.GAE@google.com> References: <6a42df07.854d4ab9.360e1d.000d.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit syzbot reported a slab-use-after-free read in uea_upload_pre_firmware. This is because the usb_device is passed as context to request_firmware_nowait but its reference count is not incremented. Thus, if the USB device is disconnected before the firmware load completes, the callback accesses a freed usb_device. Fix this by taking a reference with usb_get_dev() before calling request_firmware_nowait() and releasing it with usb_put_dev() in the completion callback or if the request fails to start. Reported-by: syzbot+3d45d763d18796f97412@syzkaller.appspotmail.com --- drivers/usb/atm/ueagle-atm.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index d610cdcef..eaf2f2d3a 100644 --- a/drivers/usb/atm/ueagle-atm.c +++ b/drivers/usb/atm/ueagle-atm.c @@ -663,6 +663,7 @@ static void uea_upload_pre_firmware(const struct firmware *fw_entry, uea_err(usb, "firmware is corrupted\n"); err: release_firmware(fw_entry); + usb_put_dev(usb); } /* @@ -693,13 +694,16 @@ static int uea_load_firmware(struct usb_device *usb, unsigned int ver) break; } + usb_get_dev(usb); ret = request_firmware_nowait(THIS_MODULE, 1, fw_name, &usb->dev, GFP_KERNEL, usb, uea_upload_pre_firmware); - if (ret) + if (ret) { uea_err(usb, "firmware %s is not available\n", fw_name); - else + usb_put_dev(usb); + } else { uea_info(usb, "loading firmware %s\n", fw_name); + } return ret; } -- 2.46.0.windows.1